* [PATCH iwl-next] libie: log more info when virtchnl fails @ 2026-04-24 3:15 Li Li 2026-04-24 16:07 ` [Intel-wired-lan] " Loktionov, Aleksandr 2026-04-27 10:40 ` Paul Menzel 0 siblings, 2 replies; 4+ messages in thread From: Li Li @ 2026-04-24 3:15 UTC (permalink / raw) To: Tony Nguyen, Przemek Kitszel, David S. Miller, Jakub Kicinski, Eric Dumazet, intel-wired-lan Cc: netdev, linux-kernel, David Decotigny, Anjali Singhai, Sridhar Samudrala, Brian Vazquez, Li Li, emil.s.tantilov Virtchnl failures can be hard to debug without logs. Logging the details of virtchnl transactions can be useful for debugging virtchnl-related issues. Tested: Built and booted on a test machine. Signed-off-by: Li Li <boolli@google.com> --- drivers/net/ethernet/intel/libie/controlq.c | 15 +++++++++++++++ 1 file changed, 15 insertions(+) diff --git a/drivers/net/ethernet/intel/libie/controlq.c b/drivers/net/ethernet/intel/libie/controlq.c index ebc05355e39d..7eaa77413621 100644 --- a/drivers/net/ethernet/intel/libie/controlq.c +++ b/drivers/net/ethernet/intel/libie/controlq.c @@ -762,6 +762,16 @@ libie_ctlq_xn_process_recv(struct libie_ctlq_xn_recv_params *params, status = ctlq_msg->chnl_retval ? -EFAULT : 0; xn = &xnm->ring[xn_index]; + + if (ctlq_msg->chnl_retval) { + dev_err_ratelimited( + params->ctlq->dev, + "Non-zero virtchnl ret val (msg op: %u, ret val: %u, msg_cookie: %u, data_len: %u); xn op: %u, id: %u, cookie: %u\n", + ctlq_msg->chnl_opcode, ctlq_msg->chnl_retval, + msg_cookie, ctlq_msg->data_len, xn->virtchnl_opcode, + xn->index, xn->cookie); + } + if (ctlq_msg->chnl_opcode != xn->virtchnl_opcode || msg_cookie != xn->cookie) return false; @@ -1011,6 +1021,11 @@ int libie_ctlq_xn_send(struct libie_ctlq_xn_send_params *params) params->recv_mem = xn->recv_mem; break; default: + dev_notice_ratelimited( + params->ctlq->dev, + "Transaction failed (op %u, xn state: %d, id: %u, cookie: %u, size: %zu)\n", + params->chnl_opcode, xn->state, xn->index, xn->cookie, + xn->recv_mem.iov_len); ret = -EBADMSG; break; } -- 2.54.0.rc2.544.gc7ae2d5bb8-goog ^ permalink raw reply related [flat|nested] 4+ messages in thread
* RE: [Intel-wired-lan] [PATCH iwl-next] libie: log more info when virtchnl fails 2026-04-24 3:15 [PATCH iwl-next] libie: log more info when virtchnl fails Li Li @ 2026-04-24 16:07 ` Loktionov, Aleksandr 2026-04-25 1:50 ` Li Li 2026-04-27 10:40 ` Paul Menzel 1 sibling, 1 reply; 4+ messages in thread From: Loktionov, Aleksandr @ 2026-04-24 16:07 UTC (permalink / raw) To: Li Li, Nguyen, Anthony L, Kitszel, Przemyslaw, David S. Miller, Jakub Kicinski, Eric Dumazet, intel-wired-lan@lists.osuosl.org Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, David Decotigny, Singhai, Anjali, Samudrala, Sridhar, Brian Vazquez, Tantilov, Emil S > -----Original Message----- > From: Intel-wired-lan <intel-wired-lan-bounces@osuosl.org> On Behalf > Of Li Li via Intel-wired-lan > Sent: Friday, April 24, 2026 5:16 AM > To: Nguyen, Anthony L <anthony.l.nguyen@intel.com>; Kitszel, > Przemyslaw <przemyslaw.kitszel@intel.com>; David S. Miller > <davem@davemloft.net>; Jakub Kicinski <kuba@kernel.org>; Eric Dumazet > <edumazet@google.com>; intel-wired-lan@lists.osuosl.org > Cc: netdev@vger.kernel.org; linux-kernel@vger.kernel.org; David > Decotigny <decot@google.com>; Singhai, Anjali > <anjali.singhai@intel.com>; Samudrala, Sridhar > <sridhar.samudrala@intel.com>; Brian Vazquez <brianvv@google.com>; Li > Li <boolli@google.com>; Tantilov, Emil S <emil.s.tantilov@intel.com> > Subject: [Intel-wired-lan] [PATCH iwl-next] libie: log more info when > virtchnl fails > > Virtchnl failures can be hard to debug without logs. Logging the > details of virtchnl transactions can be useful for debugging virtchnl- > related issues. > > Tested: Built and booted on a test machine. > > Signed-off-by: Li Li <boolli@google.com> > --- > drivers/net/ethernet/intel/libie/controlq.c | 15 +++++++++++++++ > 1 file changed, 15 insertions(+) > > diff --git a/drivers/net/ethernet/intel/libie/controlq.c > b/drivers/net/ethernet/intel/libie/controlq.c > index ebc05355e39d..7eaa77413621 100644 > --- a/drivers/net/ethernet/intel/libie/controlq.c > +++ b/drivers/net/ethernet/intel/libie/controlq.c > @@ -762,6 +762,16 @@ libie_ctlq_xn_process_recv(struct > libie_ctlq_xn_recv_params *params, > status = ctlq_msg->chnl_retval ? -EFAULT : 0; > > xn = &xnm->ring[xn_index]; > + > + if (ctlq_msg->chnl_retval) { > + dev_err_ratelimited( > + params->ctlq->dev, > + "Non-zero virtchnl ret val (msg op: %u, ret val: > %u, msg_cookie: %u, data_len: %u); xn op: %u, id: %u, cookie: %u\n", > + ctlq_msg->chnl_opcode, ctlq_msg->chnl_retval, > + msg_cookie, ctlq_msg->data_len, xn- > >virtchnl_opcode, > + xn->index, xn->cookie); > + } > + > if (ctlq_msg->chnl_opcode != xn->virtchnl_opcode || > msg_cookie != xn->cookie) > return false; > @@ -1011,6 +1021,11 @@ int libie_ctlq_xn_send(struct > libie_ctlq_xn_send_params *params) > params->recv_mem = xn->recv_mem; > break; > default: > + dev_notice_ratelimited( > + params->ctlq->dev, > + "Transaction failed (op %u, xn state: %d, id: %u, > cookie: %u, size: %zu)\n", > + params->chnl_opcode, xn->state, xn->index, xn- > >cookie, > + xn->recv_mem.iov_len); For me dev_notice_ratelimited() level is low for a failure messages. Why not dev_warn_ratelimited() instead? > ret = -EBADMSG; > break; > } > -- > 2.54.0.rc2.544.gc7ae2d5bb8-goog ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [Intel-wired-lan] [PATCH iwl-next] libie: log more info when virtchnl fails 2026-04-24 16:07 ` [Intel-wired-lan] " Loktionov, Aleksandr @ 2026-04-25 1:50 ` Li Li 0 siblings, 0 replies; 4+ messages in thread From: Li Li @ 2026-04-25 1:50 UTC (permalink / raw) To: Loktionov, Aleksandr Cc: Nguyen, Anthony L, Kitszel, Przemyslaw, David S. Miller, Jakub Kicinski, Eric Dumazet, intel-wired-lan@lists.osuosl.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, David Decotigny, Singhai, Anjali, Samudrala, Sridhar, Brian Vazquez, Tantilov, Emil S On Fri, Apr 24, 2026 at 9:08 AM Loktionov, Aleksandr <aleksandr.loktionov@intel.com> wrote: > > > > > -----Original Message----- > > From: Intel-wired-lan <intel-wired-lan-bounces@osuosl.org> On Behalf > > Of Li Li via Intel-wired-lan > > Sent: Friday, April 24, 2026 5:16 AM > > To: Nguyen, Anthony L <anthony.l.nguyen@intel.com>; Kitszel, > > Przemyslaw <przemyslaw.kitszel@intel.com>; David S. Miller > > <davem@davemloft.net>; Jakub Kicinski <kuba@kernel.org>; Eric Dumazet > > <edumazet@google.com>; intel-wired-lan@lists.osuosl.org > > Cc: netdev@vger.kernel.org; linux-kernel@vger.kernel.org; David > > Decotigny <decot@google.com>; Singhai, Anjali > > <anjali.singhai@intel.com>; Samudrala, Sridhar > > <sridhar.samudrala@intel.com>; Brian Vazquez <brianvv@google.com>; Li > > Li <boolli@google.com>; Tantilov, Emil S <emil.s.tantilov@intel.com> > > Subject: [Intel-wired-lan] [PATCH iwl-next] libie: log more info when > > virtchnl fails > > > > Virtchnl failures can be hard to debug without logs. Logging the > > details of virtchnl transactions can be useful for debugging virtchnl- > > related issues. > > > > Tested: Built and booted on a test machine. > > > > Signed-off-by: Li Li <boolli@google.com> > > --- > > drivers/net/ethernet/intel/libie/controlq.c | 15 +++++++++++++++ > > 1 file changed, 15 insertions(+) > > > > diff --git a/drivers/net/ethernet/intel/libie/controlq.c > > b/drivers/net/ethernet/intel/libie/controlq.c > > index ebc05355e39d..7eaa77413621 100644 > > --- a/drivers/net/ethernet/intel/libie/controlq.c > > +++ b/drivers/net/ethernet/intel/libie/controlq.c > > @@ -762,6 +762,16 @@ libie_ctlq_xn_process_recv(struct > > libie_ctlq_xn_recv_params *params, > > status = ctlq_msg->chnl_retval ? -EFAULT : 0; > > > > xn = &xnm->ring[xn_index]; > > + > > + if (ctlq_msg->chnl_retval) { > > + dev_err_ratelimited( > > + params->ctlq->dev, > > + "Non-zero virtchnl ret val (msg op: %u, ret val: > > %u, msg_cookie: %u, data_len: %u); xn op: %u, id: %u, cookie: %u\n", > > + ctlq_msg->chnl_opcode, ctlq_msg->chnl_retval, > > + msg_cookie, ctlq_msg->data_len, xn- > > >virtchnl_opcode, > > + xn->index, xn->cookie); > > + } > > + > > if (ctlq_msg->chnl_opcode != xn->virtchnl_opcode || > > msg_cookie != xn->cookie) > > return false; > > @@ -1011,6 +1021,11 @@ int libie_ctlq_xn_send(struct > > libie_ctlq_xn_send_params *params) > > params->recv_mem = xn->recv_mem; > > break; > > default: > > + dev_notice_ratelimited( > > + params->ctlq->dev, > > + "Transaction failed (op %u, xn state: %d, id: %u, > > cookie: %u, size: %zu)\n", > > + params->chnl_opcode, xn->state, xn->index, xn- > > >cookie, > > + xn->recv_mem.iov_len); > For me dev_notice_ratelimited() level is low for a failure messages. > Why not dev_warn_ratelimited() instead? Good call. Switched to using dev_warn_ratelimited() in the v2 patch. Thanks for the suggestion! > > > ret = -EBADMSG; > > break; > > } > > -- > > 2.54.0.rc2.544.gc7ae2d5bb8-goog > ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [Intel-wired-lan] [PATCH iwl-next] libie: log more info when virtchnl fails 2026-04-24 3:15 [PATCH iwl-next] libie: log more info when virtchnl fails Li Li 2026-04-24 16:07 ` [Intel-wired-lan] " Loktionov, Aleksandr @ 2026-04-27 10:40 ` Paul Menzel 1 sibling, 0 replies; 4+ messages in thread From: Paul Menzel @ 2026-04-27 10:40 UTC (permalink / raw) To: Li Li Cc: Tony Nguyen, Przemek Kitszel, David S. Miller, Jakub Kicinski, Eric Dumazet, intel-wired-lan, netdev, linux-kernel, David Decotigny, Anjali Singhai, Sridhar Samudrala, Brian Vazquez, emil.s.tantilov Dear Li, Thank you for your patch. Am 24.04.26 um 05:15 schrieb Li Li via Intel-wired-lan: > Virtchnl failures can be hard to debug without logs. Logging the details > of virtchnl transactions can be useful for debugging virtchnl-related > issues. Why is the first added one added as error, and the second as info? Do you have a reproducer to get each of the new log messages? > Tested: Built and booted on a test machine. Please paste the new messages. > Signed-off-by: Li Li <boolli@google.com> > --- > drivers/net/ethernet/intel/libie/controlq.c | 15 +++++++++++++++ > 1 file changed, 15 insertions(+) > > diff --git a/drivers/net/ethernet/intel/libie/controlq.c b/drivers/net/ethernet/intel/libie/controlq.c > index ebc05355e39d..7eaa77413621 100644 > --- a/drivers/net/ethernet/intel/libie/controlq.c > +++ b/drivers/net/ethernet/intel/libie/controlq.c > @@ -762,6 +762,16 @@ libie_ctlq_xn_process_recv(struct libie_ctlq_xn_recv_params *params, > status = ctlq_msg->chnl_retval ? -EFAULT : 0; > > xn = &xnm->ring[xn_index]; > + > + if (ctlq_msg->chnl_retval) { > + dev_err_ratelimited( > + params->ctlq->dev, > + "Non-zero virtchnl ret val (msg op: %u, ret val: %u, msg_cookie: %u, data_len: %u); xn op: %u, id: %u, cookie: %u\n", > + ctlq_msg->chnl_opcode, ctlq_msg->chnl_retval, > + msg_cookie, ctlq_msg->data_len, xn->virtchnl_opcode, > + xn->index, xn->cookie); > + } > + > if (ctlq_msg->chnl_opcode != xn->virtchnl_opcode || > msg_cookie != xn->cookie) > return false; > @@ -1011,6 +1021,11 @@ int libie_ctlq_xn_send(struct libie_ctlq_xn_send_params *params) > params->recv_mem = xn->recv_mem; > break; > default: > + dev_notice_ratelimited( > + params->ctlq->dev, > + "Transaction failed (op %u, xn state: %d, id: %u, cookie: %u, size: %zu)\n", > + params->chnl_opcode, xn->state, xn->index, xn->cookie, > + xn->recv_mem.iov_len); > ret = -EBADMSG; > break; > } Kind regards, Paul ^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2026-04-27 10:40 UTC | newest] Thread overview: 4+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2026-04-24 3:15 [PATCH iwl-next] libie: log more info when virtchnl fails Li Li 2026-04-24 16:07 ` [Intel-wired-lan] " Loktionov, Aleksandr 2026-04-25 1:50 ` Li Li 2026-04-27 10:40 ` Paul Menzel
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox