public inbox for netdev@vger.kernel.org
 help / color / mirror / Atom feed
From: Ido Schimmel <idosch@nvidia.com>
To: Justin Iurman <justin.iurman@gmail.com>
Cc: Daniel Borkmann <daniel@iogearbox.net>,
	tom@herbertland.com, kuba@kernel.org, edumazet@google.com,
	dsahern@kernel.org, willemdebruijn.kernel@gmail.com,
	pabeni@redhat.com, netdev@vger.kernel.org
Subject: Re: [PATCH net v2] ipv6: Implement limits on extension header parsing
Date: Mon, 27 Apr 2026 09:01:27 +0300	[thread overview]
Message-ID: <20260427060127.GA263748@shredder> (raw)
In-Reply-To: <dca69fa4-2284-4251-a569-8b26ab9fca07@gmail.com>

On Sun, Apr 26, 2026 at 05:47:38PM +0200, Justin Iurman wrote:
> Ido, Daniel,
> 
> As I said, my vote would definitely go to the solution without a sysctl for
> the very reason Ido mentioned. Note that an upper bound of 32 is kind of
> unrealistic, although super (SUPER!) safe. Sending more than 8 Extension
> Headers (assuming a different type for each) is not standard behavior and
> would make you non-RFC-compliant anyway. But I'm happy with 32, as long as
> we don't define a sysctl for that.

OK, so given that:

1. 32 is super safe and solves the issue.

2. We will likely have to maintain a sysctl forever.

3. A sysctl has the potential to be incompatible with the upcoming
"enforce_ext_hdr_order" sysctl.

I believe we can just go with the simplest solution of hard coding 32 as
a limit and drop the sysctl.

  reply	other threads:[~2026-04-27  6:01 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-04-25  7:55 [PATCH net v2] ipv6: Implement limits on extension header parsing Daniel Borkmann
2026-04-25 10:19 ` Justin Iurman
2026-04-26 10:38   ` Daniel Borkmann
2026-04-26 10:56     ` saeed bishara
2026-04-26 13:17     ` Ido Schimmel
2026-04-26 15:47       ` Justin Iurman
2026-04-27  6:01         ` Ido Schimmel [this message]
2026-04-27  8:23           ` Daniel Borkmann
2026-04-27  8:30             ` Eric Dumazet

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260427060127.GA263748@shredder \
    --to=idosch@nvidia.com \
    --cc=daniel@iogearbox.net \
    --cc=dsahern@kernel.org \
    --cc=edumazet@google.com \
    --cc=justin.iurman@gmail.com \
    --cc=kuba@kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=tom@herbertland.com \
    --cc=willemdebruijn.kernel@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox