public inbox for netdev@vger.kernel.org
 help / color / mirror / Atom feed
* linux-next: build failure after merge of the bpf-next tree
@ 2026-04-27 13:26 Thierry Reding
  2026-04-27 13:26 ` linux-next: build failure after merge of the bfp-next tree Thierry Reding
                   ` (2 more replies)
  0 siblings, 3 replies; 5+ messages in thread
From: Thierry Reding @ 2026-04-27 13:26 UTC (permalink / raw)
  To: Daniel Borkmann, Alexei Starovoitov, Andrii Nakryiko
  Cc: linux-kernel, bpf, netdev, linux-next

Hi all,

After merging the bpf-next tree, today's linux-next build (x86_64_perf)
failed like this:

      CC      builtin-trace.o
    builtin-trace.c: In function ‘syscall_arg__strtoul_btf_enum’:
    builtin-trace.c:972:27: error: comparison of integer expressions of different signedness: ‘int’ and ‘__u32’ {aka ‘unsigned int’} [-Werror=sign-compare]
      972 |         for (int i = 0; i < btf_vlen(bt); ++i, ++be) {
          |                           ^
      CC      util/btf.o
    util/btf.c: In function ‘__btf_type__find_member_by_name’:
    util/btf.c:19:43: error: comparison of integer expressions of different signedness: ‘int’ and ‘__u32’ {aka ‘unsigned int’} [-Werror=sign-compare]
       19 |         for (i = 0, m = btf_members(t); i < btf_vlen(t); i++, m++) {
          |                                           ^

Caused by commit

    f7a6b9eaff3e ("bpf: Extend BTF UAPI vlen, kinds to use unused bits")

I've fixed it up like below, but please fix this in your tree as well.

Thanks,
Thierry

--- >8 ---
From 4689669414ed7de19a69803714bc04e96fd82618 Mon Sep 17 00:00:00 2001
From: Thierry Reding <treding@nvidia.com>
Date: Mon, 27 Apr 2026 12:32:06 +0200
Subject: [PATCH] perf: Fixup for btf_vlan() API change

Signed-off-by: Thierry Reding <treding@nvidia.com>
---
 tools/perf/builtin-trace.c | 2 +-
 tools/perf/util/btf.c      | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/tools/perf/builtin-trace.c b/tools/perf/builtin-trace.c
index e58c49d047a2..d22e20a57b70 100644
--- a/tools/perf/builtin-trace.c
+++ b/tools/perf/builtin-trace.c
@@ -969,7 +969,7 @@ static bool syscall_arg__strtoul_btf_enum(char *bf, size_t size, struct syscall_
 	struct btf *btf = arg->trace->btf;
 	struct btf_enum *be = btf_enum(bt);
 
-	for (int i = 0; i < btf_vlen(bt); ++i, ++be) {
+	for (u32 i = 0; i < btf_vlen(bt); ++i, ++be) {
 		const char *name = btf__name_by_offset(btf, be->name_off);
 		int max_len = max(size, strlen(name));
 
diff --git a/tools/perf/util/btf.c b/tools/perf/util/btf.c
index bb163fe87767..50d98f3e83bf 100644
--- a/tools/perf/util/btf.c
+++ b/tools/perf/util/btf.c
@@ -14,7 +14,7 @@ const struct btf_member *__btf_type__find_member_by_name(struct btf *btf,
 {
 	const struct btf_type *t = btf__type_by_id(btf, type_id);
 	const struct btf_member *m;
-	int i;
+	u32 i;
 
 	for (i = 0, m = btf_members(t); i < btf_vlen(t); i++, m++) {
 		const char *current_member_name = btf__name_by_offset(btf, m->name_off);
-- 
2.52.0
--- >8 ---

^ permalink raw reply related	[flat|nested] 5+ messages in thread

* linux-next: build failure after merge of the bfp-next tree
  2026-04-27 13:26 linux-next: build failure after merge of the bpf-next tree Thierry Reding
@ 2026-04-27 13:26 ` Thierry Reding
  2026-04-27 13:45   ` Alan Maguire
  2026-04-27 13:34 ` linux-next: build failure after merge of the bpf-next tree Thierry Reding
  2026-04-27 13:43 ` Alan Maguire
  2 siblings, 1 reply; 5+ messages in thread
From: Thierry Reding @ 2026-04-27 13:26 UTC (permalink / raw)
  To: Alexei Starovoitov, Andrii Nakryiko
  Cc: Eduard Zingerman, linux-kernel, bpf, netdev, linux-next

Hi all,

After merging the bfp-next tree, today's linux-next build (x86_64
allmodconfig ) failed like this:

    ERROR: modpost: "cnum64_umin" [drivers/net/ethernet/netronome/nfp/nfp.ko] undefined!
    ERROR: modpost: "cnum64_umax" [drivers/net/ethernet/netronome/nfp/nfp.ko] undefined!

Caused by commit

    b93f7180f0bc ("bpf: use accessor functions for bpf_reg_state min/max fields")

It looks like the issue here is that these new accessor functions are not
exported symbols and therefore can't be used by a driver that is built as
a module.

I've used the previous tree for today's linux-next.

Thanks,
Thierry

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: linux-next: build failure after merge of the bpf-next tree
  2026-04-27 13:26 linux-next: build failure after merge of the bpf-next tree Thierry Reding
  2026-04-27 13:26 ` linux-next: build failure after merge of the bfp-next tree Thierry Reding
@ 2026-04-27 13:34 ` Thierry Reding
  2026-04-27 13:43 ` Alan Maguire
  2 siblings, 0 replies; 5+ messages in thread
From: Thierry Reding @ 2026-04-27 13:34 UTC (permalink / raw)
  To: Daniel Borkmann, Alexei Starovoitov, Andrii Nakryiko
  Cc: linux-kernel, bpf, netdev, linux-next

[-- Attachment #1: Type: text/plain, Size: 1408 bytes --]

On Mon, Apr 27, 2026 at 03:26:01PM +0200, Thierry Reding wrote:
> Hi all,
> 
> After merging the bpf-next tree, today's linux-next build (x86_64_perf)
> failed like this:
> 
>       CC      builtin-trace.o
>     builtin-trace.c: In function ‘syscall_arg__strtoul_btf_enum’:
>     builtin-trace.c:972:27: error: comparison of integer expressions of different signedness: ‘int’ and ‘__u32’ {aka ‘unsigned int’} [-Werror=sign-compare]
>       972 |         for (int i = 0; i < btf_vlen(bt); ++i, ++be) {
>           |                           ^
>       CC      util/btf.o
>     util/btf.c: In function ‘__btf_type__find_member_by_name’:
>     util/btf.c:19:43: error: comparison of integer expressions of different signedness: ‘int’ and ‘__u32’ {aka ‘unsigned int’} [-Werror=sign-compare]
>        19 |         for (i = 0, m = btf_members(t); i < btf_vlen(t); i++, m++) {
>           |                                           ^
> 
> Caused by commit
> 
>     f7a6b9eaff3e ("bpf: Extend BTF UAPI vlen, kinds to use unused bits")
> 
> I've fixed it up like below, but please fix this in your tree as well.

Given that I later saw that the build broke due to the other change and
I had to use the old bpf-next tree, this fixup is no longer in the tree
but it should still be fixed so that bpf-next can be merged into linux-
next again soon.

Thierry

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: linux-next: build failure after merge of the bpf-next tree
  2026-04-27 13:26 linux-next: build failure after merge of the bpf-next tree Thierry Reding
  2026-04-27 13:26 ` linux-next: build failure after merge of the bfp-next tree Thierry Reding
  2026-04-27 13:34 ` linux-next: build failure after merge of the bpf-next tree Thierry Reding
@ 2026-04-27 13:43 ` Alan Maguire
  2 siblings, 0 replies; 5+ messages in thread
From: Alan Maguire @ 2026-04-27 13:43 UTC (permalink / raw)
  To: Thierry Reding, Daniel Borkmann, Alexei Starovoitov,
	Andrii Nakryiko
  Cc: linux-kernel, bpf, netdev, linux-next

On 27/04/2026 14:26, Thierry Reding wrote:
> Hi all,
> 
> After merging the bpf-next tree, today's linux-next build (x86_64_perf)
> failed like this:
> 
>       CC      builtin-trace.o
>     builtin-trace.c: In function ‘syscall_arg__strtoul_btf_enum’:
>     builtin-trace.c:972:27: error: comparison of integer expressions of different signedness: ‘int’ and ‘__u32’ {aka ‘unsigned int’} [-Werror=sign-compare]
>       972 |         for (int i = 0; i < btf_vlen(bt); ++i, ++be) {
>           |                           ^
>       CC      util/btf.o
>     util/btf.c: In function ‘__btf_type__find_member_by_name’:
>     util/btf.c:19:43: error: comparison of integer expressions of different signedness: ‘int’ and ‘__u32’ {aka ‘unsigned int’} [-Werror=sign-compare]
>        19 |         for (i = 0, m = btf_members(t); i < btf_vlen(t); i++, m++) {
>           |                                           ^
> 
> Caused by commit
> 
>     f7a6b9eaff3e ("bpf: Extend BTF UAPI vlen, kinds to use unused bits")
> 
> I've fixed it up like below, but please fix this in your tree as well.
> 
> Thanks,
> Thierry
> 
> --- >8 ---
> From 4689669414ed7de19a69803714bc04e96fd82618 Mon Sep 17 00:00:00 2001
> From: Thierry Reding <treding@nvidia.com>
> Date: Mon, 27 Apr 2026 12:32:06 +0200
> Subject: [PATCH] perf: Fixup for btf_vlan() API change
> 
> Signed-off-by: Thierry Reding <treding@nvidia.com>

Reviewed-by: Alan Maguire <alan.maguire@oracle.com>

Thanks for the fix!

> ---
>  tools/perf/builtin-trace.c | 2 +-
>  tools/perf/util/btf.c      | 2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/tools/perf/builtin-trace.c b/tools/perf/builtin-trace.c
> index e58c49d047a2..d22e20a57b70 100644
> --- a/tools/perf/builtin-trace.c
> +++ b/tools/perf/builtin-trace.c
> @@ -969,7 +969,7 @@ static bool syscall_arg__strtoul_btf_enum(char *bf, size_t size, struct syscall_
>  	struct btf *btf = arg->trace->btf;
>  	struct btf_enum *be = btf_enum(bt);
>  
> -	for (int i = 0; i < btf_vlen(bt); ++i, ++be) {
> +	for (u32 i = 0; i < btf_vlen(bt); ++i, ++be) {
>  		const char *name = btf__name_by_offset(btf, be->name_off);
>  		int max_len = max(size, strlen(name));
>  
> diff --git a/tools/perf/util/btf.c b/tools/perf/util/btf.c
> index bb163fe87767..50d98f3e83bf 100644
> --- a/tools/perf/util/btf.c
> +++ b/tools/perf/util/btf.c
> @@ -14,7 +14,7 @@ const struct btf_member *__btf_type__find_member_by_name(struct btf *btf,
>  {
>  	const struct btf_type *t = btf__type_by_id(btf, type_id);
>  	const struct btf_member *m;
> -	int i;
> +	u32 i;
>  
>  	for (i = 0, m = btf_members(t); i < btf_vlen(t); i++, m++) {
>  		const char *current_member_name = btf__name_by_offset(btf, m->name_off);


^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: linux-next: build failure after merge of the bfp-next tree
  2026-04-27 13:26 ` linux-next: build failure after merge of the bfp-next tree Thierry Reding
@ 2026-04-27 13:45   ` Alan Maguire
  0 siblings, 0 replies; 5+ messages in thread
From: Alan Maguire @ 2026-04-27 13:45 UTC (permalink / raw)
  To: Thierry Reding, Alexei Starovoitov, Andrii Nakryiko
  Cc: Eduard Zingerman, linux-kernel, bpf, netdev, linux-next

On 27/04/2026 14:26, Thierry Reding wrote:
> Hi all,
> 
> After merging the bfp-next tree, today's linux-next build (x86_64
> allmodconfig ) failed like this:
> 
>     ERROR: modpost: "cnum64_umin" [drivers/net/ethernet/netronome/nfp/nfp.ko] undefined!
>     ERROR: modpost: "cnum64_umax" [drivers/net/ethernet/netronome/nfp/nfp.ko] undefined!
> 
> Caused by commit
> 
>     b93f7180f0bc ("bpf: use accessor functions for bpf_reg_state min/max fields")
> 
> It looks like the issue here is that these new accessor functions are not
> exported symbols and therefore can't be used by a driver that is built as
> a module.
>

See [1] for a proposed fix; thanks for reporting this!

[1] https://lore.kernel.org/bpf/20260427112205.1346733-1-alan.maguire@oracle.com/
 
> I've used the previous tree for today's linux-next.
> 
> Thanks,
> Thierry
> 


^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2026-04-27 13:45 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-04-27 13:26 linux-next: build failure after merge of the bpf-next tree Thierry Reding
2026-04-27 13:26 ` linux-next: build failure after merge of the bfp-next tree Thierry Reding
2026-04-27 13:45   ` Alan Maguire
2026-04-27 13:34 ` linux-next: build failure after merge of the bpf-next tree Thierry Reding
2026-04-27 13:43 ` Alan Maguire

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox