public inbox for netdev@vger.kernel.org
 help / color / mirror / Atom feed
* [PATCH] net: fealnx: make driver work on architectures without I/O ports
@ 2026-04-28  2:11 Ethan Nelson-Moore
  0 siblings, 0 replies; only message in thread
From: Ethan Nelson-Moore @ 2026-04-28  2:11 UTC (permalink / raw)
  To: netdev
  Cc: Ethan Nelson-Moore, stable, Andrew Lunn, David S. Miller,
	Eric Dumazet, Jakub Kicinski, Paolo Abeni, Thomas Gleixner,
	Denis Benato, Ingo Molnar, Simon Horman

Devices supported by the fealnx driver support both MMIO and PIO access
(they have a PCI BAR for each). However, the driver always tries to use
the PIO BAR on architectures other than Alpha. This makes the driver
not work on architectures without I/O port mapping support. The comment
explaining why this was done explains that some x86 systems have issues
with MMIO. To enable the driver on all architectures while preventing
potential regressions, change the driver to only use PIO on x86.

Issue discovered by manual inspection.

Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2")
Cc: stable@vger.kernel.org
Signed-off-by: Ethan Nelson-Moore <enelsonmoore@gmail.com>
---
 drivers/net/ethernet/fealnx.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/ethernet/fealnx.c b/drivers/net/ethernet/fealnx.c
index 3c9961806f75..51dd09107242 100644
--- a/drivers/net/ethernet/fealnx.c
+++ b/drivers/net/ethernet/fealnx.c
@@ -91,7 +91,7 @@ static int full_duplex[MAX_UNITS] = { -1, -1, -1, -1, -1, -1, -1, -1 };
 
 /* This driver was written to use PCI memory space, however some x86 systems
    work only with I/O space accesses. */
-#ifndef __alpha__
+#ifdef CONFIG_X86
 #define USE_IO_OPS
 #endif
 
-- 
2.43.0


^ permalink raw reply related	[flat|nested] only message in thread

only message in thread, other threads:[~2026-04-28  2:12 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-04-28  2:11 [PATCH] net: fealnx: make driver work on architectures without I/O ports Ethan Nelson-Moore

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox