* Recommended local LLM-assisted review for netdev submissions?
@ 2026-04-28 15:17 Satish Kharat
2026-04-28 15:27 ` Jakub Kicinski
2026-04-28 16:40 ` Andrew Lunn
0 siblings, 2 replies; 3+ messages in thread
From: Satish Kharat @ 2026-04-28 15:17 UTC (permalink / raw)
To: Jakub Kicinski; +Cc: netdev, satishkh
Hi Jakub,
I'm the author of the in-flight enic SR-IOV series. Before posting
revisions I run checkpatch --strict, make W=1 C=1 on touched files,
scripts/kernel-doc -none, and `b4 prep --check`.
I've read Jesse's Netdev 0x18 talk on AI-enhanced reviews [1], the
LWN coverage [2][3], and looked at sashiko [4]. What I haven't been
able to tell from the public material:
- Is sashiko (or a successor) what's currently producing the
LLM-style review replies showing up on netdev, or is that a
different pipeline?
- For contributors who'd like to self-review with the same
prompt/ruleset before posting, is there a recommended setup,
or is sashiko-as-is the closest thing today?
Happy with a one-line pointer if it's already documented somewhere
I missed.
Thanks,
Satish
[1] https://netdevconf.info/0x18/sessions/talk/ai-enhanced-reviews-for-linux-networking.html
[2] https://lwn.net/Articles/987319/
[3] https://lwn.net/Articles/1032612/
[4] https://github.com/sashiko-dev/sashiko
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: Recommended local LLM-assisted review for netdev submissions?
2026-04-28 15:17 Recommended local LLM-assisted review for netdev submissions? Satish Kharat
@ 2026-04-28 15:27 ` Jakub Kicinski
2026-04-28 16:40 ` Andrew Lunn
1 sibling, 0 replies; 3+ messages in thread
From: Jakub Kicinski @ 2026-04-28 15:27 UTC (permalink / raw)
To: Satish Kharat; +Cc: netdev
On Tue, 28 Apr 2026 08:17:55 -0700 Satish Kharat wrote:
> I'm the author of the in-flight enic SR-IOV series. Before posting
> revisions I run checkpatch --strict, make W=1 C=1 on touched files,
> scripts/kernel-doc -none, and `b4 prep --check`.
>
> I've read Jesse's Netdev 0x18 talk on AI-enhanced reviews [1], the
> LWN coverage [2][3], and looked at sashiko [4]. What I haven't been
> able to tell from the public material:
>
> - Is sashiko (or a successor) what's currently producing the
> LLM-style review replies showing up on netdev, or is that a
> different pipeline?
> - For contributors who'd like to self-review with the same
> prompt/ruleset before posting, is there a recommended setup,
> or is sashiko-as-is the closest thing today?
Our current recommendation for "individual" contributors is to use
the review prompts directly:
https://netdev-ai.bots.linux.dev/ai-local.html
If you have / can get LLM API keys sashiko seems to be producing
better results (although not strictly better). Ideally you'd want
to run Sashiko on all three of the major LLM models and then another
sweep to coalesce the results. We can't do this at netdev today because
it's cost prohibitive. But Google's Sashiko runs on Gemini, ours runs
on Claude and they find different things..
I tried to improve Sashiko + CLI models but from my limited
experimentation it's worse than just using the review prompts.
> Happy with a one-line pointer if it's already documented somewhere
> I missed.
Sorry for not having the source of truth. The space is rapidly
evolving :(
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: Recommended local LLM-assisted review for netdev submissions?
2026-04-28 15:17 Recommended local LLM-assisted review for netdev submissions? Satish Kharat
2026-04-28 15:27 ` Jakub Kicinski
@ 2026-04-28 16:40 ` Andrew Lunn
1 sibling, 0 replies; 3+ messages in thread
From: Andrew Lunn @ 2026-04-28 16:40 UTC (permalink / raw)
To: Satish Kharat; +Cc: Jakub Kicinski, netdev
On Tue, Apr 28, 2026 at 08:17:55AM -0700, Satish Kharat wrote:
> Hi Jakub,
>
> I'm the author of the in-flight enic SR-IOV series. Before posting
> revisions I run checkpatch --strict, make W=1 C=1 on touched files,
> scripts/kernel-doc -none, and `b4 prep --check`.
AI reviews is the big news at the moment, but please don't forget the
more mundane testing which also gets run on patches and series. You
can run these locally:
https://github.com/linux-netdev/nipa#running-locally
Andrew
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2026-04-28 16:40 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-04-28 15:17 Recommended local LLM-assisted review for netdev submissions? Satish Kharat
2026-04-28 15:27 ` Jakub Kicinski
2026-04-28 16:40 ` Andrew Lunn
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox