* [PATCH net-next] net: mctp: test: remove skb dumps from test output
@ 2026-04-29 8:27 Jeremy Kerr
2026-04-30 17:18 ` Simon Horman
2026-04-30 20:50 ` patchwork-bot+netdevbpf
0 siblings, 2 replies; 3+ messages in thread
From: Jeremy Kerr @ 2026-04-29 8:27 UTC (permalink / raw)
To: Matt Johnston, David S. Miller, Eric Dumazet, Jakub Kicinski,
Paolo Abeni, Simon Horman
Cc: netdev
We're currently dumping skb info in our fragment input test, which makes
interpreting the TAP test output a bit awkward.
Remove the skb dumps.
Signed-off-by: Jeremy Kerr <jk@codeconstruct.com.au>
---
net/mctp/test/route-test.c | 6 ------
1 file changed, 6 deletions(-)
diff --git a/net/mctp/test/route-test.c b/net/mctp/test/route-test.c
index e1033643fab0..fbd6d4e08aef 100644
--- a/net/mctp/test/route-test.c
+++ b/net/mctp/test/route-test.c
@@ -859,12 +859,6 @@ static void mctp_test_route_input_cloned_frag(struct kunit *test)
skb[0]->data[4] = 0;
skb[3]->data[4] = 0;
- skb_dump("pkt1 ", skb[0], false);
- skb_dump("pkt2 ", skb[1], false);
- skb_dump("pkt3 ", skb[2], false);
- skb_dump("pkt4 ", skb[3], false);
- skb_dump("pkt5 ", skb[4], false);
-
for (int i = 0; i < 5; i++) {
KUNIT_EXPECT_EQ(test, refcount_read(&skb[i]->users), 1);
/* Take a reference so we can check refcounts at the end */
---
base-commit: dca922e019dd758b4c1b4bec8f1d509efddeaab4
change-id: 20260429-dev-mctp-test-skb-dump-cc5b95f8e2ad
Best regards,
--
Jeremy Kerr <jk@codeconstruct.com.au>
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH net-next] net: mctp: test: remove skb dumps from test output
2026-04-29 8:27 [PATCH net-next] net: mctp: test: remove skb dumps from test output Jeremy Kerr
@ 2026-04-30 17:18 ` Simon Horman
2026-04-30 20:50 ` patchwork-bot+netdevbpf
1 sibling, 0 replies; 3+ messages in thread
From: Simon Horman @ 2026-04-30 17:18 UTC (permalink / raw)
To: Jeremy Kerr
Cc: Matt Johnston, David S. Miller, Eric Dumazet, Jakub Kicinski,
Paolo Abeni, netdev
On Wed, Apr 29, 2026 at 04:27:31PM +0800, Jeremy Kerr wrote:
> We're currently dumping skb info in our fragment input test, which makes
> interpreting the TAP test output a bit awkward.
>
> Remove the skb dumps.
>
> Signed-off-by: Jeremy Kerr <jk@codeconstruct.com.au>
Reviewed-by: Simon Horman <horms@kernel.org>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH net-next] net: mctp: test: remove skb dumps from test output
2026-04-29 8:27 [PATCH net-next] net: mctp: test: remove skb dumps from test output Jeremy Kerr
2026-04-30 17:18 ` Simon Horman
@ 2026-04-30 20:50 ` patchwork-bot+netdevbpf
1 sibling, 0 replies; 3+ messages in thread
From: patchwork-bot+netdevbpf @ 2026-04-30 20:50 UTC (permalink / raw)
To: Jeremy Kerr; +Cc: matt, davem, edumazet, kuba, pabeni, horms, netdev
Hello:
This patch was applied to netdev/net-next.git (main)
by Jakub Kicinski <kuba@kernel.org>:
On Wed, 29 Apr 2026 16:27:31 +0800 you wrote:
> We're currently dumping skb info in our fragment input test, which makes
> interpreting the TAP test output a bit awkward.
>
> Remove the skb dumps.
>
> Signed-off-by: Jeremy Kerr <jk@codeconstruct.com.au>
>
> [...]
Here is the summary with links:
- [net-next] net: mctp: test: remove skb dumps from test output
https://git.kernel.org/netdev/net-next/c/8ca4bff2ff3e
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2026-04-30 20:50 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-04-29 8:27 [PATCH net-next] net: mctp: test: remove skb dumps from test output Jeremy Kerr
2026-04-30 17:18 ` Simon Horman
2026-04-30 20:50 ` patchwork-bot+netdevbpf
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox