* [PATCH net] net: xfrm: Fix dev refcnt leak in async resumption
@ 2026-05-09 7:44 Dong Chenchen
0 siblings, 0 replies; only message in thread
From: Dong Chenchen @ 2026-05-09 7:44 UTC (permalink / raw)
To: steffen.klassert, herbert, davem, edumazet, kuba, pabeni, horms,
tpluszz77
Cc: netdev, zhangchangzhong, Dong Chenchen
xfrm async resumption hold dev ref until after transport_finish.
When afinfo is NULL (e.g. x->props.family is invalid) and xfrm_gro
is not set, dev_put in transport_finish() and xfrm_gro path is skipped.
This will trigger refcnt leak.
Add dev_put in return path to fix it.
Fixes: 1c428b038400 ("xfrm: hold dev ref until after transport_finish NF_HOOK")
Signed-off-by: Dong Chenchen <dongchenchen2@huawei.com>
---
net/xfrm/xfrm_input.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/net/xfrm/xfrm_input.c b/net/xfrm/xfrm_input.c
index f65291eba1f6..c98a29d80a53 100644
--- a/net/xfrm/xfrm_input.c
+++ b/net/xfrm/xfrm_input.c
@@ -765,6 +765,8 @@ int xfrm_input(struct sk_buff *skb, int nexthdr, __be32 spi, int encap_type)
return err;
}
+ if (unlikely(!afinfo) && async)
+ dev_put(skb->dev);
return err;
}
--
2.25.1
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2026-05-09 7:34 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-05-09 7:44 [PATCH net] net: xfrm: Fix dev refcnt leak in async resumption Dong Chenchen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox