Re: [net-next v3 3/5] dt-bindings: net: starfive,jh7110-dwmac: Add jhb100 sgmii rx clk

[Conor Dooley <conor@kernel.org>]

[-- Attachment #1: Type: text/plain, Size: 1575 bytes --]

On Tue, May 12, 2026 at 11:11:20AM +0000, Minda Chen wrote:
> 
> 
> > 
> > > +
> > > +        clock-names:
> > > +          oneOf:
> > > +            - items:
> > > +                - const: stmmaceth
> > > +                - const: pclk
> > > +                - const: ptp_ref
> > > +                - const: tx
> > > +                - const: gtx
> > > +            - items:
> > > +                - const: stmmaceth
> > > +                - const: pclk
> > > +                - const: ptp_ref
> > > +                - const: tx
> > > +                - const: gtx
> > > +                - const: sgmii_rx
> > 
> > Can't you just leave this list outside the conditional section, and add the extra
> > item to the end? The only difference appears to be the sgmii_rx clock, and it's at
> > the end.
> > 
> > I'm also not really convinced that this flexibility is required, unless there are
> > some controllers on the platform that do not support sgmii.
> > 
> > pw-bot: changes-requested
> > 
> > Cheers,
> > Conor.
> > 
> 
> Thanks. Yes, can do it more simple . I think change the clocks-names in properties like this is Okay.
> 
>    clock-names:
> +    minItems: 5
>      items:
>        - const: stmmaceth
>        - const: pclk
>        - const: ptp_ref
>        - const: tx
>        - const: gtx
> +      - enum:
> +          - sgmii_rx

This can remain const, only need the enum if there are options.

> 
>  
> > >        if:
> > >          properties:
> > >            compatible:
> > > --
> > > 2.17.1
> > >

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]