[net-next:main 114/116] net/core/sock.c:2761:1: warning: control reaches end of non-void function

[net-next:main 114/116] net/core/sock.c:2761:1: warning: control reaches end of non-void function

[kernel test robot]

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git main
head:   f3f7760afe65292e83f182696130efb983278d04
commit: f0de88303d5e7e04a1224bc7a00512b5a1c4fe7a [114/116] net: make is_skb_wmem() available to modules
config: powerpc64-randconfig-002-20260514 (https://download.01.org/0day-ci/archive/20260515/202605150027.0UCMop1l-lkp@intel.com/config)
compiler: powerpc64-linux-gcc (GCC) 8.5.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20260515/202605150027.0UCMop1l-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202605150027.0UCMop1l-lkp@intel.com/

All warnings (new ones prefixed by >>):

   In file included from include/net/inet_sock.h:23,
                    from include/net/ip.h:29,
                    from include/linux/errqueue.h:6,
                    from net/core/sock.c:91:
   include/net/sock.h: In function 'is_skb_wmem':
   include/net/sock.h:1861:56: error: '__sock_wfree' undeclared (first use in this function); did you mean 'sock_wfree'?
            (IS_ENABLED(CONFIG_INET) && skb->destructor == __sock_wfree) ||
                                                           ^~~~~~~~~~~~
                                                           sock_wfree
   include/net/sock.h:1861:56: note: each undeclared identifier is reported only once for each function it appears in
   include/net/sock.h:1862:56: error: 'tcp_wfree' undeclared (first use in this function); did you mean 'sock_wfree'?
            (IS_ENABLED(CONFIG_INET) && skb->destructor == tcp_wfree);
                                                           ^~~~~~~~~
                                                           sock_wfree
   net/core/sock.c: In function 'can_skb_orphan_partial':
   net/core/sock.c:2760:50: error: 'tcp_wfree' undeclared (first use in this function); did you mean 'sock_wfree'?
      (IS_ENABLED(CONFIG_INET) && skb->destructor == tcp_wfree));
                                                     ^~~~~~~~~
                                                     sock_wfree
>> net/core/sock.c:2761:1: warning: control reaches end of non-void function [-Wreturn-type]
    }
    ^
--
   In file included from include/linux/tcp.h:19,
                    from net/core/skbuff.c:45:
   include/net/sock.h: In function 'is_skb_wmem':
   include/net/sock.h:1861:56: error: '__sock_wfree' undeclared (first use in this function); did you mean 'sock_wfree'?
            (IS_ENABLED(CONFIG_INET) && skb->destructor == __sock_wfree) ||
                                                           ^~~~~~~~~~~~
                                                           sock_wfree
   include/net/sock.h:1861:56: note: each undeclared identifier is reported only once for each function it appears in
   include/net/sock.h:1862:56: error: 'tcp_wfree' undeclared (first use in this function); did you mean 'sock_wfree'?
            (IS_ENABLED(CONFIG_INET) && skb->destructor == tcp_wfree);
                                                           ^~~~~~~~~
                                                           sock_wfree
>> include/net/sock.h:1863:1: warning: control reaches end of non-void function [-Wreturn-type]
    }
    ^


vim +2761 net/core/sock.c

9e17f8a475fca81 Eric Dumazet   2015-11-01  2750  
414776621d1006e Jakub Kicinski 2019-08-07  2751  static bool can_skb_orphan_partial(const struct sk_buff *skb)
414776621d1006e Jakub Kicinski 2019-08-07  2752  {
414776621d1006e Jakub Kicinski 2019-08-07  2753  	/* Drivers depend on in-order delivery for crypto offload,
414776621d1006e Jakub Kicinski 2019-08-07  2754  	 * partial orphan breaks out-of-order-OK logic.
414776621d1006e Jakub Kicinski 2019-08-07  2755  	 */
9f06f87fef689d2 Jakub Kicinski 2024-04-03  2756  	if (skb_is_decrypted(skb))
414776621d1006e Jakub Kicinski 2019-08-07  2757  		return false;
9f06f87fef689d2 Jakub Kicinski 2024-04-03  2758  
414776621d1006e Jakub Kicinski 2019-08-07  2759  	return (skb->destructor == sock_wfree ||
414776621d1006e Jakub Kicinski 2019-08-07 @2760  		(IS_ENABLED(CONFIG_INET) && skb->destructor == tcp_wfree));
414776621d1006e Jakub Kicinski 2019-08-07 @2761  }
414776621d1006e Jakub Kicinski 2019-08-07  2762  

:::::: The code at line 2761 was first introduced by commit
:::::: 414776621d1006e57e80e6db7fdc3837897aaa64 net/tls: prevent skb_orphan() from leaking TLS plain text with offload

:::::: TO: Jakub Kicinski <jakub.kicinski@netronome.com>
:::::: CC: David S. Miller <davem@davemloft.net>

--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki