From: Jakub Kicinski <kuba@kernel.org>
To: luka.gejak@linux.dev
Cc: netdev@vger.kernel.org, davem@davemloft.net, edumazet@google.com,
pabeni@redhat.com, fmaurer@redhat.com
Subject: Re: [PATCH net-next v6 1/2] net: hsr: require valid EOT supervision TLV
Date: Fri, 15 May 2026 17:33:54 -0700 [thread overview]
Message-ID: <20260515173354.70d9db10@kernel.org> (raw)
In-Reply-To: <20260513182657.20346-2-luka.gejak@linux.dev>
On Wed, 13 May 2026 20:26:56 +0200 luka.gejak@linux.dev wrote:
> @@ -100,7 +100,7 @@ static bool is_supervision_frame(struct hsr_priv *hsr, struct sk_buff *skb)
>
> /* make sure another tlv follows */
> total_length += sizeof(struct hsr_sup_tlv) + hsr_sup_tlv->HSR_TLV_length;
> - if (!pskb_may_pull(skb, total_length))
> + if (!pskb_may_pull(skb, total_length + sizeof(struct hsr_sup_tlv)))
> return false;
pskb_may_pull() changes should go to net?
Someone sending truncated frame may cause an OOB access and crash?
> @@ -110,7 +110,7 @@ static bool is_supervision_frame(struct hsr_priv *hsr, struct sk_buff *skb)
> }
>
> /* end of tlvs must follow at the end */
> - if (hsr_sup_tlv->HSR_TLV_type == HSR_TLV_EOT &&
> + if (hsr_sup_tlv->HSR_TLV_type != HSR_TLV_EOT ||
> hsr_sup_tlv->HSR_TLV_length != 0)
> return false;
And this chunk can go to net-next.
I'll apply patch 2 already, looks uncontroversial
next prev parent reply other threads:[~2026-05-16 0:33 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-13 18:26 [PATCH net-next v6 0/2] net: hsr: strict supervision TLV validation luka.gejak
2026-05-13 18:26 ` [PATCH net-next v6 1/2] net: hsr: require valid EOT supervision TLV luka.gejak
2026-05-14 12:55 ` Fernando Fernandez Mancera
2026-05-16 0:33 ` Jakub Kicinski [this message]
2026-05-13 18:26 ` [PATCH net-next v6 2/2] net: hsr: reject unresolved interlink ifindex luka.gejak
2026-05-14 12:55 ` Fernando Fernandez Mancera
2026-05-13 18:35 ` [PATCH net-next v6 0/2] net: hsr: strict supervision TLV validation Luka Gejak
2026-05-16 0:40 ` patchwork-bot+netdevbpf
-- strict thread matches above, loose matches on Subject: below --
2026-04-13 10:34 luka.gejak
2026-04-13 10:34 ` [PATCH net-next v6 1/2] net: hsr: require valid EOT supervision TLV luka.gejak
2026-04-13 10:57 ` Felix Maurer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260515173354.70d9db10@kernel.org \
--to=kuba@kernel.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=fmaurer@redhat.com \
--cc=luka.gejak@linux.dev \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox