From: Fernando Fernandez Mancera <fmancera@suse.de>
To: luka.gejak@linux.dev, netdev@vger.kernel.org
Cc: davem@davemloft.net, edumazet@google.com, kuba@kernel.org,
pabeni@redhat.com, fmaurer@redhat.com
Subject: Re: [PATCH net-next v6 2/2] net: hsr: reject unresolved interlink ifindex
Date: Thu, 14 May 2026 14:55:43 +0200 [thread overview]
Message-ID: <af0ed1c9-bbdf-453c-b9b9-f2e0d04cef2b@suse.de> (raw)
In-Reply-To: <20260513182657.20346-3-luka.gejak@linux.dev>
On 5/13/26 8:26 PM, luka.gejak@linux.dev wrote:
> From: Luka Gejak <luka.gejak@linux.dev>
>
> In hsr_newlink(), a provided but invalid IFLA_HSR_INTERLINK attribute
> was silently ignored if __dev_get_by_index() returned NULL. This leads
> to incorrect RedBox topology creation without notifying the user.
>
> Fix this by returning -EINVAL and an extack message when the
> interlink attribute is present but cannot be resolved.
>
> Assisted-by: Gemini:Gemini-3.1-flash
> Reviewed-by: Felix Maurer <fmaurer@redhat.com>
> Signed-off-by: Luka Gejak <luka.gejak@linux.dev>
Reviewed-by: Fernando Fernandez Mancera <fmancera@suse.de>
Thanks!
next prev parent reply other threads:[~2026-05-14 12:55 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-13 18:26 [PATCH net-next v6 0/2] net: hsr: strict supervision TLV validation luka.gejak
2026-05-13 18:26 ` [PATCH net-next v6 1/2] net: hsr: require valid EOT supervision TLV luka.gejak
2026-05-14 12:55 ` Fernando Fernandez Mancera
2026-05-13 18:26 ` [PATCH net-next v6 2/2] net: hsr: reject unresolved interlink ifindex luka.gejak
2026-05-14 12:55 ` Fernando Fernandez Mancera [this message]
2026-05-13 18:35 ` [PATCH net-next v6 0/2] net: hsr: strict supervision TLV validation Luka Gejak
-- strict thread matches above, loose matches on Subject: below --
2026-04-13 10:34 luka.gejak
2026-04-13 10:34 ` [PATCH net-next v6 2/2] net: hsr: reject unresolved interlink ifindex luka.gejak
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=af0ed1c9-bbdf-453c-b9b9-f2e0d04cef2b@suse.de \
--to=fmancera@suse.de \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=fmaurer@redhat.com \
--cc=kuba@kernel.org \
--cc=luka.gejak@linux.dev \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox