From: Jakub Kicinski <kuba@kernel.org>
To: Ashwin Gundarapu <linuxuser509@zohomail.in>
Cc: "anthonylnguyen" <anthony.l.nguyen@intel.com>,
"anthony.l.nguyen@intel.com" <przemyslaw.kitszel@intel.com>,
"andrewnetdev" <andrew+netdev@lunn.ch>,
"davem" <davem@davemloft.net>, "edumazet" <edumazet@google.com>,
"pabeni" <pabeni@redhat.com>,
"intel-wired-lan" <intel-wired-lan@lists.osuosl.org>,
"netdev" <netdev@vger.kernel.org>,
"linux-kernel" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH net-next] net: e100: remove redundant static variable initializations
Date: Fri, 22 May 2026 08:55:23 -0700 [thread overview]
Message-ID: <20260522085523.0432a2d5@kernel.org> (raw)
In-Reply-To: <19e4e74ff40.601fab765713.9212104302286035517@zohomail.in>
On Fri, 22 May 2026 12:22:30 +0530 Ashwin Gundarapu wrote:
> Remove '= 0' from static variables eeprom_bad_csum_allow and use_io.
> Static variables are zero-initialized by default.
>
> Found by checkpatch.pl
Quoting documentation:
Clean-up patches
~~~~~~~~~~~~~~~~
Netdev discourages patches which perform simple clean-ups, which are not in
the context of other work. For example:
* Addressing ``checkpatch.pl``, and other trivial coding style warnings
* Addressing :ref:`Local variable ordering<rcs>` issues
* Conversions to device-managed APIs (``devm_`` helpers)
This is because it is felt that the churn that such changes produce comes
at a greater cost than the value of such clean-ups.
See: https://www.kernel.org/doc/html/next/process/maintainer-netdev.html#clean-up-patches
prev parent reply other threads:[~2026-05-22 15:55 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-22 6:52 [PATCH net-next] net: e100: remove redundant static variable initializations Ashwin Gundarapu
2026-05-22 6:58 ` [Intel-wired-lan] " Loktionov, Aleksandr
2026-05-22 8:20 ` David Laight
2026-05-22 15:55 ` Jakub Kicinski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260522085523.0432a2d5@kernel.org \
--to=kuba@kernel.org \
--cc=andrew+netdev@lunn.ch \
--cc=anthony.l.nguyen@intel.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=intel-wired-lan@lists.osuosl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxuser509@zohomail.in \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=przemyslaw.kitszel@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox