Re: [PATCH 1/6] sock: add sock_kzalloc helper

Re: [PATCH 1/6] sock: add sock_kzalloc helper

[Thorsten Blum]

On Tue, May 26, 2026 at 05:14:12PM +0800, Herbert Xu wrote:
> On Fri, May 22, 2026 at 02:50:19PM +0200, Thorsten Blum wrote:
> > Hi Herbert,
> > 
> > On Mon, Apr 27, 2026 at 12:41:30PM +0200, Thorsten Blum wrote:
> > > Add sock_kzalloc() helper - the sock equivalent to kzalloc().
> > > 
> > > Signed-off-by: Thorsten Blum <thorsten.blum@linux.dev>
> > > ---
> > >  include/net/sock.h | 5 +++++
> > >  1 file changed, 5 insertions(+)
> > > 
> > > diff --git a/include/net/sock.h b/include/net/sock.h
> > > index dccd3738c368..20bf406dff2d 100644
> > > --- a/include/net/sock.h
> > > +++ b/include/net/sock.h
> > > @@ -1904,6 +1904,11 @@ void sock_kfree_s(struct sock *sk, void *mem, int size);
> > >  void sock_kzfree_s(struct sock *sk, void *mem, int size);
> > >  void sk_send_sigurg(struct sock *sk);
> > >  
> > > +static inline void *sock_kzalloc(struct sock *sk, int size, gfp_t priority)
> > > +{
> > > +	return sock_kmalloc(sk, size, priority | __GFP_ZERO);
> > > +}
> > > +
> > >  static inline void sock_replace_proto(struct sock *sk, struct proto *proto)
> > >  {
> > >  	if (sk->sk_socket)
> > 
> > Can you take this series or should I resend this to net-next?
> 
> This patch needs an ack from the netdev maintainers.

Jakub, netdev folks,

Could you take a look at this small include/net/sock.h addition and
provide an Acked-by: tag if you're okay with it going through Herbert's
crypto tree?

The series has Reviewed-by: tags from Kuniyuki, but it hadn't been Cc'ed
to netdev before.

Thanks,
Thorsten

Re: [PATCH 1/6] sock: add sock_kzalloc helper

[Jakub Kicinski]

On Tue, 26 May 2026 15:23:25 +0200 Thorsten Blum wrote:
> Could you take a look at this small include/net/sock.h addition and
> provide an Acked-by: tag if you're okay with it going through Herbert's
> crypto tree?
> 
> The series has Reviewed-by: tags from Kuniyuki, but it hadn't been Cc'ed
> to netdev before.

IDK, feels like the usage is low enough to border on pointless churn.
Other netdev maintainers may feel differently.