Netdev List
 help / color / mirror / Atom feed
* nipa: tree selection fails for ipsec-next series?
@ 2026-05-27  9:05 Antony Antony
  2026-05-27 22:36 ` Jakub Kicinski
  0 siblings, 1 reply; 2+ messages in thread
From: Antony Antony @ 2026-05-27  9:05 UTC (permalink / raw)
  To: kuba; +Cc: steffen.klassert, netdev

Hi Jakub,

nipa run, 1101209,  failed tree selection for my v9 series and I wanted to 
share what I found while diagnosing it. I feel this happens on patches, ipsec-next,  
too.  In the past, I ignored it. Since this patch set is  long series I 
looked deeper.

https://patchwork.kernel.org/project/netdevbpf/patch/migrate-state-v9-16-ad9947e4ae74@secunet.com/
"Guessing tree name failed - patch did not apply"

Looking at the nipa source, series_tree_name_direct() matches the cover
letter subject against _trees.keys(). Since ipsec and ipsec-next are not
in the deployed conf_trees, the match fails and nipa falls back to
guessing against net-next. I am guessing ipsec-next is missing in the config too.
Where is the config nipa runs use? I didn't find the exact config nipa bot 
used.

I also noticed that my v8 (series 1089594) was identified as
net-next — it applied to net-next at the time, which masked the issue.
v9 no longer applies to net-next, so the guessing failed visibly this
time. 

https://patchwork.kernel.org/project/netdevbpf/patch/migrate-state-v8-14-4578fb016965@secunet.com/

Any idea what could be improved? Is it because the e-mails arrive out or 
order?

Would it make sense to add ipsec and ipsec-next to nipa's [trees] config?
That way series_tree_name_direct() could match them directly from the
cover letter subject rather than falling through to guessing.

Thanks,
Antony

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: nipa: tree selection fails for ipsec-next series?
  2026-05-27  9:05 nipa: tree selection fails for ipsec-next series? Antony Antony
@ 2026-05-27 22:36 ` Jakub Kicinski
  0 siblings, 0 replies; 2+ messages in thread
From: Jakub Kicinski @ 2026-05-27 22:36 UTC (permalink / raw)
  To: Antony Antony; +Cc: steffen.klassert, netdev

On Wed, 27 May 2026 11:05:43 +0200 Antony Antony wrote:
> Looking at the nipa source, series_tree_name_direct() matches the cover
> letter subject against _trees.keys(). Since ipsec and ipsec-next are not
> in the deployed conf_trees, the match fails and nipa falls back to
> guessing against net-next. I am guessing ipsec-next is missing in the config too.
> Where is the config nipa runs use? I didn't find the exact config nipa bot 
> used.

The netdev@ NIPA is for the netdev+bpf patchwork instance, and 
the related trees. Should be easy for y'all to spin up an instance 
for ipsec.. ?

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2026-05-27 22:36 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-05-27  9:05 nipa: tree selection fails for ipsec-next series? Antony Antony
2026-05-27 22:36 ` Jakub Kicinski

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox