Netdev List
 help / color / mirror / Atom feed
From: Petr Wozniak <petr.wozniak@gmail.com>
To: sd@queasysnail.net
Cc: Petr Wozniak <petr.wozniak@gmail.com>,
	netdev@vger.kernel.org, steffen.klassert@secunet.com,
	herbert@gondor.apana.org.au, davem@davemloft.net
Subject: Re: [PATCH net-next] xfrm: fix xfrm_dev_offload_ok() returning true for software SAs
Date: Thu, 28 May 2026 04:46:04 +0200	[thread overview]
Message-ID: <20260528024604.1399-1-petr.wozniak@gmail.com> (raw)

2026-05-28, Sabrina Dubroca wrote:
> But the packet is delivered correctly also in the bridge case, right?
> Once we enter async crypto, the original datapath becomes irrelevant.

Yes — async completion via xfrm_output_resume() -> dst_output() delivers it
correctly regardless of the bridge TX path. The -ENOMEM is just a misleading
return code to the caller, not an actual drop.

Your ERR_PTR(-EINPROGRESS) approach makes sense. I'll work on a v2 based on
that — propagate through validate_xmit_xfrm() and fix up the callers.

Thanks for the pointer to f53c723902d1, that explains the context well.

Petr

             reply	other threads:[~2026-05-28  2:46 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-05-28  2:46 Petr Wozniak [this message]
     [not found] <20260527140948.78243-1-petr.wozniak@gmail.com>
2026-05-27 16:47 ` [PATCH net-next] xfrm: fix xfrm_dev_offload_ok() returning true for software SAs Petr Wozniak
2026-05-27 18:41   ` Sabrina Dubroca
  -- strict thread matches above, loose matches on Subject: below --
2026-05-27 14:09 Petr Wozniak
2026-05-27 16:01 ` Sabrina Dubroca

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260528024604.1399-1-petr.wozniak@gmail.com \
    --to=petr.wozniak@gmail.com \
    --cc=davem@davemloft.net \
    --cc=herbert@gondor.apana.org.au \
    --cc=netdev@vger.kernel.org \
    --cc=sd@queasysnail.net \
    --cc=steffen.klassert@secunet.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox