From: Sabrina Dubroca <sd@queasysnail.net>
To: Petr Wozniak <petr.wozniak@gmail.com>
Cc: netdev@vger.kernel.org, steffen.klassert@secunet.com,
herbert@gondor.apana.org.au, davem@davemloft.net
Subject: Re: [PATCH net-next] xfrm: fix xfrm_dev_offload_ok() returning true for software SAs
Date: Wed, 27 May 2026 18:01:49 +0200 [thread overview]
Message-ID: <ahcVbeG79PibbM3M@krikkit> (raw)
In-Reply-To: <20260527140948.21162-1-petr.wozniak@gmail.com>
2026-05-27, 16:09:48 +0200, Petr Wozniak wrote:
> xfrm_dev_offload_ok() reaches the ok: label when the SA has no
> offload device (dev == NULL, SW SA) because the guard condition
> "(!dev || dev == xfrm_dst_path(dst)->dev)" evaluates true for
> dev == NULL. The explicit "if (!dev) return true" at ok: then
> incorrectly routes the SW SA onto the GSO offload path.
Incorrectly? IPsec in SW with GSO is a valid setup. I think you're
breaking that with your patch.
--
Sabrina
next prev parent reply other threads:[~2026-05-27 16:01 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-27 14:09 [PATCH net-next] xfrm: fix xfrm_dev_offload_ok() returning true for software SAs Petr Wozniak
2026-05-27 16:01 ` Sabrina Dubroca [this message]
[not found] <20260527140948.78243-1-petr.wozniak@gmail.com>
2026-05-27 16:47 ` Petr Wozniak
2026-05-27 18:41 ` Sabrina Dubroca
-- strict thread matches above, loose matches on Subject: below --
2026-05-28 2:46 Petr Wozniak
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ahcVbeG79PibbM3M@krikkit \
--to=sd@queasysnail.net \
--cc=davem@davemloft.net \
--cc=herbert@gondor.apana.org.au \
--cc=netdev@vger.kernel.org \
--cc=petr.wozniak@gmail.com \
--cc=steffen.klassert@secunet.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox