Re: [PATCH net-next v5 8/8] selftests: hsr: Add test for the inline PTP header on HSR

[Sebastian Andrzej Siewior <bigeasy@linutronix.de>]

On 2026-05-27 12:12:27 [-0700], Jakub Kicinski wrote:
> On Wed, 27 May 2026 17:08:58 +0200 Sebastian Andrzej Siewior wrote:
> > Requested-by: Felix Maurer <fmaurer@redhat.com>
> 
> Please don't invent tags? If you want to say that Felix asked for this
> just say it in English.

okay.

> > --- a/tools/testing/selftests/net/hsr/Makefile
> > +++ b/tools/testing/selftests/net/hsr/Makefile
> > @@ -7,8 +7,11 @@ TEST_PROGS := \
> >  	hsr_redbox.sh \
> >  	link_faults.sh \
> >  	prp_ping.sh \
> > +	hsr_ptp.sh \
> >  # end of TEST_PROGS
> >  
> >  TEST_FILES += hsr_common.sh
> >  
> > +TEST_GEN_PROGS := hsr_ptp_test
> 
> TEST_GET_FILES otherwise kselftest thinks its a test and tries to run
> it (which of course fails on
> 
> +	if (!slaveA || !slaveB || !hsr_dev) {
> +		fprintf(stderr, "Missing network devices\n");
> +		exit(EXIT_FAILURE);
> +	}
> 
> given there are no arguments passed in)

Oh. I did replace it with TEST_GEN_FILES.

Sebastian