Netdev List
 help / color / mirror / Atom feed
From: Simon Horman <horms@kernel.org>
To: Javen <javen_xu@realsil.com.cn>
Cc: "hkallweit1@gmail.com" <hkallweit1@gmail.com>,
	"nic_swsd@realtek.com" <nic_swsd@realtek.com>,
	"andrew+netdev@lunn.ch" <andrew+netdev@lunn.ch>,
	"davem@davemloft.net" <davem@davemloft.net>,
	"edumazet@google.com" <edumazet@google.com>,
	"kuba@kernel.org" <kuba@kernel.org>,
	"pabeni@redhat.com" <pabeni@redhat.com>,
	"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [Patch net-next v5 0/7] r8169: add RSS support for RTL8127
Date: Thu, 28 May 2026 11:36:06 +0100	[thread overview]
Message-ID: <20260528103606.GS2256768@horms.kernel.org> (raw)
In-Reply-To: <c8edeb5447444dc49e3ee7bf18166399@realsil.com.cn>

On Mon, May 25, 2026 at 07:15:23AM +0000, Javen wrote:
> >On Wed, May 20, 2026 at 11:15:56AM +0800, javen wrote:
> >> From: Javen Xu <javen_xu@realsil.com.cn>
> >>
> >> This patch series adds RSS (Receive Side Scaling) support for the
> >> r8169 ethernet driver, specifically for RTL8127 (RTL_GIGA_MAC_VER_80).
> >>
> >> RSS enables packet distribution across multiple receive queues, which
> >> can significantly improve network throughput on multi-core systems by
> >> allowing parallel processing of incoming packets.
> >
> >...
> >
> >Hi Javen,
> >
> >There are AI generated reviews of this patchset available on bogh
> >https://netdev-ai.bots.linux.dev/sashiko/ and https://sashiko.dev
> >
> >I would appreciate it if you could look over them and address any issues that
> >effect the functionality of your patchset. I do not suggest expanding the scope
> >of this patchset, but rather treating other issues in the context of possible
> >follow-up.
> 
> Hi,
> 
> r8169_main.c used request_irq() before, but I was suggested to use pci_request_irq() to generate the name for each irq dynamically. And I find that in pci_request_irq(), irqflags is fixed to IRQF_SHARED. So I want to know how can I handle with this situation?

I am unsure. But if that is the advice you received then I would suggest
sticking with it.

      reply	other threads:[~2026-05-28 10:36 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-05-20  3:15 [Patch net-next v5 0/7] r8169: add RSS support for RTL8127 javen
2026-05-20  3:15 ` [Patch net-next v5 1/7] r8169: add support for multi irqs javen
2026-05-20  3:15 ` [Patch net-next v5 2/7] r8169: add support for multi rx queues javen
2026-05-20  3:15 ` [Patch net-next v5 3/7] r8169: add support for new interrupt mapping javen
2026-05-20  3:16 ` [Patch net-next v5 4/7] r8169: enable " javen
2026-05-20  3:16 ` [Patch net-next v5 5/7] r8169: add support and enable rss javen
2026-05-20  3:16 ` [Patch net-next v5 6/7] r8169: move struct ethtool_ops javen
2026-05-20  3:16 ` [Patch net-next v5 7/7] r8169: add support for ethtool javen
2026-05-22  9:20 ` [Patch net-next v5 0/7] r8169: add RSS support for RTL8127 Simon Horman
2026-05-25  7:15   ` Javen
2026-05-28 10:36     ` Simon Horman [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260528103606.GS2256768@horms.kernel.org \
    --to=horms@kernel.org \
    --cc=andrew+netdev@lunn.ch \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=hkallweit1@gmail.com \
    --cc=javen_xu@realsil.com.cn \
    --cc=kuba@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=nic_swsd@realtek.com \
    --cc=pabeni@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox