From: David Laight <david.laight.linux@gmail.com>
To: "Toke Høiland-Jørgensen" <toke@redhat.com>
Cc: Jamal Hadi Salim <jhs@mojatatu.com>,
netdev@vger.kernel.org, davem@davemloft.net, edumazet@google.com,
kuba@kernel.org, pabeni@redhat.com, horms@kernel.org,
jiri@resnulli.us, victor@mojatatu.com, yimingqian591@gmail.com,
keenanat2000@gmail.com, 2045gemini@gmail.com,
rollkingzzc@gmail.com, dcaratti@redhat.com, security@kernel.org,
linux-kernel@vger.kernel.org,
Rajat Gupta <rajat.gupta@oss.qualcomm.com>
Subject: Re: [PATCH net v3 1/1] net/sched: fix pedit partial COW leading to page cache corruption
Date: Thu, 28 May 2026 12:31:43 +0100 [thread overview]
Message-ID: <20260528123143.1a696fee@pumpkin> (raw)
In-Reply-To: <87ldd33l7r.fsf@toke.dk>
On Thu, 28 May 2026 12:03:04 +0200
Toke Høiland-Jørgensen <toke@redhat.com> wrote:
...
> > 2) Add more optimal boundary checks (Toke & David L.)
>
> [..]
>
> > - if (offset < 0 && -offset > skb_headroom(skb))
> > + if (offset < 0 && offset < -(int)skb_headroom(skb))
>
...
>
> However, I don't think this matters, this version is not actually buggy;
> so let's just get this merged, and we can code-golf the offset check on
> top :)
I prefer it in pink :-)
prev parent reply other threads:[~2026-05-28 11:31 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-27 18:17 [PATCH net v3 1/1] net/sched: fix pedit partial COW leading to page cache corruption Jamal Hadi Salim
2026-05-28 7:28 ` Han Guidong
2026-05-28 10:03 ` Toke Høiland-Jørgensen
2026-05-28 10:26 ` Jamal Hadi Salim
2026-05-28 17:53 ` Jamal Hadi Salim
2026-05-28 19:31 ` David Laight
2026-05-28 11:31 ` David Laight [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260528123143.1a696fee@pumpkin \
--to=david.laight.linux@gmail.com \
--cc=2045gemini@gmail.com \
--cc=davem@davemloft.net \
--cc=dcaratti@redhat.com \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=jhs@mojatatu.com \
--cc=jiri@resnulli.us \
--cc=keenanat2000@gmail.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=rajat.gupta@oss.qualcomm.com \
--cc=rollkingzzc@gmail.com \
--cc=security@kernel.org \
--cc=toke@redhat.com \
--cc=victor@mojatatu.com \
--cc=yimingqian591@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox