[PATCH net-next v2] doc/netlink: rt-link: fix binary attributes marked as strings

[PATCH net-next v2] doc/netlink: rt-link: fix binary attributes marked as strings

[Remy D. Farley]

These link-attrs attributes were previously marked as strings:

- wireless - struct iw_event
- protinfo - a nest of ifla6-attrs or linkinfo-brport-attrs
- cost, priority - unused

Signed-off-by: Remy D. Farley <one-d-wide@protonmail.com>
---
v2: Added SoB

 Documentation/netlink/specs/rt-link.yaml | 10 ++++++----
 1 file changed, 6 insertions(+), 4 deletions(-)

diff --git a/Documentation/netlink/specs/rt-link.yaml b/Documentation/netlink/specs/rt-link.yaml
index 79c89f204..6b8d5af41 100644
--- a/Documentation/netlink/specs/rt-link.yaml
+++ b/Documentation/netlink/specs/rt-link.yaml
@@ -880,19 +880,21 @@ attribute-sets:
         struct: rtnl-link-stats
       -
         name: cost
-        type: string
+        type: binary
       -
         name: priority
-        type: string
+        type: binary
       -
         name: master
         type: u32
       -
         name: wireless
-        type: string
+        type: binary
+        doc: struct iw_event
       -
         name: protinfo
-        type: string
+        type: binary
+        doc: A nest of ifla6-attrs or linkinfo-brport-attrs
       -
         name: txqlen
         type: u32
-- 
2.51.2

Re: [PATCH net-next v2] doc/netlink: rt-link: fix binary attributes marked as strings

[Jakub Kicinski]

On Tue, 26 May 2026 23:04:56 +0000 Remy D. Farley wrote:
> These link-attrs attributes were previously marked as strings:
> 
> - wireless - struct iw_event
> - protinfo - a nest of ifla6-attrs or linkinfo-brport-attrs
> - cost, priority - unused

>        -
>          name: cost
> -        type: string
> +        type: binary

	type: unused

is a thing, should we use it instead of binary?
IIRC it's expected to never exist in messages but to still output 
an entry into uAPI, which I think matches the situation here.

Sorry, should have looked closer at v1.

Re: [PATCH net-next v2] doc/netlink: rt-link: fix binary attributes marked as strings

[Remy D. Farley]

On Friday, May 29th, 2026 at 00:34, Jakub Kicinski <kuba@kernel.org> wrote:
> On Tue, 26 May 2026 23:04:56 +0000 Remy D. Farley wrote:
> > These link-attrs attributes were previously marked as strings:
> >
> > - wireless - struct iw_event
> > - protinfo - a nest of ifla6-attrs or linkinfo-brport-attrs
> > - cost, priority - unused
> 
> >        -
> >          name: cost
> > -        type: string
> > +        type: binary
> 
> 	type: unused
> 
> is a thing, should we use it instead of binary?


Yeah, this looks more useful. The neighboring rt-route seems to prefer
"type: binary", but I guess that's just an omission.

|       -
|         name: mp-algo  # not used
|         type: binary


> IIRC it's expected to never exist in messages but to still output
> an entry into uAPI, which I think matches the situation here.


If_link uapi header isn't generated, so no changes there.


> 
> Sorry, should have looked closer at v1.