Netdev List
 help / color / mirror / Atom feed
From: Simon Horman <horms@kernel.org>
To: Jijie Shao <shaojijie@huawei.com>
Cc: Paolo Abeni <pabeni@redhat.com>,
	davem@davemloft.net, edumazet@google.com, kuba@kernel.org,
	andrew+netdev@lunn.ch, shenjian15@huawei.com,
	liuyonglong@huawei.com, chenhao418@huawei.com,
	huangdonghua3@h-partners.com, yangshuaisong@h-partners.com,
	netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH V2 net-next 0/6] net: hns3: enhance tc flow offload support
Date: Fri, 29 May 2026 10:34:48 +0100	[thread overview]
Message-ID: <20260529093448.GV2256768@horms.kernel.org> (raw)
In-Reply-To: <83f34836-c848-469a-9c1c-7f28bf3035fc@huawei.com>

On Thu, May 28, 2026 at 07:24:28PM +0800, Jijie Shao wrote:
> 
> on 2026/5/28 17:06, Paolo Abeni wrote:
> > On 5/27/26 3:12 PM, Jijie Shao wrote:
> > > on 2026/5/27 17:59, Simon Horman wrote:
> > > > On Sat, May 23, 2026 at 06:54:43PM +0800, Jijie Shao wrote:

...

> > > > Hi Juijie,
> > > > 
> > > > There are AI-generated reviews of this patch-set available at
> > > > https://netdev-ai.bots.linux.dev/ and https://sashiko.dev/
> > > Hi,
> > > 
> > > I'm sorry, I don't understand how to use https://netdev-ai.bots.linux.dev/, it seems to require an API Token?
> > > I find it difficult to locate my own patch-set in Recent Reviews.
> > The nipa sashiko instance has the same web UI as sashiko.dev. The full
> > URL for the former is:
> > 
> > https://netdev-ai.bots.linux.dev/sashiko/
> > 
> > You can lookup your series by the cover letter title or you can use the
> > direct link including the msg id for the cover:
> > 
> > https://netdev-ai.bots.linux.dev/sashiko/#/patchset/20260523105449.661848-1-shaojijie%40huawei.com
> 
> Thanks,
> 
> It appears that the two URLs mentioned by Simon Horman are the results of the one AI-generated reviews.

Hi,

Firstly sorry for truncating the netdev-ai URL, that was not my intention.
Secondly, let me explain the relationship between the AI-generated review
on netdev-ai and sashiko.dev.

Both use the same underlying review engine - Sashiko [1].  But they are
using different AI models to run the review.  And I believe that the
prompts also differ a little.  Overall, netdev-ai, has been tuned for the
Netdev review process.  While sashiko.dev is more general.

My observation is that netdev-ai tends to flag things relevant to the
Netdev development process that may be skipped by sashiko.dev. While
sashiko.dev has a tendency to report pre-existing issues that are not
strictly related to the topic of the patch under review.

But, as the underling engine is the same there is also a lot of overlap in
the output produced by these two instances. And in some cases both
instances flag all of the same issues.

[1] https://github.com/sashiko-dev/sashiko

  reply	other threads:[~2026-05-29  9:34 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-05-23 10:54 [PATCH V2 net-next 0/6] net: hns3: enhance tc flow offload support Jijie Shao
2026-05-23 10:54 ` [PATCH V2 net-next 1/6] net: hns3: adjust add_cls_flower() for support more action Jijie Shao
2026-05-23 10:54 ` [PATCH V2 net-next 2/6] net: hns3: improve the unused_tuple parameter setting Jijie Shao
2026-05-23 10:54 ` [PATCH V2 net-next 3/6] net: hns3: support two more actions for tc flow Jijie Shao
2026-05-23 10:54 ` [PATCH V2 net-next 4/6] net: hns3: support IP and tunnel VNI dissectors " Jijie Shao
2026-05-23 10:54 ` [PATCH V2 net-next 5/6] net: hns3: debugfs support for dumping fd rules Jijie Shao
2026-05-23 10:54 ` [PATCH V2 net-next 6/6] net: hns3: move fd code to a separate file Jijie Shao
2026-05-27  9:59 ` [PATCH V2 net-next 0/6] net: hns3: enhance tc flow offload support Simon Horman
2026-05-27 13:12   ` Jijie Shao
2026-05-28  9:06     ` Paolo Abeni
2026-05-28 11:24       ` Jijie Shao
2026-05-29  9:34         ` Simon Horman [this message]
2026-05-29 10:53         ` Paolo Abeni

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260529093448.GV2256768@horms.kernel.org \
    --to=horms@kernel.org \
    --cc=andrew+netdev@lunn.ch \
    --cc=chenhao418@huawei.com \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=huangdonghua3@h-partners.com \
    --cc=kuba@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=liuyonglong@huawei.com \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=shaojijie@huawei.com \
    --cc=shenjian15@huawei.com \
    --cc=yangshuaisong@h-partners.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox