From: Jakub Kicinski <kuba@kernel.org>
To: Oscar Maes <oscmaes92@gmail.com>
Cc: netdev@vger.kernel.org, edumazet@google.com, pabeni@redhat.com,
andrew@lunn.ch
Subject: Re: [PATCH net] pcnet32: stop holding device spin lock during napi_complete_done
Date: Tue, 2 Jun 2026 11:34:34 -0700 [thread overview]
Message-ID: <20260602113434.5898517e@kernel.org> (raw)
In-Reply-To: <20260602164158-oscmaes92@gmail.com>
On Tue, 2 Jun 2026 18:41:58 +0200 Oscar Maes wrote:
> The suggested race condition is impossible, even after
> calling napi_complete_done all pcnet32 interrupts are masked via CSR3.
> pcnet32_interrupt would never be called until the second locked
> section in pcnet32_poll, which unmasks the interrupts.
Not very clear to me that pcnet32_interrupt() will not trigger until we
unmask, but okay, not worth the effort..
next prev parent reply other threads:[~2026-06-02 18:34 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-28 14:03 [PATCH net] pcnet32: stop holding device spin lock during napi_complete_done Oscar Maes
2026-05-28 14:55 ` Alexander Lobakin
2026-05-28 17:07 ` Oscar Maes
2026-05-29 15:21 ` Alexander Lobakin
2026-06-02 2:44 ` Jakub Kicinski
2026-06-02 16:41 ` Oscar Maes
2026-06-02 18:34 ` Jakub Kicinski [this message]
2026-06-02 18:40 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260602113434.5898517e@kernel.org \
--to=kuba@kernel.org \
--cc=andrew@lunn.ch \
--cc=edumazet@google.com \
--cc=netdev@vger.kernel.org \
--cc=oscmaes92@gmail.com \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox