Re: [PATCH net v3 2/2] dt-bindings: net: updated interrupt type to be active low, level triggered

[Conor Dooley <conor@kernel.org>]

[-- Attachment #1: Type: text/plain, Size: 2385 bytes --]

On Tue, Jun 02, 2026 at 05:36:16PM +0000, Selvamani Rajagopal wrote:
> 
> 
> > -----Original Message-----
> > Subject: Re: [PATCH net v3 2/2] dt-bindings: net: updated interrupt type to be active low,
> > level triggered
> > 
> > > According to OPEN Alliance 10BASE-T1x MACPHY Serial Interface (TC6)
> > > specification, interrupt type is active low, level triggered interrupt.
> > 
> > Have you checked the documentation for this device etc to make sure that
> > the device actually follows the spec?
> > Maybe Parthiban can confirm this for us?
> 
> Though I coordinated with Parthiban well ahead about this change, He is the one who could confirm. 

Please.

Dependant on an ack from Parthiban,
Acked-by: Conor Dooley <conor.dooley@microchip.com>

> 
> To answer your question, I looked at the datasheet. In one occasion, it mentions "once RESET_N is deasserted, device asserts IRQ_N.
> When software clears RESETC bit of OA_STATUS0, device deasserts IRQ_N. This gives me an indication that the interrupt is level triggered.
> 
> From our side, I checked with our engineer, who is part of the team that put together the specification, Pier, copied in this email, confirmed that it is level triggered.
> 
> > 
> > Cheers,
> > Conor.
> > 
> > >
> > > Fixes: ac49b950bea9 ("dt-bindings: net: add Microchip's LAN865X 10BASE-T1S
> > MACPHY")
> > > Signed-off-by: Selvamani Rajagopal <Selvamani.Rajagopal@onsemi.com>
> > > ---
> > >  Documentation/devicetree/bindings/net/microchip,lan8650.yaml | 2 +-
> > >  1 file changed, 1 insertion(+), 1 deletion(-)
> > >
> > > diff --git a/Documentation/devicetree/bindings/net/microchip,lan8650.yaml
> > b/Documentation/devicetree/bindings/net/microchip,lan8650.yaml
> > > index 61e11d4a07c4..766ff58147ae 100644
> > > --- a/Documentation/devicetree/bindings/net/microchip,lan8650.yaml
> > > +++ b/Documentation/devicetree/bindings/net/microchip,lan8650.yaml
> > > @@ -67,7 +67,7 @@ examples:
> > >          pinctrl-names = "default";
> > >          pinctrl-0 = <&eth0_pins>;
> > >          interrupt-parent = <&gpio>;
> > > -        interrupts = <6 IRQ_TYPE_EDGE_FALLING>;
> > > +        interrupts = <6 IRQ_TYPE_LEVEL_LOW>;
> > >          local-mac-address = [04 05 06 01 02 03];
> > >          spi-max-frequency = <15000000>;
> > >        };
> > >
> > > --
> > > 2.43.0
> > >
> > >
> 

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]