* [PATCH ethtool] netlink: fec: Add missing newlines in FEC statistics output
@ 2026-06-05 0:12 Eric Joyner
0 siblings, 0 replies; only message in thread
From: Eric Joyner @ 2026-06-05 0:12 UTC (permalink / raw)
To: netdev
Cc: Brett Creeley, Jakub Kicinski, Michal Kubecek, Eric Joyner,
Jacob Keller, Nikhil Rao
The non-histogram stats don't have newlines printed after them if they
don't have per-lane counts, and so they (and the first histogram bin, if
applicable) were displayed on the same line with the rest of the stats
being displayed with one stat per line, which looked inconsistent and
doesn't match the display in previous versions of ethtool.
Fix this by printing a final newline in the case where there are no
per-lane counts so that each stat gets printed with a newline at the
end.
Fixes: 3426a920183f ("netlink: fec: add errors histogram statistics")
Signed-off-by: Eric Joyner <eric.joyner@amd.com>
---
netlink/fec.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/netlink/fec.c b/netlink/fec.c
index 36ad3f504a83..c014749ac950 100644
--- a/netlink/fec.c
+++ b/netlink/fec.c
@@ -166,6 +166,8 @@ static int fec_show_stats(const struct nlattr *nest)
if (lanes) {
close_json_array("");
printf(" ]\n");
+ } else {
+ printf("\n");
}
close_json_object();
base-commit: 75fd12445ffd6d697d53b7d296e345d524a9bedd
--
2.17.1
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2026-06-05 0:12 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-06-05 0:12 [PATCH ethtool] netlink: fec: Add missing newlines in FEC statistics output Eric Joyner
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox