[PATCH net-next] drivers/net/ethernet/freescale/gianfar: Use bounded string ops when setting ethtool stat strings

[PATCH net-next] drivers/net/ethernet/freescale/gianfar: Use bounded string ops when setting ethtool stat strings

[david.laight.linux]

From: David Laight <david.laight.linux@gmail.com>

Replace sprintf() with snprintf() and strcpy() with strscpy().
Length is ETH_GSTRING_LEN.

Signed-off-by: David Laight <david.laight.linux@gmail.com>
---
This is one of a group of patches that remove potentially unbounded
strcpy() calls.

They are mostly replaced by strscpy() or, when strlen() has just been
called, with memcpy() (usually including the '\0').

Calls with copy string literals into arrays are left unchanged.
They are safe and easily detected as such.

The changes were made by getting the compiler to detect the calls and
then fixing the code by hand.

Note that all the changes are only compile tested.

Some Makefiles were changed to allow files to contain strcpy().
As well as 'difficult to fix' files, this included 'show' functions
as they really need to use sysfs_emit() or seq_printf().

All the patches are being sent individually to avoid very long cc lists.
Apologies for the terse commit messages and likely unexpected tags.
(There are about 100 patches in total.)

 drivers/net/ethernet/freescale/gianfar.c | 14 +++++++-------
 1 file changed, 7 insertions(+), 7 deletions(-)

diff --git a/drivers/net/ethernet/freescale/gianfar.c b/drivers/net/ethernet/freescale/gianfar.c
index 3271de5844f8..10ab1d1e63ef 100644
--- a/drivers/net/ethernet/freescale/gianfar.c
+++ b/drivers/net/ethernet/freescale/gianfar.c
@@ -3281,14 +3281,14 @@ static int gfar_probe(struct platform_device *ofdev)
 	for (i = 0; i < priv->num_grps; i++) {
 		struct gfar_priv_grp *grp = &priv->gfargrp[i];
 		if (priv->device_flags & FSL_GIANFAR_DEV_HAS_MULTI_INTR) {
-			sprintf(gfar_irq(grp, TX)->name, "%s%s%c%s",
-				dev->name, "_g", '0' + i, "_tx");
-			sprintf(gfar_irq(grp, RX)->name, "%s%s%c%s",
-				dev->name, "_g", '0' + i, "_rx");
-			sprintf(gfar_irq(grp, ER)->name, "%s%s%c%s",
-				dev->name, "_g", '0' + i, "_er");
+			snprintf(gfar_irq(grp, TX)->name, sizeof (gfar_irq(grp, ER)->name),
+				 "%s_g%c_tx", dev->name, '0' + i);
+			snprintf(gfar_irq(grp, RX)->name, sizeof (gfar_irq(grp, ER)->name),
+				 "%s_g%c_rx", dev->name, '0' + i);
+			snprintf(gfar_irq(grp, ER)->name, sizeof (gfar_irq(grp, ER)->name),
+				 "%s_g%c-er", dev->name, '0' + i);
 		} else
-			strcpy(gfar_irq(grp, TX)->name, dev->name);
+			strscpy(gfar_irq(grp, TX)->name, dev->name);
 	}
 
 	/* Initialize the filer table */
-- 
2.39.5