Netdev List
 help / color / mirror / Atom feed
From: Jakub Kicinski <kuba@kernel.org>
To: Willem de Bruijn <willemdebruijn.kernel@gmail.com>
Cc: davem@davemloft.net, netdev@vger.kernel.org, edumazet@google.com,
	pabeni@redhat.com, andrew+netdev@lunn.ch, horms@kernel.org
Subject: Re: [PATCH net-next v2 0/2] selftests: drv-net: so_txtime: trivial fixes
Date: Wed, 10 Jun 2026 17:06:51 -0700	[thread overview]
Message-ID: <20260610170651.1b644001@kernel.org> (raw)
In-Reply-To: <willemdebruijn.kernel.6915d686a22b@gmail.com>

On Tue, 09 Jun 2026 22:48:34 -0400 Willem de Bruijn wrote:
> Willem de Bruijn wrote:
> > Jakub Kicinski wrote:  
> > > I noticed that so_txtime is only passing on NIPA setups which are
> > > looped within a single host. The cross-machine cases just flat out
> > > fail. The initial bug is obvious - the test does not deploy the binary.
> > > But even with that I think more work would be needed to sync the
> > > time / adjust the expectations for a dual-machine test.
> > > 
> > > Willem promised to follow up on the fundamental issues with 2-host
> > > setups :)  
> > 
> > Yep.  
> 
> With these fixes the tests run fine manually on a non-dbg kernel.
> 
> The CI failures are on the netdev-X710-dbg remote only, correct?
> 
> https://netdev.bots.linux.dev/flakes.html
> https://netdev.bots.linux.dev/contest.html?executor=hwksft-X710-dbg&test=so-txtime-py
> 
> Those flakes all have a delivery later than expected, e.g.,
> 
>     # # Exception|   STDERR: payload:a delay:30747 expected:0 (us)
>     # # Exception|           exceeds variance (4000 us)
> 
> Does this remote have KSFT_MACHINE_SLOW set? This should only result in error
> 
> From contest/remote/lib/vm.py on nipa.git:
> 
>         slowdown = self.config.getfloat('vm', 'slowdown', fallback=0)
>         if slowdown:
>             self.cmd("export KSFT_MACHINE_SLOW=yes")
> 
> But I don't know where (or whether) I can review this config.

Ah, that's probably buggy. You can sort-of see the config written
dynamically here 
https://netdev.bots.linux.dev/logs/hwksft/X710-dbg/results/684641/deploy

I will fix the SLOW part, but I don't think that's the main problem, if
you look at
https://netdev.bots.linux.dev/devices.html
the X710-dbg is actually the only setup that had enough passes to
qualify as test supported. The blue cases mean that for most of the
other NICs half of the test cases fail. X710 non-debug probably dies
because we're waiting for a fix to a NAPI deadlock an earlier test
triggers, ignore it.

  reply	other threads:[~2026-06-11  0:06 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-06-09 18:08 [PATCH net-next v2 0/2] selftests: drv-net: so_txtime: trivial fixes Jakub Kicinski
2026-06-09 18:08 ` [PATCH net-next v2 1/2] selftests: drv-net: so_txtime: remember to deploy the binaries Jakub Kicinski
2026-06-09 18:08 ` [PATCH net-next v2 2/2] selftests: drv-net: so_txtime: check IP versions Jakub Kicinski
2026-06-09 18:44 ` [PATCH net-next v2 0/2] selftests: drv-net: so_txtime: trivial fixes Willem de Bruijn
2026-06-10  2:48   ` Willem de Bruijn
2026-06-11  0:06     ` Jakub Kicinski [this message]
2026-06-11  9:50 ` patchwork-bot+netdevbpf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260610170651.1b644001@kernel.org \
    --to=kuba@kernel.org \
    --cc=andrew+netdev@lunn.ch \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=horms@kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=willemdebruijn.kernel@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox