Netdev List
 help / color / mirror / Atom feed
From: Simon Horman <horms@kernel.org>
To: Ren Wei <n05ec@lzu.edu.cn>
Cc: linux-atm-general@lists.sourceforge.net, netdev@vger.kernel.org,
	3chas3@gmail.com, yuantan098@gmail.com, bird@lzu.edu.cn,
	zcliangcn@gmail.com
Subject: Re: [PATCH net 1/1] net: atm: reject out-of-range traffic classes in QoS validation
Date: Thu, 11 Jun 2026 17:37:09 +0100	[thread overview]
Message-ID: <20260611163709.GW3920875@horms.kernel.org> (raw)
In-Reply-To: <58f02c6f73d9818fd5d2022e1116759fdde6116b.1780965530.git.zcliangcn@gmail.com>

On Tue, Jun 09, 2026 at 04:34:37PM +0800, Ren Wei wrote:
> From: Zhengchuan Liang <zcliangcn@gmail.com>
> 
> Reject ATM traffic classes above ATM_ANYCLASS in check_tp().
> SO_ATMQOS stores the supplied QoS after check_qos() succeeds, so
> accepting larger values leaves invalid traffic_class values in
> vcc->qos.
> 
> That bad state later reaches pvc_info(), which indexes class_name[]
> with vcc->qos.{rx,tp}.traffic_class. Values above ATM_ANYCLASS cause
> an out-of-bounds read when /proc/net/atm/pvc is read.
> 
> Tighten the existing QoS validation so invalid traffic_class values
> are rejected at the point where user supplied QoS is accepted.
> 
> Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2")
> Cc: stable@vger.kernel.org
> Reported-by: Yuan Tan <yuantan098@gmail.com>
> Reported-by: Xin Liu <bird@lzu.edu.cn>
> Assisted-by: Codex:GPT-5.4
> Signed-off-by: Zhengchuan Liang <zcliangcn@gmail.com>
> Signed-off-by: Ren Wei <n05ec@lzu.edu.cn>

Reviewed-by: Simon Horman <horms@kernel.org>

I believe the issue flagged by AI-generated review on
https://netdev-ai.bots.linux.dev/sashiko/ is a false positive.

      reply	other threads:[~2026-06-11 16:37 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <cover.1780965530.git.zcliangcn@gmail.com>
2026-06-09  8:34 ` [PATCH net 1/1] net: atm: reject out-of-range traffic classes in QoS validation Ren Wei
2026-06-11 16:37   ` Simon Horman [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260611163709.GW3920875@horms.kernel.org \
    --to=horms@kernel.org \
    --cc=3chas3@gmail.com \
    --cc=bird@lzu.edu.cn \
    --cc=linux-atm-general@lists.sourceforge.net \
    --cc=n05ec@lzu.edu.cn \
    --cc=netdev@vger.kernel.org \
    --cc=yuantan098@gmail.com \
    --cc=zcliangcn@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox