From: Jakub Kicinski <kuba@kernel.org>
To: "Creeley, Brett" <bcreeley@amd.com>
Cc: Breno Leitao <leitao@debian.org>,
davem@davemloft.net, netdev@vger.kernel.org, edumazet@google.com,
pabeni@redhat.com, andrew+netdev@lunn.ch, horms@kernel.org,
brett.creeley@amd.com, eric.joyner@amd.com
Subject: Re: [PATCH net-next] eth: ionic: delete the incorrect link_down_count reporting
Date: Mon, 15 Jun 2026 18:28:36 -0700 [thread overview]
Message-ID: <20260615182836.24b0b329@kernel.org> (raw)
In-Reply-To: <3193fb6f-d786-4b8a-ace3-d63264c95529@amd.com>
On Mon, 15 Jun 2026 10:29:54 -0700 Creeley, Brett wrote:
> >> memcpy_fromio(p + offset, idev->dev_cmd_regs->words, size);
> >> }
> >>
> >> -static void ionic_get_link_ext_stats(struct net_device *netdev,
> >> - struct ethtool_link_ext_stats *stats)
> >> -{
> >> - struct ionic_lif *lif = netdev_priv(netdev);
> >> -
> >> - if (lif->ionic->pdev->is_physfn)
> >> - stats->link_down_events = lif->link_down_count;
> > It seems this is the only place where link_down_count is read. Maybe you
> > want to kill it as well?
>
> It still shows in debugfs, but we'd be fine with it being removed
> completely in favor of the correct implementation from Eric at:
> https://lore.kernel.org/netdev/20260614205303.48088-5-eric.joyner@amd.com/.
TBH I missed that Eric posted v5 already and assumed he won't make it
before net-next is closed. Sorry for the noise...
--
pw-bot: reject
prev parent reply other threads:[~2026-06-16 1:28 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-15 17:01 [PATCH net-next] eth: ionic: delete the incorrect link_down_count reporting Jakub Kicinski
2026-06-15 17:14 ` Breno Leitao
2026-06-15 17:29 ` Creeley, Brett
2026-06-16 1:28 ` Jakub Kicinski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260615182836.24b0b329@kernel.org \
--to=kuba@kernel.org \
--cc=andrew+netdev@lunn.ch \
--cc=bcreeley@amd.com \
--cc=brett.creeley@amd.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=eric.joyner@amd.com \
--cc=horms@kernel.org \
--cc=leitao@debian.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox