* [TEST] vlan-bridge-binding-sh flaky
@ 2026-06-16 16:27 Jakub Kicinski
2026-06-17 7:25 ` Ido Schimmel
0 siblings, 1 reply; 2+ messages in thread
From: Jakub Kicinski @ 2026-06-16 16:27 UTC (permalink / raw)
To: Ido Schimmel; +Cc: netdev, Petr Machata
Hi Ido!
tools/testing/selftests/net/vlan_bridge_binding.sh got flaky recently.
https://netdev.bots.linux.dev/contest.html?test=vlan-bridge-binding-sh
Is it due to Eric's change or something else? Used to be pretty solid.
First lake a week ago and 8 more since, before that for 3 weeks there
were 0 flakes.
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [TEST] vlan-bridge-binding-sh flaky
2026-06-16 16:27 [TEST] vlan-bridge-binding-sh flaky Jakub Kicinski
@ 2026-06-17 7:25 ` Ido Schimmel
0 siblings, 0 replies; 2+ messages in thread
From: Ido Schimmel @ 2026-06-17 7:25 UTC (permalink / raw)
To: Jakub Kicinski; +Cc: netdev, Petr Machata
On Tue, Jun 16, 2026 at 09:27:33AM -0700, Jakub Kicinski wrote:
> Hi Ido!
>
> tools/testing/selftests/net/vlan_bridge_binding.sh got flaky recently.
>
> https://netdev.bots.linux.dev/contest.html?test=vlan-bridge-binding-sh
>
> Is it due to Eric's change or something else? Used to be pretty solid.
> First lake a week ago and 8 more since, before that for 3 weeks there
> were 0 flakes.
The failure reason is the same across all the test runs: Observing an UP
operational state instead of DOWN. I believe that's because link watch
can delay carrier loss events by up to 1 second and that's the timeout
the test is using.
I increased the timeout to 2 seconds and didn't observe a failure in
over 100 iterations. Previously it failed after 48 iterations.
I will send a patch.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2026-06-17 7:25 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-06-16 16:27 [TEST] vlan-bridge-binding-sh flaky Jakub Kicinski
2026-06-17 7:25 ` Ido Schimmel
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox