From: Francois Romieu <romieu@fr.zoreil.com>
To: Atharva Potdar <atharvapotdar07@gmail.com>
Cc: hkallweit1@gmail.com, nic_swsd@realtek.com,
andrew+netdev@lunn.ch, davem@davemloft.net, edumazet@google.com,
kuba@kernel.org, pabeni@redhat.com, netdev@vger.kernel.org
Subject: Re: [PATCH net-next] r8169: migrate Rx path to page_pool
Date: Thu, 18 Jun 2026 00:25:22 +0200 [thread overview]
Message-ID: <20260617222522.GA3712043@electric-eye.fr.zoreil.com> (raw)
In-Reply-To: <CAF9AHva0TSFz5tedMEgJTkhThzDGqmW7MJshAtf3ULbLY4wd=w@mail.gmail.com>
Atharva Potdar <atharvapotdar07@gmail.com> :
[...]
> Francois:
> > You may consider fdd7b4c3302c93f6833e338903ea77245eb510b4 and some related
> > changes around that time.
>
> I am sorry but I don't fully understand the context of this commit or
> the behaviour it addresses. Could you please help me regarding what I
> need to watch out for this change?
It should be clearer with c0cd884af045338476b8e69a61fceb3f34ff22f1 (and
may be 6f0333b8fde44b8c04a53b2461504f0e8f1cebe6 as well).
Old chipsets did not correctly implement receive buffer size limit.
I have no idea how mildly recent ones (< 15 years) behave.
Reinstatement of the bug on old chipset imho deserves some warning.
--
Ueimor
prev parent reply other threads:[~2026-06-17 22:26 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-14 5:41 [PATCH net-next] r8169: migrate Rx path to page_pool atharva-potdar
2026-06-14 20:26 ` Heiner Kallweit
2026-06-14 22:09 ` Francois Romieu
2026-06-17 3:28 ` Atharva Potdar
2026-06-17 16:50 ` Heiner Kallweit
2026-06-17 16:52 ` Heiner Kallweit
2026-06-17 22:25 ` Francois Romieu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260617222522.GA3712043@electric-eye.fr.zoreil.com \
--to=romieu@fr.zoreil.com \
--cc=andrew+netdev@lunn.ch \
--cc=atharvapotdar07@gmail.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=hkallweit1@gmail.com \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=nic_swsd@realtek.com \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox