* [PATCH iwl-net] idpf: fix max_vport related crash on allocation error during init
@ 2026-06-18 19:23 Emil Tantilov
2026-06-18 19:37 ` [Intel-wired-lan] " Loktionov, Aleksandr
2026-06-22 7:30 ` Simon Horman
0 siblings, 2 replies; 3+ messages in thread
From: Emil Tantilov @ 2026-06-18 19:23 UTC (permalink / raw)
To: intel-wired-lan
Cc: netdev, anthony.l.nguyen, przemyslaw.kitszel, andrew+netdev,
davem, edumazet, kuba, pabeni, madhu.chittim
Set adapter->max_vports only after successful allocation of vports, netdevs
and vport_config buffers. This fixes possible crashes on reset or rmmod,
following failed allocation on init
[ 305.981402] idpf 0000:83:00.0: enabling device (0100 -> 0102)
[ 305.994464] idpf 0000:83:00.0: Device HW Reset initiated
[ 320.416872] BUG: kernel NULL pointer dereference, address: 0000000000000000
[ 320.416918] #PF: supervisor read access in kernel mode
[ 320.416942] #PF: error_code(0x0000) - not-present page
[ 320.416963] PGD 2099657067 P4D 0
[ 320.416983] Oops: Oops: 0000 [#1] SMP NOPTI
...
[ 320.417093] RIP: 0010:idpf_remove+0x118/0x200 [idpf]
[ 320.417130] Code: 8b bb 98 09 00 00 e8 17 0f 5b e5 48 8b bb e8 08 00 00 e8 0b 0f 5b e5 66 83 bb 28 06 00 00 00 48 8b bb 20 06 00 00 74 49 31 ed <48> 8b 04 ef 48 85 c0 74 2f 48 8b 78 20 e8 66 58 91 e5 48 8b 83 20
[ 320.417183] RSP: 0018:ff7322212903fdb8 EFLAGS: 00010246
[ 320.417205] RAX: 0000000000000000 RBX: ff4463de40300000 RCX: ff7322212903fd4c
[ 320.417228] RDX: 0000000000000001 RSI: ffffffffa7f7d100 RDI: 0000000000000000
[ 320.417250] RBP: 0000000000000000 R08: 0000000000000001 R09: 0000000000000000
[ 320.417272] R10: 0000000000000001 R11: ff4463de3a638f58 R12: ff4463be89ac7000
[ 320.417294] R13: ff4463be89ac7198 R14: ff4463be94fc7198 R15: ffffffffc0f10f20
[ 320.417317] FS: 00007f963c0e6740(0000) GS:ff4463fdd65d8000(0000) knlGS:0000000000000000
[ 320.417342] CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033
[ 320.417362] CR2: 0000000000000000 CR3: 00000020ba674002 CR4: 0000000000773ef0
[ 320.417385] PKRU: 55555554
[ 320.417398] Call Trace:
[ 320.417412] <TASK>
[ 320.417429] pci_device_remove+0x42/0xb0
[ 320.417459] device_release_driver_internal+0x1a9/0x210
[ 320.417492] driver_detach+0x4b/0x90
[ 320.417516] bus_remove_driver+0x70/0x100
[ 320.417539] pci_unregister_driver+0x2e/0xb0
[ 320.417564] __do_sys_delete_module.constprop.0+0x190/0x2f0
[ 320.417592] ? kmem_cache_free+0x31e/0x550
[ 320.417619] ? lockdep_hardirqs_on_prepare+0xde/0x190
[ 320.417644] ? do_syscall_64+0x38/0x6b0
[ 320.417665] do_syscall_64+0xc8/0x6b0
[ 320.417683] ? clear_bhb_loop+0x30/0x80
[ 320.417706] entry_SYSCALL_64_after_hwframe+0x76/0x7e
[ 320.417727] RIP: 0033:0x7f963bb30beb
Fixes: 0fe45467a104 ("idpf: add create vport and netdev configuration")
Reviewed-by: Madhu Chittim <madhu.chittim@intel.com>
Signed-off-by: Emil Tantilov <emil.s.tantilov@intel.com>
---
drivers/net/ethernet/intel/idpf/idpf_virtchnl.c | 7 ++++++-
1 file changed, 6 insertions(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/intel/idpf/idpf_virtchnl.c b/drivers/net/ethernet/intel/idpf/idpf_virtchnl.c
index be66f9b2e101..dc5ad784f456 100644
--- a/drivers/net/ethernet/intel/idpf/idpf_virtchnl.c
+++ b/drivers/net/ethernet/intel/idpf/idpf_virtchnl.c
@@ -3555,7 +3555,6 @@ int idpf_vc_core_init(struct idpf_adapter *adapter)
pci_sriov_set_totalvfs(adapter->pdev, idpf_get_max_vfs(adapter));
num_max_vports = idpf_get_max_vports(adapter);
- adapter->max_vports = num_max_vports;
adapter->vports = kzalloc_objs(*adapter->vports, num_max_vports);
if (!adapter->vports)
return -ENOMEM;
@@ -3576,6 +3575,12 @@ int idpf_vc_core_init(struct idpf_adapter *adapter)
goto err_netdev_alloc;
}
+ /* Set max_vports only after vports, netdevs and vport_config buffers
+ * are allocated to make sure max_vport bound loops don't end up
+ * crashing, following allocation errors on init.
+ */
+ adapter->max_vports = num_max_vports;
+
/* Start the mailbox task before requesting vectors. This will ensure
* vector information response from mailbox is handled
*/
--
2.37.3
^ permalink raw reply related [flat|nested] 3+ messages in thread
* RE: [Intel-wired-lan] [PATCH iwl-net] idpf: fix max_vport related crash on allocation error during init
2026-06-18 19:23 [PATCH iwl-net] idpf: fix max_vport related crash on allocation error during init Emil Tantilov
@ 2026-06-18 19:37 ` Loktionov, Aleksandr
2026-06-22 7:30 ` Simon Horman
1 sibling, 0 replies; 3+ messages in thread
From: Loktionov, Aleksandr @ 2026-06-18 19:37 UTC (permalink / raw)
To: Tantilov, Emil S, intel-wired-lan@lists.osuosl.org
Cc: netdev@vger.kernel.org, Nguyen, Anthony L, Kitszel, Przemyslaw,
andrew+netdev@lunn.ch, davem@davemloft.net, edumazet@google.com,
kuba@kernel.org, pabeni@redhat.com, Chittim, Madhu
> -----Original Message-----
> From: Intel-wired-lan <intel-wired-lan-bounces@osuosl.org> On Behalf
> Of Emil Tantilov
> Sent: Thursday, June 18, 2026 9:23 PM
> To: intel-wired-lan@lists.osuosl.org
> Cc: netdev@vger.kernel.org; Nguyen, Anthony L
> <anthony.l.nguyen@intel.com>; Kitszel, Przemyslaw
> <przemyslaw.kitszel@intel.com>; andrew+netdev@lunn.ch;
> davem@davemloft.net; edumazet@google.com; kuba@kernel.org;
> pabeni@redhat.com; Chittim, Madhu <madhu.chittim@intel.com>
> Subject: [Intel-wired-lan] [PATCH iwl-net] idpf: fix max_vport related
> crash on allocation error during init
>
> Set adapter->max_vports only after successful allocation of vports,
> netdevs and vport_config buffers. This fixes possible crashes on
> reset or rmmod, following failed allocation on init
>
> [ 305.981402] idpf 0000:83:00.0: enabling device (0100 -> 0102) [
> 305.994464] idpf 0000:83:00.0: Device HW Reset initiated [
> 320.416872] BUG: kernel NULL pointer dereference, address:
> 0000000000000000 [ 320.416918] #PF: supervisor read access in kernel
> mode [ 320.416942] #PF: error_code(0x0000) - not-present page [
> 320.416963] PGD 2099657067 P4D 0 [ 320.416983] Oops: Oops: 0000 [#1]
> SMP NOPTI ...
> [ 320.417093] RIP: 0010:idpf_remove+0x118/0x200 [idpf] [ 320.417130]
> Code: 8b bb 98 09 00 00 e8 17 0f 5b e5 48 8b bb e8 08 00 00 e8 0b 0f
> 5b e5 66 83 bb 28 06 00 00 00 48 8b bb 20 06 00 00 74 49 31 ed <48> 8b
> 04 ef 48 85 c0 74 2f 48 8b 78 20 e8 66 58 91 e5 48 8b 83 20 [
> 320.417183] RSP: 0018:ff7322212903fdb8 EFLAGS: 00010246 [ 320.417205]
> RAX: 0000000000000000 RBX: ff4463de40300000 RCX: ff7322212903fd4c [
> 320.417228] RDX: 0000000000000001 RSI: ffffffffa7f7d100 RDI:
> 0000000000000000 [ 320.417250] RBP: 0000000000000000 R08:
> 0000000000000001 R09: 0000000000000000 [ 320.417272] R10:
> 0000000000000001 R11: ff4463de3a638f58 R12: ff4463be89ac7000 [
> 320.417294] R13: ff4463be89ac7198 R14: ff4463be94fc7198 R15:
> ffffffffc0f10f20 [ 320.417317] FS: 00007f963c0e6740(0000)
> GS:ff4463fdd65d8000(0000) knlGS:0000000000000000 [ 320.417342] CS:
> 0010 DS: 0000 ES: 0000 CR0: 0000000080050033 [ 320.417362] CR2:
> 0000000000000000 CR3: 00000020ba674002 CR4: 0000000000773ef0 [
> 320.417385] PKRU: 55555554 [ 320.417398] Call Trace:
> [ 320.417412] <TASK>
> [ 320.417429] pci_device_remove+0x42/0xb0 [ 320.417459]
> device_release_driver_internal+0x1a9/0x210
> [ 320.417492] driver_detach+0x4b/0x90
> [ 320.417516] bus_remove_driver+0x70/0x100 [ 320.417539]
> pci_unregister_driver+0x2e/0xb0 [ 320.417564]
> __do_sys_delete_module.constprop.0+0x190/0x2f0
> [ 320.417592] ? kmem_cache_free+0x31e/0x550 [ 320.417619] ?
> lockdep_hardirqs_on_prepare+0xde/0x190
> [ 320.417644] ? do_syscall_64+0x38/0x6b0 [ 320.417665]
> do_syscall_64+0xc8/0x6b0 [ 320.417683] ? clear_bhb_loop+0x30/0x80 [
> 320.417706] entry_SYSCALL_64_after_hwframe+0x76/0x7e
> [ 320.417727] RIP: 0033:0x7f963bb30beb
>
> Fixes: 0fe45467a104 ("idpf: add create vport and netdev
> configuration")
> Reviewed-by: Madhu Chittim <madhu.chittim@intel.com>
> Signed-off-by: Emil Tantilov <emil.s.tantilov@intel.com>
> ---
> drivers/net/ethernet/intel/idpf/idpf_virtchnl.c | 7 ++++++-
> 1 file changed, 6 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/net/ethernet/intel/idpf/idpf_virtchnl.c
> b/drivers/net/ethernet/intel/idpf/idpf_virtchnl.c
> index be66f9b2e101..dc5ad784f456 100644
> --- a/drivers/net/ethernet/intel/idpf/idpf_virtchnl.c
> +++ b/drivers/net/ethernet/intel/idpf/idpf_virtchnl.c
> @@ -3555,7 +3555,6 @@ int idpf_vc_core_init(struct idpf_adapter
> *adapter)
>
> pci_sriov_set_totalvfs(adapter->pdev,
> idpf_get_max_vfs(adapter));
> num_max_vports = idpf_get_max_vports(adapter);
> - adapter->max_vports = num_max_vports;
> adapter->vports = kzalloc_objs(*adapter->vports,
> num_max_vports);
> if (!adapter->vports)
> return -ENOMEM;
> @@ -3576,6 +3575,12 @@ int idpf_vc_core_init(struct idpf_adapter
> *adapter)
> goto err_netdev_alloc;
> }
>
> + /* Set max_vports only after vports, netdevs and vport_config
> buffers
> + * are allocated to make sure max_vport bound loops don't end
> up
> + * crashing, following allocation errors on init.
> + */
> + adapter->max_vports = num_max_vports;
> +
> /* Start the mailbox task before requesting vectors. This will
> ensure
> * vector information response from mailbox is handled
> */
> --
> 2.37.3
Reviewed-by: Aleksandr Loktionov <aleksandr.loktionov@intel.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH iwl-net] idpf: fix max_vport related crash on allocation error during init
2026-06-18 19:23 [PATCH iwl-net] idpf: fix max_vport related crash on allocation error during init Emil Tantilov
2026-06-18 19:37 ` [Intel-wired-lan] " Loktionov, Aleksandr
@ 2026-06-22 7:30 ` Simon Horman
1 sibling, 0 replies; 3+ messages in thread
From: Simon Horman @ 2026-06-22 7:30 UTC (permalink / raw)
To: Emil Tantilov
Cc: intel-wired-lan, netdev, anthony.l.nguyen, przemyslaw.kitszel,
andrew+netdev, davem, edumazet, kuba, pabeni, madhu.chittim
On Thu, Jun 18, 2026 at 12:23:25PM -0700, Emil Tantilov wrote:
> Set adapter->max_vports only after successful allocation of vports, netdevs
> and vport_config buffers. This fixes possible crashes on reset or rmmod,
> following failed allocation on init
>
> [ 305.981402] idpf 0000:83:00.0: enabling device (0100 -> 0102)
> [ 305.994464] idpf 0000:83:00.0: Device HW Reset initiated
> [ 320.416872] BUG: kernel NULL pointer dereference, address: 0000000000000000
> [ 320.416918] #PF: supervisor read access in kernel mode
> [ 320.416942] #PF: error_code(0x0000) - not-present page
> [ 320.416963] PGD 2099657067 P4D 0
> [ 320.416983] Oops: Oops: 0000 [#1] SMP NOPTI
> ...
> [ 320.417093] RIP: 0010:idpf_remove+0x118/0x200 [idpf]
> [ 320.417130] Code: 8b bb 98 09 00 00 e8 17 0f 5b e5 48 8b bb e8 08 00 00 e8 0b 0f 5b e5 66 83 bb 28 06 00 00 00 48 8b bb 20 06 00 00 74 49 31 ed <48> 8b 04 ef 48 85 c0 74 2f 48 8b 78 20 e8 66 58 91 e5 48 8b 83 20
> [ 320.417183] RSP: 0018:ff7322212903fdb8 EFLAGS: 00010246
> [ 320.417205] RAX: 0000000000000000 RBX: ff4463de40300000 RCX: ff7322212903fd4c
> [ 320.417228] RDX: 0000000000000001 RSI: ffffffffa7f7d100 RDI: 0000000000000000
> [ 320.417250] RBP: 0000000000000000 R08: 0000000000000001 R09: 0000000000000000
> [ 320.417272] R10: 0000000000000001 R11: ff4463de3a638f58 R12: ff4463be89ac7000
> [ 320.417294] R13: ff4463be89ac7198 R14: ff4463be94fc7198 R15: ffffffffc0f10f20
> [ 320.417317] FS: 00007f963c0e6740(0000) GS:ff4463fdd65d8000(0000) knlGS:0000000000000000
> [ 320.417342] CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033
> [ 320.417362] CR2: 0000000000000000 CR3: 00000020ba674002 CR4: 0000000000773ef0
> [ 320.417385] PKRU: 55555554
> [ 320.417398] Call Trace:
> [ 320.417412] <TASK>
> [ 320.417429] pci_device_remove+0x42/0xb0
> [ 320.417459] device_release_driver_internal+0x1a9/0x210
> [ 320.417492] driver_detach+0x4b/0x90
> [ 320.417516] bus_remove_driver+0x70/0x100
> [ 320.417539] pci_unregister_driver+0x2e/0xb0
> [ 320.417564] __do_sys_delete_module.constprop.0+0x190/0x2f0
> [ 320.417592] ? kmem_cache_free+0x31e/0x550
> [ 320.417619] ? lockdep_hardirqs_on_prepare+0xde/0x190
> [ 320.417644] ? do_syscall_64+0x38/0x6b0
> [ 320.417665] do_syscall_64+0xc8/0x6b0
> [ 320.417683] ? clear_bhb_loop+0x30/0x80
> [ 320.417706] entry_SYSCALL_64_after_hwframe+0x76/0x7e
> [ 320.417727] RIP: 0033:0x7f963bb30beb
>
> Fixes: 0fe45467a104 ("idpf: add create vport and netdev configuration")
> Reviewed-by: Madhu Chittim <madhu.chittim@intel.com>
> Signed-off-by: Emil Tantilov <emil.s.tantilov@intel.com>
Reviewed-by: Simon Horman <horms@kernel.org>
FTR, an AI generated review of this patch is available on sashiko.dev.
I think that the issue raised there can be looked at in the context of
possible follow-up.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2026-06-22 7:31 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-06-18 19:23 [PATCH iwl-net] idpf: fix max_vport related crash on allocation error during init Emil Tantilov
2026-06-18 19:37 ` [Intel-wired-lan] " Loktionov, Aleksandr
2026-06-22 7:30 ` Simon Horman
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox