* [PATCH net-next] chelsio: delete the line with the pidx initialization
@ 2026-06-29 13:08 Markov Gleb
2026-07-01 0:16 ` Jakub Kicinski
0 siblings, 1 reply; 2+ messages in thread
From: Markov Gleb @ 2026-06-29 13:08 UTC (permalink / raw)
To: Andrew Lunn
Cc: Gleb Markov, David S . Miller, Eric Dumazet, Jakub Kicinski,
Paolo Abeni, netdev, linux-kernel, lvc-project
From: Gleb Markov <markov.gi@npc-ksb.ru>
The value of pidx is overwritten immediately after exiting the "if" block.
Remove pidx ptr initialization string from conditional block.
Found by Linux Verification Center (linuxtesting.org) with SVACE.
Signed-off-by: Gleb Markov <markov.gi@npc-ksb.ru>
---
drivers/net/ethernet/chelsio/cxgb/sge.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/net/ethernet/chelsio/cxgb/sge.c b/drivers/net/ethernet/chelsio/cxgb/sge.c
index 861edff5ed89..4e93d82d5892 100644
--- a/drivers/net/ethernet/chelsio/cxgb/sge.c
+++ b/drivers/net/ethernet/chelsio/cxgb/sge.c
@@ -1743,7 +1743,6 @@ static int t1_sge_tx(struct sk_buff *skb, struct adapter *adapter,
spin_unlock(&q->lock);
return NETDEV_TX_OK;
}
- pidx = q->pidx;
count = 1 + skb_shinfo(skb)->nr_frags;
count += compute_large_page_tx_descs(skb);
}
--
2.43.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH net-next] chelsio: delete the line with the pidx initialization
2026-06-29 13:08 [PATCH net-next] chelsio: delete the line with the pidx initialization Markov Gleb
@ 2026-07-01 0:16 ` Jakub Kicinski
0 siblings, 0 replies; 2+ messages in thread
From: Jakub Kicinski @ 2026-07-01 0:16 UTC (permalink / raw)
To: Markov Gleb
Cc: Andrew Lunn, David S . Miller, Eric Dumazet, Paolo Abeni, netdev,
linux-kernel, lvc-project
On Mon, 29 Jun 2026 16:08:35 +0300 Markov Gleb wrote:
> The value of pidx is overwritten immediately after exiting the "if" block.
>
> Remove pidx ptr initialization string from conditional block.
shrug?
--
pw-bot: reject
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2026-07-01 0:16 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-06-29 13:08 [PATCH net-next] chelsio: delete the line with the pidx initialization Markov Gleb
2026-07-01 0:16 ` Jakub Kicinski
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox