[PATCH net-next] ethtool: link 10000baseCR to SFF-8431, Appendix-E SFP+ DA

[PATCH net-next] ethtool: link 10000baseCR to SFF-8431, Appendix-E SFP+ DA

[Siddaraju DH]

Add comment to clarify the physical media 10000baseCR follows.

10000baseCR does not correspond to any IEEE 802.3 *base-CR PMD.
It has no autonegotiation, no link training, and no mandatory FEC.
The industry standard for this media type is SFF-8431 Appendix-E
Direct Attach cable, also known as 10G_SFI_DA.

This change follows the conversation from netdev mail thread with
subject: "the confusing 10000base_CR. Shouldn't it be 10000_SFI_DA?"

Signed-off-by: Siddaraju DH <siddaraju.dh@intel.com>
---
 include/uapi/linux/ethtool.h | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/include/uapi/linux/ethtool.h b/include/uapi/linux/ethtool.h
index a2091d4e00f3..986d70caec33 100644
--- a/include/uapi/linux/ethtool.h
+++ b/include/uapi/linux/ethtool.h
@@ -2013,7 +2013,13 @@ enum ethtool_link_mode_bit_indices {
 	ETHTOOL_LINK_MODE_100000baseLR4_ER4_Full_BIT	= 39,
 	ETHTOOL_LINK_MODE_50000baseSR2_Full_BIT		= 40,
 	ETHTOOL_LINK_MODE_1000baseX_Full_BIT	= 41,
+
+	/* Despite the "baseCR" in 10000baseCR, this is not an IEEE 802.3 baseCR
+	 * It represents SFF-8431 Appendix-E SFP+ Direct Attach (10G-SFI-DA).
+	 * The name is kept as-is for uAPI backward compatibility.
+	 */
 	ETHTOOL_LINK_MODE_10000baseCR_Full_BIT	= 42,
+
 	ETHTOOL_LINK_MODE_10000baseSR_Full_BIT	= 43,
 	ETHTOOL_LINK_MODE_10000baseLR_Full_BIT	= 44,
 	ETHTOOL_LINK_MODE_10000baseLRM_Full_BIT	= 45,
-- 
2.25.1

Re: [PATCH net-next] ethtool: link 10000baseCR to SFF-8431, Appendix-E SFP+ DA

[Andrew Lunn]

On Thu, Jul 02, 2026 at 08:23:26PM +0530, Siddaraju DH wrote:
> Add comment to clarify the physical media 10000baseCR follows.
> 
> 10000baseCR does not correspond to any IEEE 802.3 *base-CR PMD.
> It has no autonegotiation, no link training, and no mandatory FEC.
> The industry standard for this media type is SFF-8431 Appendix-E
> Direct Attach cable, also known as 10G_SFI_DA.
> 
> This change follows the conversation from netdev mail thread with
> subject: "the confusing 10000base_CR. Shouldn't it be 10000_SFI_DA?"

Please add a link to lore, it makes it a lot easier to get to the
discussion.

Link: https://lore.kernel.org/r/[Message-ID]

    Andrew

---
pw-bot: cr
 

RE: [PATCH net-next] ethtool: link 10000baseCR to SFF-8431, Appendix-E SFP+ DA

[D H, Siddaraju]

On Thu, Jul 02, 2026, Andrew Lunn wrote:
> Please add a link to lore, it makes it a lot easier to get to the discussion.
> 
> Link: https://lore.kernel.org/r/[Message-ID]

To be honest with you Andrew, I was so confused since this Link: <URL>
was exceeding the 75 char limit and I attempted to at least link it
through the subject. Thank you for taking time to re-clarify it, Andrew.
It's clear to me now. Have sent v2 patches with "Link: <URL>".
Please make some time to re-review.

- Thank you,
Siddaraju D H