* [PATCH net] selftests: netfilter: conntrack_resize.sh: fix skip exit code
[not found] <20260705204252.630729-1-dharmikparmar2004.ref@yahoo.com>
@ 2026-07-05 20:42 ` Dharmik Parmar
2026-07-06 6:53 ` Florian Westphal
0 siblings, 1 reply; 2+ messages in thread
From: Dharmik Parmar @ 2026-07-05 20:42 UTC (permalink / raw)
To: netdev; +Cc: Dharmik Parmar
When conntrack sysctls are unavailable, the test prints SKIP but exits
with $KSFT_SKIP. lib.sh defines ksft_skip instead, so the kselftest
runner did not see a proper skip.
Use ksft_skip.
Fixes: d33f889fd80c ("selftests: netfilter: add conntrack stress test")
Signed-off-by: Dharmik Parmar <dharmikparmar2004@yahoo.com>
---
tools/testing/selftests/net/netfilter/conntrack_resize.sh | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/testing/selftests/net/netfilter/conntrack_resize.sh b/tools/testing/selftests/net/netfilter/conntrack_resize.sh
index 615fe3c6f405..51564092cec4 100755
--- a/tools/testing/selftests/net/netfilter/conntrack_resize.sh
+++ b/tools/testing/selftests/net/netfilter/conntrack_resize.sh
@@ -22,7 +22,7 @@ insert_count=2000
modprobe -q nf_conntrack
if ! sysctl -q net.netfilter.nf_conntrack_max >/dev/null;then
echo "SKIP: conntrack sysctls not available"
- exit $KSFT_SKIP
+ exit $ksft_skip
fi
init_net_max=$(sysctl -n net.netfilter.nf_conntrack_max) || exit 1
--
2.43.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH net] selftests: netfilter: conntrack_resize.sh: fix skip exit code
2026-07-05 20:42 ` [PATCH net] selftests: netfilter: conntrack_resize.sh: fix skip exit code Dharmik Parmar
@ 2026-07-06 6:53 ` Florian Westphal
0 siblings, 0 replies; 2+ messages in thread
From: Florian Westphal @ 2026-07-06 6:53 UTC (permalink / raw)
To: Dharmik Parmar; +Cc: netdev
Dharmik Parmar <dharmikparmar2004@yahoo.com> wrote:
> When conntrack sysctls are unavailable, the test prints SKIP but exits
> with $KSFT_SKIP. lib.sh defines ksft_skip instead, so the kselftest
> runner did not see a proper skip.
Acked-by: Florian Westphal <fw@strlen.de>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2026-07-06 6:54 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20260705204252.630729-1-dharmikparmar2004.ref@yahoo.com>
2026-07-05 20:42 ` [PATCH net] selftests: netfilter: conntrack_resize.sh: fix skip exit code Dharmik Parmar
2026-07-06 6:53 ` Florian Westphal
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox