* [PATCH net-next] ice: rephrase LLDP filter fallback message
@ 2026-07-17 8:44 Thomas Bogendoerfer
2026-07-23 9:21 ` [Intel-wired-lan] " Loktionov, Aleksandr
2026-08-05 18:31 ` Arland, ArpanaX
0 siblings, 2 replies; 3+ messages in thread
From: Thomas Bogendoerfer @ 2026-07-17 8:44 UTC (permalink / raw)
To: Tony Nguyen, Przemek Kitszel, Andrew Lunn, David S. Miller,
Eric Dumazet, Jakub Kicinski, Paolo Abeni, intel-wired-lan,
netdev, linux-kernel
Seeing an error message in a logfile triggers scripts/admins thinking of
problems. The LLDP fallback message itself is not an error, it just
indicates it's using a different filter mechanism. So rephrase to a
less "scary" message.
Signed-off-by: Thomas Bogendoerfer <tbogendoerfer@suse.de>
---
drivers/net/ethernet/intel/ice/ice_lib.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/intel/ice/ice_lib.c b/drivers/net/ethernet/intel/ice/ice_lib.c
index 8cdc4fda89e9..59341b5a0c05 100644
--- a/drivers/net/ethernet/intel/ice/ice_lib.c
+++ b/drivers/net/ethernet/intel/ice/ice_lib.c
@@ -2097,7 +2097,7 @@ void ice_vsi_cfg_sw_lldp(struct ice_vsi *vsi, bool tx, bool create)
goto report;
dev_info(dev,
- "Failed to add generic LLDP Rx filter on VSI %i error: %d, falling back to specialized AQ control\n",
+ "Using generic LLDP Rx filter on VSI %i is not possible (%d), falling back to specialized AQ control\n",
vsi->vsi_num, status);
}
--
2.51.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* RE: [Intel-wired-lan] [PATCH net-next] ice: rephrase LLDP filter fallback message
2026-07-17 8:44 [PATCH net-next] ice: rephrase LLDP filter fallback message Thomas Bogendoerfer
@ 2026-07-23 9:21 ` Loktionov, Aleksandr
2026-08-05 18:31 ` Arland, ArpanaX
1 sibling, 0 replies; 3+ messages in thread
From: Loktionov, Aleksandr @ 2026-07-23 9:21 UTC (permalink / raw)
To: Thomas Bogendoerfer, Nguyen, Anthony L, Kitszel, Przemyslaw,
Andrew Lunn, David S. Miller, Eric Dumazet, Jakub Kicinski,
Paolo Abeni, intel-wired-lan@lists.osuosl.org,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
> -----Original Message-----
> From: Intel-wired-lan <intel-wired-lan-bounces@osuosl.org> On Behalf
> Of Thomas Bogendoerfer
> Sent: Friday, July 17, 2026 10:45 AM
> To: Nguyen, Anthony L <anthony.l.nguyen@intel.com>; Kitszel,
> Przemyslaw <przemyslaw.kitszel@intel.com>; Andrew Lunn
> <andrew+netdev@lunn.ch>; David S. Miller <davem@davemloft.net>; Eric
> Dumazet <edumazet@google.com>; Jakub Kicinski <kuba@kernel.org>; Paolo
> Abeni <pabeni@redhat.com>; intel-wired-lan@lists.osuosl.org;
> netdev@vger.kernel.org; linux-kernel@vger.kernel.org
> Subject: [Intel-wired-lan] [PATCH net-next] ice: rephrase LLDP filter
> fallback message
>
> Seeing an error message in a logfile triggers scripts/admins thinking
> of problems. The LLDP fallback message itself is not an error, it just
> indicates it's using a different filter mechanism. So rephrase to a
> less "scary" message.
>
> Signed-off-by: Thomas Bogendoerfer <tbogendoerfer@suse.de>
> ---
> drivers/net/ethernet/intel/ice/ice_lib.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/ethernet/intel/ice/ice_lib.c
> b/drivers/net/ethernet/intel/ice/ice_lib.c
> index 8cdc4fda89e9..59341b5a0c05 100644
> --- a/drivers/net/ethernet/intel/ice/ice_lib.c
> +++ b/drivers/net/ethernet/intel/ice/ice_lib.c
> @@ -2097,7 +2097,7 @@ void ice_vsi_cfg_sw_lldp(struct ice_vsi *vsi,
> bool tx, bool create)
> goto report;
>
> dev_info(dev,
> - "Failed to add generic LLDP Rx filter on
> VSI %i error: %d, falling back to specialized AQ control\n",
> + "Using generic LLDP Rx filter on VSI %i is
> not possible (%d),
> +falling back to specialized AQ control\n",
> vsi->vsi_num, status);
> }
>
> --
> 2.51.0
Reviewed-by: Aleksandr Loktionov <aleksandr.loktionov@intel.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* RE: [Intel-wired-lan] [PATCH net-next] ice: rephrase LLDP filter fallback message
2026-07-17 8:44 [PATCH net-next] ice: rephrase LLDP filter fallback message Thomas Bogendoerfer
2026-07-23 9:21 ` [Intel-wired-lan] " Loktionov, Aleksandr
@ 2026-08-05 18:31 ` Arland, ArpanaX
1 sibling, 0 replies; 3+ messages in thread
From: Arland, ArpanaX @ 2026-08-05 18:31 UTC (permalink / raw)
To: Thomas Bogendoerfer, Nguyen, Anthony L, Kitszel, Przemyslaw,
Andrew Lunn, David S. Miller, Eric Dumazet, Jakub Kicinski,
Paolo Abeni, intel-wired-lan@lists.osuosl.org,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
> -----Original Message-----
> From: Intel-wired-lan <intel-wired-lan-bounces@osuosl.org> On Behalf Of Thomas Bogendoerfer
> Sent: Friday, July 17, 2026 2:15 PM
> To: Nguyen, Anthony L <anthony.l.nguyen@intel.com>; Kitszel, Przemyslaw <przemyslaw.kitszel@intel.com>; Andrew Lunn <andrew+netdev@lunn.ch>; David S. Miller <davem@davemloft.net>; Eric Dumazet <edumazet@google.com>; Jakub Kicinski <kuba@kernel.org>; Paolo Abeni <pabeni@redhat.com>; intel-wired-lan@lists.osuosl.org; netdev@vger.kernel.org; linux-kernel@vger.kernel.org
> Subject: [Intel-wired-lan] [PATCH net-next] ice: rephrase LLDP filter fallback message
>
> Seeing an error message in a logfile triggers scripts/admins thinking of problems. The LLDP fallback message itself is not an error, it just indicates it's using a different filter mechanism. So rephrase to a less "scary" message.
>
> Signed-off-by: Thomas Bogendoerfer <tbogendoerfer@suse.de>
> ---
> drivers/net/ethernet/intel/ice/ice_lib.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
Tested-by: Arpana Arland <arpanax.arland@intel.com> (A Contingent worker at Intel)
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2026-08-05 18:31 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-07-17 8:44 [PATCH net-next] ice: rephrase LLDP filter fallback message Thomas Bogendoerfer
2026-07-23 9:21 ` [Intel-wired-lan] " Loktionov, Aleksandr
2026-08-05 18:31 ` Arland, ArpanaX
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox