* [PATCH v1] pppoe: Add PPP interface name to /proc/net/pppoe output
@ 2026-07-28 7:04 Pavan Kumar
0 siblings, 0 replies; 2+ messages in thread
From: Pavan Kumar @ 2026-07-28 7:04 UTC (permalink / raw)
To: andrew+netdev, davem, edumazet, kuba, pabeni
Cc: qingfang.deng, kees, ericwouds, manizada, nbd, netdev,
linux-kernel, Pavan Kumar
The pppoe_seq_show() function displays session ID, remote MAC address,
and the underlying Ethernet device, but omits the associated PPP
interface name. This makes it difficult to correlate PPPoE sessions
with their respective pppX interfaces.
Retrieve the interface name using ppp_dev_name() and append it as a
new "PPP-Device" column in the /proc/net/pppoe output.
Signed-off-by: Pavan Kumar <pavan.m@oss.qualcomm.com>
---
drivers/net/ppp/pppoe.c | 8 +++++---
1 file changed, 5 insertions(+), 3 deletions(-)
diff --git a/drivers/net/ppp/pppoe.c b/drivers/net/ppp/pppoe.c
index 6874a1a8edaf..cb31f5db43e8 100644
--- a/drivers/net/ppp/pppoe.c
+++ b/drivers/net/ppp/pppoe.c
@@ -963,17 +963,19 @@ static int pppoe_seq_show(struct seq_file *seq, void *v)
{
struct pppox_sock *po;
char *dev_name;
+ char *ppp_name;
if (v == SEQ_START_TOKEN) {
- seq_puts(seq, "Id Address Device\n");
+ seq_puts(seq, "Id Address Device PPP-Device\n");
goto out;
}
po = v;
dev_name = po->pppoe_pa.dev;
+ ppp_name = ppp_dev_name(&po->chan);
- seq_printf(seq, "%08X %pM %8s\n",
- po->pppoe_pa.sid, po->pppoe_pa.remote, dev_name);
+ seq_printf(seq, "%08X %pM %8s %10s\n",
+ po->pppoe_pa.sid, po->pppoe_pa.remote, dev_name, ppp_name ? ppp_name : "");
out:
return 0;
}
^ permalink raw reply related [flat|nested] 2+ messages in thread
* [PATCH v1] pppoe: Add PPP interface name to /proc/net/pppoe output
@ 2026-07-28 7:06 Pavan Kumar
0 siblings, 0 replies; 2+ messages in thread
From: Pavan Kumar @ 2026-07-28 7:06 UTC (permalink / raw)
To: andrew+netdev, davem, edumazet, kuba, pabeni
Cc: qingfang.deng, kees, ericwouds, manizada, nbd, netdev,
linux-kernel, Pavan Kumar
The pppoe_seq_show() function displays session ID, remote MAC address,
and the underlying Ethernet device, but omits the associated PPP
interface name. This makes it difficult to correlate PPPoE sessions
with their respective pppX interfaces.
Retrieve the interface name using ppp_dev_name() and append it as a
new "PPP-Device" column in the /proc/net/pppoe output.
Signed-off-by: Pavan Kumar <pavan.m@oss.qualcomm.com>
---
drivers/net/ppp/pppoe.c | 8 +++++---
1 file changed, 5 insertions(+), 3 deletions(-)
diff --git a/drivers/net/ppp/pppoe.c b/drivers/net/ppp/pppoe.c
index 6874a1a8edaf..cb31f5db43e8 100644
--- a/drivers/net/ppp/pppoe.c
+++ b/drivers/net/ppp/pppoe.c
@@ -963,17 +963,19 @@ static int pppoe_seq_show(struct seq_file *seq, void *v)
{
struct pppox_sock *po;
char *dev_name;
+ char *ppp_name;
if (v == SEQ_START_TOKEN) {
- seq_puts(seq, "Id Address Device\n");
+ seq_puts(seq, "Id Address Device PPP-Device\n");
goto out;
}
po = v;
dev_name = po->pppoe_pa.dev;
+ ppp_name = ppp_dev_name(&po->chan);
- seq_printf(seq, "%08X %pM %8s\n",
- po->pppoe_pa.sid, po->pppoe_pa.remote, dev_name);
+ seq_printf(seq, "%08X %pM %8s %10s\n",
+ po->pppoe_pa.sid, po->pppoe_pa.remote, dev_name, ppp_name ? ppp_name : "");
out:
return 0;
}
^ permalink raw reply related [flat|nested] 2+ messages in thread
end of thread, other threads:[~2026-07-28 7:11 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-07-28 7:04 [PATCH v1] pppoe: Add PPP interface name to /proc/net/pppoe output Pavan Kumar
-- strict thread matches above, loose matches on Subject: below --
2026-07-28 7:06 Pavan Kumar
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox