From: Artem Lytkin <iprintercanon@gmail.com>
To: Jacob Keller <jacob.e.keller@intel.com>,
Jakub Kicinski <kuba@kernel.org>
Cc: netdev@vger.kernel.org, davem@davemloft.net, edumazet@google.com,
pabeni@redhat.com, horms@kernel.org, chrisw@sous-sol.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH net] rtnetlink: truncate IFLA_VFINFO_LIST instead of overflowing its length
Date: Thu, 30 Jul 2026 20:12:13 +0300 [thread overview]
Message-ID: <20260730171214.76860-1-iprintercanon@gmail.com> (raw)
In-Reply-To: <0773587b-b355-46cb-9f4a-f3eecf8e01ad@intel.com>
On Thu, Jul 30, 2026 at 02:17:35AM -0700, Jacob Keller wrote:
> I'd argue this is a "fix", as we were previously doing objectively the
> wrong thing by randomly truncating the message at arbitrary points.
Our mails crossed. v2 went out ten minutes before yours, taking Jakub's
128 and 256, documenting them in the netlink spec and dropping the tag:
https://lore.kernel.org/netdev/20260730090700.65867-1-iprintercanon@gmail.com/
I have no strong view on who is right, but the tag decides more than
bookkeeping here. With it this goes to net and gets backported, so an ice
PF with 256 VFs stops producing a corrupt link dump on a stable kernel;
without it that waits for the merge window. Against that, nothing
regressed: the interface has been able to write a length it cannot
represent since 2010, which I take to be Jakub's point.
Happy to restore the tag and resend against net if Jakub is persuaded.
Artem
prev parent reply other threads:[~2026-07-30 17:12 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-25 13:22 [PATCH net] rtnetlink: truncate IFLA_VFINFO_LIST instead of overflowing its length Artem Lytkin
2026-07-30 1:55 ` Jakub Kicinski
2026-07-30 9:07 ` [PATCH net-next v2] rtnetlink: cap IFLA_VFINFO_LIST at a documented number of VFs Artem Lytkin
2026-07-30 9:17 ` [PATCH net] rtnetlink: truncate IFLA_VFINFO_LIST instead of overflowing its length Jacob Keller
2026-07-30 17:12 ` Artem Lytkin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260730171214.76860-1-iprintercanon@gmail.com \
--to=iprintercanon@gmail.com \
--cc=chrisw@sous-sol.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=jacob.e.keller@intel.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox