From: Jakub Kicinski <kuba@kernel.org>
To: Willem de Bruijn <willemdebruijn.kernel@gmail.com>
Cc: Qihang <q.h.hack.winter@gmail.com>,
netdev@vger.kernel.org, daniel.zahka@gmail.com,
davem@davemloft.net, edumazet@google.com, pabeni@redhat.com,
horms@kernel.org, stable@vger.kernel.org
Subject: Re: [PATCH net v5 2/2] packet: use consistent hard_header_len in TX_RING send path
Date: Tue, 4 Aug 2026 16:43:24 -0700 [thread overview]
Message-ID: <20260804164324.49528d7c@kernel.org> (raw)
In-Reply-To: <willemdebruijn.kernel.ad7f187edf35@gmail.com>
On Mon, 03 Aug 2026 23:04:54 -0400 Willem de Bruijn wrote:
> If I read Gemini feedback correctly, all reports are about the current
> solution falling short of fixing the instance of this race condition
> with dev_hard_header(), which reads dev->hard_header_len directly.
> The patch indeed mentions this limitation.
To be clear -- prefer looking that the netdev-ai instance.
It cross reviews the feedback with different LLMs
> As well as the same issue with dev_validate_header(), which the commit
> does not list as limitation. But that one is only reached with variable
> length L2 protocols.
>
> Side note, in net-next I can probably remove header_ops.validate now
> that ax25 is gone, and with that all of dev_validate_header. No other
> variable length L2 protocol ever implemented that callback.
Let's do it.
next prev parent reply other threads:[~2026-08-04 23:43 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-30 8:29 [PATCH net v5 0/2] packet: use consistent hard_header_len in send paths Qihang
2026-07-30 8:29 ` [PATCH net v5 1/2] packet: use consistent hard_header_len in non-ring " Qihang
2026-07-30 8:29 ` [PATCH net v5 2/2] packet: use consistent hard_header_len in TX_RING send path Qihang
2026-07-30 9:22 ` Willem de Bruijn
2026-08-04 2:22 ` Jakub Kicinski
2026-08-04 3:04 ` Willem de Bruijn
2026-08-04 23:43 ` Jakub Kicinski [this message]
2026-08-04 9:00 ` [PATCH net v6 0/3] net: fix hard_header_len races in packet send paths Qihang
2026-08-04 9:00 ` [PATCH net v6 1/3] net: remove CAP_SYS_RAWIO zero-padding in dev_validate_header Qihang
2026-08-04 12:16 ` Willem de Bruijn
2026-08-04 23:44 ` Jakub Kicinski
2026-08-04 9:32 ` [PATCH net v6 2/3] packet: use consistent hard_header_len in non-ring send paths Qihang
2026-08-04 9:33 ` [PATCH net v6 3/3] packet: use consistent hard_header_len in TX_RING send path Qihang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260804164324.49528d7c@kernel.org \
--to=kuba@kernel.org \
--cc=daniel.zahka@gmail.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=q.h.hack.winter@gmail.com \
--cc=stable@vger.kernel.org \
--cc=willemdebruijn.kernel@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox