Netdev List
 help / color / mirror / Atom feed
From: Jakub Kicinski <kuba@kernel.org>
To: Birger Koblitz <mail@birger-koblitz.de>
Cc: Andrew Lunn <andrew+netdev@lunn.ch>,
	"David S. Miller" <davem@davemloft.net>,
	Eric Dumazet <edumazet@google.com>,
	Paolo Abeni <pabeni@redhat.com>,
	Russell King <linux@armlinux.org.uk>,
	Andrew Lunn <andrew@lunn.ch>,
	Heiner Kallweit <hkallweit1@gmail.com>,
	linux-usb@vger.kernel.org, netdev@vger.kernel.org,
	linux-kernel@vger.kernel.org, Jianhui Xu <neuromoments@gmail.com>
Subject: Re: [PATCH net-next v7 05/14] ax88179_178a: Add HW support for AX179A-based chips
Date: Mon, 17 Aug 2026 15:24:59 -0700	[thread overview]
Message-ID: <20260817152459.1714ba66@kernel.org> (raw)
In-Reply-To: <20260810-ax88179a-v7-5-da633191c129@birger-koblitz.de>

On Mon, 10 Aug 2026 14:33:30 +0200 Birger Koblitz wrote:
> This adds bindings and HW support for AX179A-based USB-Ethernet
> controllers. The AX179A-family of chips consists of the
> AX88279 (2.5GBit PHY)
> AX88179A/B (1GBit PHY, B variant has wider temperature range)
> AX772D/E (100Mbit PHY)
> 
> The controllers all have the same vendor and device ID
> (0x0b95, 0x1790) and are distinguished by their BCD device versions,
> which are
> 2.00 AX88179A/B
> 3.00 AX88772D/E
> 4.00 AX88279
> 
> For all chips, the driver calls the same ax88179a_bind() function
> and the chips are then distinguished by the chip version and
> BCD device ID. The AX179A-based chips all provide both a CDC-NCM
> compatible USB interface, and a proprietary vendor interface. By default,
> the proprietary vendor interface is not active and Linux will load the
> CDC-NCM driver to support the devices. If the ax88179_178a module is
> configured by the OS to have precedence over CDC-NCM, then this driver
> will switch the device to use the vendor interface, and the device will
> be controlled by the ax88179_178a driver when the device is probed again
> after an automatic reset by the device.

Two transiently unused functions here:

../drivers/net/usb/ax88179a_devices.c:397:13: warning: unused function 'ax88179a_mac_disable_tx_lpi' [-Wunused-function]
  397 | static void ax88179a_mac_disable_tx_lpi(struct phylink_config *config)
      |             ^~~~~~~~~~~~~~~~~~~~~~~~~~~
../drivers/net/usb/ax88179a_devices.c:404:12: warning: unused function 'ax88179a_mac_enable_tx_lpi' [-Wunused-function]
  404 | static int ax88179a_mac_enable_tx_lpi(struct phylink_config *config, u32 timer, bool tx_clk_stop)
      |            ^~~~~~~~~~~~~~~~~~~~~~~~~~

This blocked more expensive stages of our CI from running on the series,
it needs to be fixed.
-- 
pw-bot: cr

  reply	other threads:[~2026-08-17 22:25 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-08-10 12:33 [PATCH net-next v7 00/14] ax88179_178a: Add support for AX88179A-based chips Birger Koblitz
2026-08-10 12:33 ` [PATCH net-next v7 01/14] phylink: Add phylink_mac_interrupt Birger Koblitz
2026-08-10 12:33 ` [PATCH net-next v7 02/14] ax88179_178a: Fix endianness of pause watermark register Birger Koblitz
2026-08-10 12:33 ` [PATCH net-next v7 03/14] ax88179_178a: Split driver into library and device specific code Birger Koblitz
2026-08-17 22:28   ` Jakub Kicinski
2026-08-10 12:33 ` [PATCH net-next v7 04/14] ax88179_178a: Add netdev2data() convenience function Birger Koblitz
2026-08-10 12:33 ` [PATCH net-next v7 05/14] ax88179_178a: Add HW support for AX179A-based chips Birger Koblitz
2026-08-17 22:24   ` Jakub Kicinski [this message]
2026-08-10 12:33 ` [PATCH net-next v7 06/14] ax88179_178a: Add EEE configuration support for AX88179A MACs Birger Koblitz
2026-08-10 12:33 ` [PATCH net-next v7 07/14] ax88179_178a: Add EEE configuration support for AX88179A PHYs Birger Koblitz
2026-08-10 12:33 ` [PATCH net-next v7 08/14] ax88179_178a: Add VLAN offload support for AX88179A Birger Koblitz
2026-08-10 12:33 ` [PATCH net-next v7 09/14] ax88179_178a: Add AX179A/AX279 multicast configuration Birger Koblitz
2026-08-10 12:33 ` [PATCH net-next v7 10/14] ax88179_178a: Add Suspend/resume support for AX88179A/772D/279 Birger Koblitz
2026-08-10 12:33 ` [PATCH net-next v7 11/14] ax88179_178a: Add ethtool get_drvinfo Birger Koblitz
2026-08-10 12:33 ` [PATCH net-next v7 12/14] ax88179_178a: Update driver name and information Birger Koblitz
2026-08-10 12:33 ` [PATCH net-next v7 13/14] ax88179_178a: Add support for AX88179A/772D/279 EEPROM access Birger Koblitz
2026-08-10 12:33 ` [PATCH net-next v7 14/14] ax88796b: Add support for AX88772D, AX88179A and AX88279 Birger Koblitz
2026-08-16  7:09 ` [PATCH v7 0/14] ax88179_178a: Add support for AX88179A-based chips Jianhui Xu
2026-08-16  7:43   ` Birger Koblitz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260817152459.1714ba66@kernel.org \
    --to=kuba@kernel.org \
    --cc=andrew+netdev@lunn.ch \
    --cc=andrew@lunn.ch \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=hkallweit1@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=linux@armlinux.org.uk \
    --cc=mail@birger-koblitz.de \
    --cc=netdev@vger.kernel.org \
    --cc=neuromoments@gmail.com \
    --cc=pabeni@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox