From: Marc Kleine-Budde <mkl@pengutronix.de>
To: netdev@vger.kernel.org
Cc: davem@davemloft.net, kuba@kernel.org, linux-can@vger.kernel.org,
kernel@pengutronix.de,
"Markus Schneider-Pargmann (The Capable Hub)" <msp@baylibre.com>,
"Uwe Kleine-König (The Capable Hub)"
<u.kleine-koenig@baylibre.com>,
"Vincent Mailhol" <mailhol@kernel.org>,
"Marc Kleine-Budde" <mkl@pengutronix.de>
Subject: [PATCH net-next 11/11] can: m_can: pci: Remove driver_data
Date: Tue, 18 Aug 2026 01:24:38 +0200 [thread overview]
Message-ID: <20260817233420.2068204-12-mkl@pengutronix.de> (raw)
In-Reply-To: <20260817233420.2068204-1-mkl@pengutronix.de>
From: "Markus Schneider-Pargmann (The Capable Hub)" <msp@baylibre.com>
driver_data is set to M_CAN_CLOCK_FREQ_EHL for all models. This change
was already five years ago, I don't expect any follow up models that
need to set a different frequency through the driver_data at this point.
Hardcode the M_CAN_CLOCK_FREQ_EHL. Once there are new models we can
evaluate what data needs to be in driver_data.
Acked-by: Uwe Kleine-König (The Capable Hub) <u.kleine-koenig@baylibre.com>
Signed-off-by: Markus Schneider-Pargmann (The Capable Hub) <msp@baylibre.com>
Reviewed-by: Vincent Mailhol <mailhol@kernel.org>
Link: https://patch.msgid.link/20260515-topic-mcan-pci-driverdata-v7-1-v2-1-e33e014ff328@baylibre.com
Signed-off-by: Marc Kleine-Budde <mkl@pengutronix.de>
---
drivers/net/can/m_can/m_can_pci.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/net/can/m_can/m_can_pci.c b/drivers/net/can/m_can/m_can_pci.c
index eb31ed1f9644..d11a7c88fc32 100644
--- a/drivers/net/can/m_can/m_can_pci.c
+++ b/drivers/net/can/m_can/m_can_pci.c
@@ -126,7 +126,7 @@ static int m_can_pci_probe(struct pci_dev *pci, const struct pci_device_id *id)
mcan_class->net->irq = pci_irq_vector(pci, 0);
mcan_class->pm_clock_support = 1;
mcan_class->pm_wake_source = 0;
- mcan_class->can.clock.freq = id->driver_data;
+ mcan_class->can.clock.freq = M_CAN_CLOCK_FREQ_EHL;
mcan_class->irq_edge_triggered = true;
mcan_class->ops = &m_can_pci_ops;
@@ -183,8 +183,8 @@ static SIMPLE_DEV_PM_OPS(m_can_pci_pm_ops,
m_can_pci_suspend, m_can_pci_resume);
static const struct pci_device_id m_can_pci_id_table[] = {
- { PCI_VDEVICE(INTEL, 0x4bc1), M_CAN_CLOCK_FREQ_EHL, },
- { PCI_VDEVICE(INTEL, 0x4bc2), M_CAN_CLOCK_FREQ_EHL, },
+ { PCI_VDEVICE(INTEL, 0x4bc1) },
+ { PCI_VDEVICE(INTEL, 0x4bc2) },
{ } /* Terminating Entry */
};
MODULE_DEVICE_TABLE(pci, m_can_pci_id_table);
--
2.53.0
prev parent reply other threads:[~2026-08-17 23:34 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-17 23:24 [PATCH net-next 0/11] pull-request: can-next 2026-08-18 Marc Kleine-Budde
2026-08-17 23:24 ` [PATCH net-next 01/11] can: tcan4x5x: put tcan into sleep when removing driver Marc Kleine-Budde
2026-08-18 18:37 ` patchwork-bot+netdevbpf
2026-08-18 18:41 ` patchwork-bot+netdevbpf
2026-08-17 23:24 ` [PATCH net-next 02/11] dt-bindings: can: rockchip: add rk3588 CAN-FD compatible Marc Kleine-Budde
2026-08-17 23:24 ` [PATCH net-next 03/11] can: rockchip: add RK3588 CAN support Marc Kleine-Budde
2026-08-17 23:24 ` [PATCH net-next 04/11] docs: ctucanfd: fix swapped colors in legend for TX buffer FSM of CTU CAN FD Marc Kleine-Budde
2026-08-17 23:24 ` [PATCH net-next 05/11] can: vxcan: support per-netns device unregistration Marc Kleine-Budde
2026-08-17 23:24 ` [PATCH net-next 06/11] MAINTAINERS: Replace maintainer for Xilinx CAN driver Marc Kleine-Budde
2026-08-17 23:24 ` [PATCH net-next 07/11] dt-bindings: net: can: Convert TI HECC to DT schema Marc Kleine-Budde
2026-08-17 23:24 ` [PATCH net-next 08/11] dt-bindings: can: xilinx_can: Document phys property Marc Kleine-Budde
2026-08-17 23:24 ` [PATCH net-next 09/11] can: m_can: Use of_property_present() for wakeup-source Marc Kleine-Budde
2026-08-17 23:24 ` [PATCH net-next 10/11] drivers: gs_usb: gs_usb_probe(): fix typo in error message Marc Kleine-Budde
2026-08-17 23:24 ` Marc Kleine-Budde [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260817233420.2068204-12-mkl@pengutronix.de \
--to=mkl@pengutronix.de \
--cc=davem@davemloft.net \
--cc=kernel@pengutronix.de \
--cc=kuba@kernel.org \
--cc=linux-can@vger.kernel.org \
--cc=mailhol@kernel.org \
--cc=msp@baylibre.com \
--cc=netdev@vger.kernel.org \
--cc=u.kleine-koenig@baylibre.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox