From: Marc Kleine-Budde <mkl@pengutronix.de>
To: netdev@vger.kernel.org
Cc: davem@davemloft.net, kuba@kernel.org, linux-can@vger.kernel.org,
kernel@pengutronix.de, Sean Nyekjaer <sean@geanix.com>,
Marc Kleine-Budde <mkl@pengutronix.de>
Subject: [PATCH net-next 01/11] can: tcan4x5x: put tcan into sleep when removing driver
Date: Tue, 18 Aug 2026 01:24:28 +0200 [thread overview]
Message-ID: <20260817233420.2068204-2-mkl@pengutronix.de> (raw)
In-Reply-To: <20260817233420.2068204-1-mkl@pengutronix.de>
From: Sean Nyekjaer <sean@geanix.com>
Put the tcan4x5x transceiver into sleep mode when the driver is
removed, instead of leaving it in its current operating mode.
This reduces power consumption(3mA@12V) once the driver is
no longer bound to the device.
Signed-off-by: Sean Nyekjaer <sean@geanix.com>
Link: https://patch.msgid.link/20260805110708.3220251-1-sean@geanix.com
[mkl: tcan4x5x_power_enable(): reduce scope of ret]
Signed-off-by: Marc Kleine-Budde <mkl@pengutronix.de>
---
drivers/net/can/m_can/tcan4x5x-core.c | 31 +++++++++++++++++++++++----
1 file changed, 27 insertions(+), 4 deletions(-)
diff --git a/drivers/net/can/m_can/tcan4x5x-core.c b/drivers/net/can/m_can/tcan4x5x-core.c
index 31cc9d0abd45..a5b8829aa519 100644
--- a/drivers/net/can/m_can/tcan4x5x-core.c
+++ b/drivers/net/can/m_can/tcan4x5x-core.c
@@ -211,8 +211,31 @@ static int tcan4x5x_write_fifo(struct m_can_classdev *cdev,
return regmap_bulk_write(priv->regmap, TCAN4X5X_MRAM_START + addr_offset, val, val_count);
}
-static int tcan4x5x_power_enable(struct regulator *reg, int enable)
+static int tcan4x5x_power_enable(struct tcan4x5x_priv *priv, int enable)
{
+ struct regulator *reg = priv->power;
+
+ /*
+ * Put the device into sleep mode if the RST pin is available,
+ * since a wake-up event, RST pin toggle, or power cycle are the only
+ * ways to exit sleep mode.
+ * Redundant if the regulator is exclusive to this device, but that
+ * can't be determined here.
+ *
+ * Datasheet: TCAN4550, section "8.4.3 Sleep Mode"
+ * https://www.ti.com/lit/gpn/tcan4550
+ */
+ if (priv->reset_gpio && !enable) {
+ int ret;
+
+ ret = regmap_update_bits(priv->regmap, TCAN4X5X_CONFIG,
+ TCAN4X5X_MODE_SEL_MASK,
+ TCAN4X5X_MODE_SLEEP);
+ if (ret)
+ dev_err(&priv->spi->dev, "Setting sleep mode failed %pe\n",
+ ERR_PTR(ret));
+ }
+
if (IS_ERR_OR_NULL(reg))
return 0;
@@ -476,7 +499,7 @@ static int tcan4x5x_can_probe(struct spi_device *spi)
goto out_m_can_class_free_dev;
}
- ret = tcan4x5x_power_enable(priv->power, 1);
+ ret = tcan4x5x_power_enable(priv, 1);
if (ret) {
dev_err(&spi->dev, "Enabling regulator failed %pe\n",
ERR_PTR(ret));
@@ -531,7 +554,7 @@ static int tcan4x5x_can_probe(struct spi_device *spi)
return 0;
out_power:
- tcan4x5x_power_enable(priv->power, 0);
+ tcan4x5x_power_enable(priv, 0);
out_m_can_class_free_dev:
m_can_class_free_dev(mcan_class->net);
return ret;
@@ -543,7 +566,7 @@ static void tcan4x5x_can_remove(struct spi_device *spi)
m_can_class_unregister(&priv->cdev);
- tcan4x5x_power_enable(priv->power, 0);
+ tcan4x5x_power_enable(priv, 0);
m_can_class_free_dev(priv->cdev.net);
}
base-commit: e6a5d573d24cd375e09d24f136523cb3cc85c9d3
--
2.53.0
next prev parent reply other threads:[~2026-08-17 23:34 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-17 23:24 [PATCH net-next 0/11] pull-request: can-next 2026-08-18 Marc Kleine-Budde
2026-08-17 23:24 ` Marc Kleine-Budde [this message]
2026-08-18 18:37 ` [PATCH net-next 01/11] can: tcan4x5x: put tcan into sleep when removing driver patchwork-bot+netdevbpf
2026-08-18 18:41 ` patchwork-bot+netdevbpf
2026-08-17 23:24 ` [PATCH net-next 02/11] dt-bindings: can: rockchip: add rk3588 CAN-FD compatible Marc Kleine-Budde
2026-08-17 23:24 ` [PATCH net-next 03/11] can: rockchip: add RK3588 CAN support Marc Kleine-Budde
2026-08-17 23:24 ` [PATCH net-next 04/11] docs: ctucanfd: fix swapped colors in legend for TX buffer FSM of CTU CAN FD Marc Kleine-Budde
2026-08-17 23:24 ` [PATCH net-next 05/11] can: vxcan: support per-netns device unregistration Marc Kleine-Budde
2026-08-17 23:24 ` [PATCH net-next 06/11] MAINTAINERS: Replace maintainer for Xilinx CAN driver Marc Kleine-Budde
2026-08-17 23:24 ` [PATCH net-next 07/11] dt-bindings: net: can: Convert TI HECC to DT schema Marc Kleine-Budde
2026-08-17 23:24 ` [PATCH net-next 08/11] dt-bindings: can: xilinx_can: Document phys property Marc Kleine-Budde
2026-08-17 23:24 ` [PATCH net-next 09/11] can: m_can: Use of_property_present() for wakeup-source Marc Kleine-Budde
2026-08-17 23:24 ` [PATCH net-next 10/11] drivers: gs_usb: gs_usb_probe(): fix typo in error message Marc Kleine-Budde
2026-08-17 23:24 ` [PATCH net-next 11/11] can: m_can: pci: Remove driver_data Marc Kleine-Budde
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260817233420.2068204-2-mkl@pengutronix.de \
--to=mkl@pengutronix.de \
--cc=davem@davemloft.net \
--cc=kernel@pengutronix.de \
--cc=kuba@kernel.org \
--cc=linux-can@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=sean@geanix.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox