Netdev List
 help / color / mirror / Atom feed
From: kernel test robot <lkp@intel.com>
To: Eric Dumazet <edumazet@google.com>,
	"David S . Miller" <davem@davemloft.net>,
	Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>
Cc: oe-kbuild-all@lists.linux.dev, Simon Horman <horms@kernel.org>,
	netdev@vger.kernel.org, eric.dumazet@gmail.com,
	Eric Dumazet <edumazet@google.com>,
	syzbot+d6fa74e3f19d6ee01e3a@syzkaller.appspotmail.com,
	James Chapman <jchapman@katalix.com>,
	Guillaume Nault <gnault@redhat.com>
Subject: Re: [PATCH v2 net] l2tp: fix tunnel and session refcount leak on seq_file release
Date: Thu, 20 Aug 2026 16:12:18 +0800	[thread overview]
Message-ID: <202608201604.4Zj72hcA-lkp@intel.com> (raw)
In-Reply-To: <20260810141125.1176545-1-edumazet@google.com>

Hi Eric,

kernel test robot noticed the following build errors:

[auto build test ERROR on horms-ipvs/master]
[cannot apply to net/main net-next/main linus/master v7.2 next-20260819]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Eric-Dumazet/l2tp-fix-tunnel-and-session-refcount-leak-on-seq_file-release/20260810-141125
base:   https://git.kernel.org/pub/scm/linux/kernel/git/horms/ipvs.git master
patch link:    https://lore.kernel.org/r/20260810141125.1176545-1-edumazet%40google.com
patch subject: [PATCH v2 net] l2tp: fix tunnel and session refcount leak on seq_file release
config: powerpc-allmodconfig (https://download.01.org/0day-ci/archive/20260820/202608201604.4Zj72hcA-lkp@intel.com/config)
compiler: powerpc64-linux-gcc (GCC) 16.1.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20260820/202608201604.4Zj72hcA-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202608201604.4Zj72hcA-lkp@intel.com/

All errors (new ones prefixed by >>):

   net/l2tp/l2tp_ppp.c: In function 'pppol2tp_proc_release':
>> net/l2tp/l2tp_ppp.c:1641:17: error: implicit declaration of function 'l2tp_session_put'; did you mean 'l2tp_session_get'? [-Wimplicit-function-declaration]
    1641 |                 l2tp_session_put(pd->session);
         |                 ^~~~~~~~~~~~~~~~
         |                 l2tp_session_get
>> net/l2tp/l2tp_ppp.c:1643:17: error: implicit declaration of function 'l2tp_tunnel_put'; did you mean 'l2tp_tunnel_get'? [-Wimplicit-function-declaration]
    1643 |                 l2tp_tunnel_put(pd->tunnel);
         |                 ^~~~~~~~~~~~~~~
         |                 l2tp_tunnel_get
--
   net/l2tp/l2tp_debugfs.c: In function 'l2tp_dfs_seq_release':
>> net/l2tp/l2tp_debugfs.c:311:17: error: implicit declaration of function 'l2tp_session_put'; did you mean 'l2tp_session_get'? [-Wimplicit-function-declaration]
     311 |                 l2tp_session_put(pd->session);
         |                 ^~~~~~~~~~~~~~~~
         |                 l2tp_session_get
>> net/l2tp/l2tp_debugfs.c:313:17: error: implicit declaration of function 'l2tp_tunnel_put'; did you mean 'l2tp_tunnel_get'? [-Wimplicit-function-declaration]
     313 |                 l2tp_tunnel_put(pd->tunnel);
         |                 ^~~~~~~~~~~~~~~
         |                 l2tp_tunnel_get


vim +1641 net/l2tp/l2tp_ppp.c

  1634	
  1635	static int pppol2tp_proc_release(struct inode *inode, struct file *file)
  1636	{
  1637		struct seq_file *seq = file->private_data;
  1638		struct pppol2tp_seq_data *pd = seq->private;
  1639	
  1640		if (pd->session)
> 1641			l2tp_session_put(pd->session);
  1642		if (pd->tunnel)
> 1643			l2tp_tunnel_put(pd->tunnel);
  1644	

--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki

  parent reply	other threads:[~2026-08-20  8:13 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-08-10 14:11 [PATCH v2 net] l2tp: fix tunnel and session refcount leak on seq_file release Eric Dumazet
2026-08-11 10:20 ` Paolo Abeni
2026-08-11 10:59   ` Eric Dumazet
2026-08-20  8:12 ` kernel test robot [this message]
2026-08-20  9:19   ` Eric Dumazet
2026-08-20  9:44     ` Philip Li

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=202608201604.4Zj72hcA-lkp@intel.com \
    --to=lkp@intel.com \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=eric.dumazet@gmail.com \
    --cc=gnault@redhat.com \
    --cc=horms@kernel.org \
    --cc=jchapman@katalix.com \
    --cc=kuba@kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=oe-kbuild-all@lists.linux.dev \
    --cc=pabeni@redhat.com \
    --cc=syzbot+d6fa74e3f19d6ee01e3a@syzkaller.appspotmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox