Netdev List
 help / color / mirror / Atom feed
From: Ali Rouhi <arouhi@sitime.com>
To: "ivecera@redhat.com" <ivecera@redhat.com>
Cc: "jiri@resnulli.us" <jiri@resnulli.us>,
	"vadim.fedorenko@linux.dev" <vadim.fedorenko@linux.dev>,
	"arkadiusz.kubalewski@intel.com" <arkadiusz.kubalewski@intel.com>,
	"kuba@kernel.org" <kuba@kernel.org>,
	"robh@kernel.org" <robh@kernel.org>,
	"krzk+dt@kernel.org" <krzk+dt@kernel.org>,
	"conor+dt@kernel.org" <conor+dt@kernel.org>,
	"cjubran@nvidia.com" <cjubran@nvidia.com>,
	"Oleg.Zadorozhnyi@devoxsoftware.com"
	<Oleg.Zadorozhnyi@devoxsoftware.com>,
	"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
	"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH net-next v7 3/3] dpll: add SiTime SiT9531x DPLL clock driver
Date: Fri, 21 Aug 2026 01:06:09 +0000	[thread overview]
Message-ID: <20260821010608.96264-1-arouhi@sitime.com> (raw)
In-Reply-To: <dcbd4d98-8d22-405f-9ed0-b6e97369098c@redhat.com>

On 20/08/2026 19:27, Ivan Vecera wrote:
> +1 ... Reviewing single patch with the whole driver is really annoying.
> Next time, please split the driver into logical parts (e.g. low-level
> ops, core ops, features one-by one)...

Understood, and agreed. v8 comes as thirteen driver patches split that
way; the full breakdown is in my reply to Vadim.

> Due to the fact that the source is very similar with zl3073x, please
> look at its git history to see how it was submitted in past.

Done - thank you, that was the useful reference. We took the first
series as the model: basic support, the invariants fetched during
probe, DPLL types and pin properties from firmware, device and pin
registration, then one capability per patch. Ours is split the same way
and in the same order.

That is about how the series is split, not how the code is arranged.
Our file layout stays as it is for now. Say if you would rather see the
files broken up as well and we will do that too.

> ...and please do not forget to include me in the CC list ;-)

Added, from v8 on.

Thanks,
Ali

  reply	other threads:[~2026-08-21  1:15 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-08-15 22:19 [PATCH net-next v7 0/3] dpll: add SiTime SiT9531x DPLL clock driver Ali Rouhi
2026-08-15 22:19 ` [PATCH net-next v7 2/3] dt-bindings: dpll: add SiTime SiT95316 clock generator Ali Rouhi
2026-08-15 22:19 ` [PATCH net-next v7 1/3] dt-bindings: vendor-prefixes: add SiTime Corporation Ali Rouhi
2026-08-15 22:19 ` [PATCH net-next v7 3/3] dpll: add SiTime SiT9531x DPLL clock driver Ali Rouhi
2026-08-18 17:06   ` Jakub Kicinski
2026-08-19 21:16   ` Vadim Fedorenko
2026-08-20 17:27     ` Ivan Vecera
2026-08-21  1:06       ` Ali Rouhi [this message]
2026-08-21  1:05     ` Ali Rouhi
2026-08-20 17:57   ` Ivan Vecera
2026-08-21  1:06     ` Ali Rouhi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260821010608.96264-1-arouhi@sitime.com \
    --to=arouhi@sitime.com \
    --cc=Oleg.Zadorozhnyi@devoxsoftware.com \
    --cc=arkadiusz.kubalewski@intel.com \
    --cc=cjubran@nvidia.com \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=ivecera@redhat.com \
    --cc=jiri@resnulli.us \
    --cc=krzk+dt@kernel.org \
    --cc=kuba@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=robh@kernel.org \
    --cc=vadim.fedorenko@linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox