* [PATCH] bnxt_en: Fix call to hardware monitoring event handler
@ 2026-08-21 4:45 Guenter Roeck
2026-08-21 5:11 ` Kalesh Anakkur Purayil
0 siblings, 1 reply; 2+ messages in thread
From: Guenter Roeck @ 2026-08-21 4:45 UTC (permalink / raw)
To: Michael Chan; +Cc: Pavan Chebbi, netdev, linux-kernel, Guenter Roeck, Kalesh AP
The first parameter of hwmon_notify_event() is supposed to be the hardware
monitoring device. The bnxt driver calls it with the platform device as
first parameter instead. This API break results in undefined behavior and
may result in a crash.
Pass the hardware monitoring device as parameter instead to fix the
problem.
Fixes: a19b4801457b0 ("bnxt_en: Event handler for Thermal event")
Cc: Kalesh AP <kalesh-anakkur.purayil@broadcom.com>
Signed-off-by: Guenter Roeck <linux@roeck-us.net>
---
drivers/net/ethernet/broadcom/bnxt/bnxt_hwmon.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/broadcom/bnxt/bnxt_hwmon.c b/drivers/net/ethernet/broadcom/bnxt/bnxt_hwmon.c
index de3427c6c6aa..faed0cf726e1 100644
--- a/drivers/net/ethernet/broadcom/bnxt/bnxt_hwmon.c
+++ b/drivers/net/ethernet/broadcom/bnxt/bnxt_hwmon.c
@@ -40,7 +40,7 @@ void bnxt_hwmon_notify_event(struct bnxt *bp)
return;
}
- hwmon_notify_event(&bp->pdev->dev, hwmon_temp, attr, 0);
+ hwmon_notify_event(bp->hwmon_dev, hwmon_temp, attr, 0);
}
static int bnxt_hwrm_temp_query(struct bnxt *bp, u8 *temp)
--
2.45.2
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] bnxt_en: Fix call to hardware monitoring event handler
2026-08-21 4:45 [PATCH] bnxt_en: Fix call to hardware monitoring event handler Guenter Roeck
@ 2026-08-21 5:11 ` Kalesh Anakkur Purayil
0 siblings, 0 replies; 2+ messages in thread
From: Kalesh Anakkur Purayil @ 2026-08-21 5:11 UTC (permalink / raw)
To: Guenter Roeck; +Cc: Michael Chan, Pavan Chebbi, netdev, linux-kernel
[-- Attachment #1: Type: text/plain, Size: 727 bytes --]
On Fri, Aug 21, 2026 at 10:15 AM Guenter Roeck <linux@roeck-us.net> wrote:
>
> The first parameter of hwmon_notify_event() is supposed to be the hardware
> monitoring device. The bnxt driver calls it with the platform device as
> first parameter instead. This API break results in undefined behavior and
> may result in a crash.
>
> Pass the hardware monitoring device as parameter instead to fix the
> problem.
>
> Fixes: a19b4801457b0 ("bnxt_en: Event handler for Thermal event")
> Cc: Kalesh AP <kalesh-anakkur.purayil@broadcom.com>
> Signed-off-by: Guenter Roeck <linux@roeck-us.net>
Thank you for the fix, LGTM!
Reviewed-by: Kalesh AP <kalesh-anakkur.purayil@broadcom.com>
--
Regards,
Kalesh AP
[-- Attachment #2: S/MIME Cryptographic Signature --]
[-- Type: application/pkcs7-signature, Size: 5509 bytes --]
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2026-08-21 5:12 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-08-21 4:45 [PATCH] bnxt_en: Fix call to hardware monitoring event handler Guenter Roeck
2026-08-21 5:11 ` Kalesh Anakkur Purayil
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox