From: aslan.jnn@gmail.com
To: David Laight <david.laight.linux@gmail.com>
Cc: Raju Rangoju <Raju.Rangoju@amd.com>,
Prashanth Kumar K R <PrashanthKumar.K.R@amd.com>,
netdev@vger.kernel.org, Thomas.Lendacky@amd.com,
Simon Horman <horms@kernel.org>, Jakub Kicinski <kuba@kernel.org>
Subject: Re: [PATCH net v2] net: amd-xgbe: support receiving packets with bad FCS
Date: Fri, 28 Aug 2026 09:35:27 +1000 [thread overview]
Message-ID: <20260827233527.71620-1-aslan.jnn@gmail.com> (raw)
In-Reply-To: <20260821213646.7bbb94d6@pumpkin>
Hi David,
I agree with your first statement. I've just submitted the v3 of this patch
which removes the DCRCC unsetting on xgbe_disable_rx.
And thanks for your input for setting MAC_RCR non-atomically like that! I
didn't thought much about it before, to be honest. Will try handling that
on the next submission.
James
On Fri, Aug 21, 2026 at 9:36:46PM +0100, David Laight <david.laight.linux@gmail.com> wrote:
> On Wed, 19 Aug 2026 19:16:56 +1000
> James <aslan.jnn@gmail.com> wrote:
>
>
> You can delete the line in the disable function that turns it off.
>
> But, really, you should be setting the required MAC_RCR bits in a single
> write.
> Doing RMW sequences on the hardware registers for each bit is really wrong.
> You also need to start with a known value for all the bits, otherwise
> 'silly' things can happen is (say) some bios boot code set bits you don't
> otherwise change.
>
> David
next prev parent reply other threads:[~2026-08-27 23:36 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-12 9:16 [PATCH net] net: amd-xgbe: support receiving packets with bad FCS James
2026-08-14 10:09 ` Simon Horman
2026-08-19 2:36 ` James
2026-08-19 9:01 ` Simon Horman
2026-08-17 23:32 ` Jakub Kicinski
2026-08-19 6:31 ` James
2026-08-19 9:16 ` [PATCH net v2] " James
2026-08-21 10:39 ` Simon Horman
2026-08-27 23:43 ` aslan.jnn
2026-08-21 20:36 ` David Laight
2026-08-27 23:35 ` aslan.jnn [this message]
2026-08-28 7:48 ` David Laight
2026-08-19 11:43 ` [PATCH net] " David Laight
2026-08-20 0:38 ` James
2026-08-20 8:58 ` David Laight
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260827233527.71620-1-aslan.jnn@gmail.com \
--to=aslan.jnn@gmail.com \
--cc=PrashanthKumar.K.R@amd.com \
--cc=Raju.Rangoju@amd.com \
--cc=Thomas.Lendacky@amd.com \
--cc=david.laight.linux@gmail.com \
--cc=horms@kernel.org \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox