Re: [PATCH net v2] net: amd-xgbe: support receiving packets with bad FCS

[aslan.jnn@gmail.com]

Hi Simon,

Yes, I've missed a few things on my v2. I've taken your suggestions into
account on my v3 patch here:

https://lore.kernel.org/all/20260827232220.69907-1-aslan.jnn@gmail.com

I've included your suggestions there including setting my "From" config and
reinstantiating the `Fixes` line. Thanks a lot Simon for your guidance and
patience, for my first ever submission to Linux kernel! I highly appreciate
it!

  James

On Fri, Aug 21, 2026 at 11:39:24AM +0100, Simon Horman <horms@kernel.org> wrote:
> On Wed, Aug 19, 2026 at 07:16:56PM +1000, James wrote:
>
> Hi James,
>
> I think this warrants a fixes tag
> (no blank line between it and your signed-off-by line).
>
> Fixes: c5aa9e3b8156 ("amd-xgbe: Initial AMD 10GbE platform driver")
>
>
> net:amd-xgbe: discard rx packets with bad FCS
>
>
> I think you may have forgotten to update the patch description
> as per the suggestion made by David in his review of v1.
>
> 	net: amd-xgbe: discard rx packets with bad FCS
>
> And, some points on process:
>
> * Please post updated versions of patches
>   as separate threads rather than as respones to earlier versions.
>
> * Please make sure the author of the patch matches the signed off by line.
>   You can do this by updating the from address in the email. Or
>   if that is not possible add an extra From: line at exactly
>   the first line of the body of the email.
>
> Thanks!
>
> -- 
> pw-bot: changes-requested