* [PATCH net-next v2 1/3] netlink: specs: rt-link: update ipv6 devconf doc
2026-08-31 9:34 [PATCH net-next v2 0/3] netlink: specs: rt-link: ipv6 devconf updates Asbjørn Sloth Tønnesen
@ 2026-08-31 9:34 ` Asbjørn Sloth Tønnesen
2026-08-31 9:34 ` [PATCH net-next v2 2/3] netlink: specs: rt-link: add accept-ra-min-lft Asbjørn Sloth Tønnesen
` (2 subsequent siblings)
3 siblings, 0 replies; 8+ messages in thread
From: Asbjørn Sloth Tønnesen @ 2026-08-31 9:34 UTC (permalink / raw)
To: Donald Hunter, Jakub Kicinski
Cc: Asbjørn Sloth Tønnesen, David S . Miller, Eric Dumazet,
Paolo Abeni, Simon Horman, Felix Maurer, Danielle Ratson,
Fernando Fernandez Mancera, Gabriel Goller, Patrick Rohr, netdev,
linux-kernel
devconf is even odder than described in commit 720447bd0b24
("netlink: specs: rt-link: remove implicit structs from devconf"),
where both IPv4 and IPv6 are described in an identical way:
"u32 indexed by ipv?-devconf - 1 on output, on input it's a nest".
There are two issues with that line for IPv6:
1) The subtraction is an IPv4 specific quirk, to avoid having an unused
u32 at index 0, thus saving 4 bytes per net device being dumped:
- In include/uapi/linux/ip.h the IPV4_DEVCONF_* enum begins with
IPV4_DEVCONF_FORWARDING = 1, so the enum starts at 1, which is
the reason for the subtraction in the IPv4 variant.
- In include/uapi/linux/ipv6.h the DEVCONF_* enum begins with
DEVCONF_FORWARDING = 0, so subtraction would underflow.
- ipv6_store_devconf() in net/ipv6/addrconf.c also doesn't do the
subtraction in the output path.
2) Setting IPv6 devconf through Netlink is not yet supported, as
IFLA_INET6_CONF is not handled in inet6_set_link_af().
Reviewed-by: Fernando Fernandez Mancera <fmancera@suse.de>
Signed-off-by: Asbjørn Sloth Tønnesen <ast@fiberby.net>
---
Documentation/netlink/specs/rt-link.yaml | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/Documentation/netlink/specs/rt-link.yaml b/Documentation/netlink/specs/rt-link.yaml
index b80c2ac3ac31..00c915031efd 100644
--- a/Documentation/netlink/specs/rt-link.yaml
+++ b/Documentation/netlink/specs/rt-link.yaml
@@ -2218,7 +2218,7 @@ attribute-sets:
name: conf
type: binary
sub-type: u32
- doc: u32 indexed by ipv6-devconf - 1 on output, on input it's a nest
+ doc: u32 indexed by ipv6-devconf on output, input is not yet implemented
-
name: stats
type: binary
--
2.55.0
^ permalink raw reply related [flat|nested] 8+ messages in thread* [PATCH net-next v2 2/3] netlink: specs: rt-link: add accept-ra-min-lft
2026-08-31 9:34 [PATCH net-next v2 0/3] netlink: specs: rt-link: ipv6 devconf updates Asbjørn Sloth Tønnesen
2026-08-31 9:34 ` [PATCH net-next v2 1/3] netlink: specs: rt-link: update ipv6 devconf doc Asbjørn Sloth Tønnesen
@ 2026-08-31 9:34 ` Asbjørn Sloth Tønnesen
2026-08-31 9:52 ` Fernando Fernandez Mancera
2026-08-31 9:34 ` [PATCH net-next v2 3/3] netlink: specs: rt-link: add force-forwarding Asbjørn Sloth Tønnesen
2026-09-01 13:30 ` [PATCH net-next v2 0/3] netlink: specs: rt-link: ipv6 devconf updates patchwork-bot+netdevbpf
3 siblings, 1 reply; 8+ messages in thread
From: Asbjørn Sloth Tønnesen @ 2026-08-31 9:34 UTC (permalink / raw)
To: Donald Hunter, Jakub Kicinski
Cc: Asbjørn Sloth Tønnesen, David S . Miller, Eric Dumazet,
Paolo Abeni, Simon Horman, Felix Maurer, Danielle Ratson,
Fernando Fernandez Mancera, Gabriel Goller, Patrick Rohr, netdev,
linux-kernel
Add missing enum member accept-ra-min-lft to ipv6-devconf.
In commit 1671bcfd76fd ("net: add sysctl accept_ra_min_rtr_lft")
the DEVCONF_* enum was extended with DEVCONF_ACCEPT_RA_MIN_RTR_LFT.
It was renamed to DEVCONF_ACCEPT_RA_MIN_LFT in commit 5027d54a9c30
("net: change accept_ra_min_rtr_lft to affect all RA lifetimes").
Shortly thereafter, this spec was introduced in commit b2f63d904e72
("doc/netlink: Add spec for rt link messages").
This pre-existing issue was detected by Sashiko, when reviewing the
first patch in this series.
Link: https://netdev-ai.bots.linux.dev/sashiko/#/patchset/20260824103816.40040-1-ast%40fiberby.net
Signed-off-by: Asbjørn Sloth Tønnesen <ast@fiberby.net>
---
Documentation/netlink/specs/rt-link.yaml | 2 ++
1 file changed, 2 insertions(+)
diff --git a/Documentation/netlink/specs/rt-link.yaml b/Documentation/netlink/specs/rt-link.yaml
index 00c915031efd..ab677801cde8 100644
--- a/Documentation/netlink/specs/rt-link.yaml
+++ b/Documentation/netlink/specs/rt-link.yaml
@@ -494,6 +494,8 @@ definitions:
name: ndisc-evict-nocarrier
-
name: accept-untracked-na
+ -
+ name: accept-ra-min-lft
-
name: ifla-icmp6-stats
enum-name:
--
2.55.0
^ permalink raw reply related [flat|nested] 8+ messages in thread* Re: [PATCH net-next v2 2/3] netlink: specs: rt-link: add accept-ra-min-lft
2026-08-31 9:34 ` [PATCH net-next v2 2/3] netlink: specs: rt-link: add accept-ra-min-lft Asbjørn Sloth Tønnesen
@ 2026-08-31 9:52 ` Fernando Fernandez Mancera
0 siblings, 0 replies; 8+ messages in thread
From: Fernando Fernandez Mancera @ 2026-08-31 9:52 UTC (permalink / raw)
To: Asbjørn Sloth Tønnesen, Donald Hunter, Jakub Kicinski
Cc: David S . Miller, Eric Dumazet, Paolo Abeni, Simon Horman,
Felix Maurer, Danielle Ratson, Gabriel Goller, Patrick Rohr,
netdev, linux-kernel
On 8/31/26 11:34 AM, Asbjørn Sloth Tønnesen wrote:
> Add missing enum member accept-ra-min-lft to ipv6-devconf.
>
> In commit 1671bcfd76fd ("net: add sysctl accept_ra_min_rtr_lft")
> the DEVCONF_* enum was extended with DEVCONF_ACCEPT_RA_MIN_RTR_LFT.
>
> It was renamed to DEVCONF_ACCEPT_RA_MIN_LFT in commit 5027d54a9c30
> ("net: change accept_ra_min_rtr_lft to affect all RA lifetimes").
>
> Shortly thereafter, this spec was introduced in commit b2f63d904e72
> ("doc/netlink: Add spec for rt link messages").
>
> This pre-existing issue was detected by Sashiko, when reviewing the
> first patch in this series.
>
> Link: https://netdev-ai.bots.linux.dev/sashiko/#/patchset/20260824103816.40040-1-ast%40fiberby.net
> Signed-off-by: Asbjørn Sloth Tønnesen <ast@fiberby.net>
Reviewed-by: Fernando Fernandez Mancera <fmancera@suse.de>
Thanks!
> ---
> Documentation/netlink/specs/rt-link.yaml | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/Documentation/netlink/specs/rt-link.yaml b/Documentation/netlink/specs/rt-link.yaml
> index 00c915031efd..ab677801cde8 100644
> --- a/Documentation/netlink/specs/rt-link.yaml
> +++ b/Documentation/netlink/specs/rt-link.yaml
> @@ -494,6 +494,8 @@ definitions:
> name: ndisc-evict-nocarrier
> -
> name: accept-untracked-na
> + -
> + name: accept-ra-min-lft
> -
> name: ifla-icmp6-stats
> enum-name:
^ permalink raw reply [flat|nested] 8+ messages in thread
* [PATCH net-next v2 3/3] netlink: specs: rt-link: add force-forwarding
2026-08-31 9:34 [PATCH net-next v2 0/3] netlink: specs: rt-link: ipv6 devconf updates Asbjørn Sloth Tønnesen
2026-08-31 9:34 ` [PATCH net-next v2 1/3] netlink: specs: rt-link: update ipv6 devconf doc Asbjørn Sloth Tønnesen
2026-08-31 9:34 ` [PATCH net-next v2 2/3] netlink: specs: rt-link: add accept-ra-min-lft Asbjørn Sloth Tønnesen
@ 2026-08-31 9:34 ` Asbjørn Sloth Tønnesen
2026-08-31 9:53 ` Fernando Fernandez Mancera
2026-08-31 12:54 ` Gabriel Goller
2026-09-01 13:30 ` [PATCH net-next v2 0/3] netlink: specs: rt-link: ipv6 devconf updates patchwork-bot+netdevbpf
3 siblings, 2 replies; 8+ messages in thread
From: Asbjørn Sloth Tønnesen @ 2026-08-31 9:34 UTC (permalink / raw)
To: Donald Hunter, Jakub Kicinski
Cc: Asbjørn Sloth Tønnesen, David S . Miller, Eric Dumazet,
Paolo Abeni, Simon Horman, Felix Maurer, Danielle Ratson,
Fernando Fernandez Mancera, Gabriel Goller, Patrick Rohr, netdev,
linux-kernel
Add missing enum member force-forwarding to ipv6-devconf.
In commit f24987ef6959 ("ipv6: add `force_forwarding` sysctl to
enable per-interface forwarding"), the DEVCONF_* enum was extended
with DEVCONF_FORCE_FORWARDING, however Gabriel forgot to add it
to the spec.
This pre-existing issue was detected by Sashiko, when reviewing the
first patch in this series.
Link: https://netdev-ai.bots.linux.dev/sashiko/#/patchset/20260824103816.40040-1-ast%40fiberby.net
Signed-off-by: Asbjørn Sloth Tønnesen <ast@fiberby.net>
---
Documentation/netlink/specs/rt-link.yaml | 2 ++
1 file changed, 2 insertions(+)
diff --git a/Documentation/netlink/specs/rt-link.yaml b/Documentation/netlink/specs/rt-link.yaml
index ab677801cde8..61ebb9a2bad5 100644
--- a/Documentation/netlink/specs/rt-link.yaml
+++ b/Documentation/netlink/specs/rt-link.yaml
@@ -496,6 +496,8 @@ definitions:
name: accept-untracked-na
-
name: accept-ra-min-lft
+ -
+ name: force-forwarding
-
name: ifla-icmp6-stats
enum-name:
--
2.55.0
^ permalink raw reply related [flat|nested] 8+ messages in thread* Re: [PATCH net-next v2 3/3] netlink: specs: rt-link: add force-forwarding
2026-08-31 9:34 ` [PATCH net-next v2 3/3] netlink: specs: rt-link: add force-forwarding Asbjørn Sloth Tønnesen
@ 2026-08-31 9:53 ` Fernando Fernandez Mancera
2026-08-31 12:54 ` Gabriel Goller
1 sibling, 0 replies; 8+ messages in thread
From: Fernando Fernandez Mancera @ 2026-08-31 9:53 UTC (permalink / raw)
To: Asbjørn Sloth Tønnesen, Donald Hunter, Jakub Kicinski
Cc: David S . Miller, Eric Dumazet, Paolo Abeni, Simon Horman,
Felix Maurer, Danielle Ratson, Gabriel Goller, Patrick Rohr,
netdev, linux-kernel
On 8/31/26 11:34 AM, Asbjørn Sloth Tønnesen wrote:
> Add missing enum member force-forwarding to ipv6-devconf.
>
> In commit f24987ef6959 ("ipv6: add `force_forwarding` sysctl to
> enable per-interface forwarding"), the DEVCONF_* enum was extended
> with DEVCONF_FORCE_FORWARDING, however Gabriel forgot to add it
> to the spec.
>
> This pre-existing issue was detected by Sashiko, when reviewing the
> first patch in this series.
>
> Link: https://netdev-ai.bots.linux.dev/sashiko/#/patchset/20260824103816.40040-1-ast%40fiberby.net
> Signed-off-by: Asbjørn Sloth Tønnesen <ast@fiberby.net>
Reviewed-by: Fernando Fernandez Mancera <fmancera@suse.de>
Thanks!
> ---
> Documentation/netlink/specs/rt-link.yaml | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/Documentation/netlink/specs/rt-link.yaml b/Documentation/netlink/specs/rt-link.yaml
> index ab677801cde8..61ebb9a2bad5 100644
> --- a/Documentation/netlink/specs/rt-link.yaml
> +++ b/Documentation/netlink/specs/rt-link.yaml
> @@ -496,6 +496,8 @@ definitions:
> name: accept-untracked-na
> -
> name: accept-ra-min-lft
> + -
> + name: force-forwarding
> -
> name: ifla-icmp6-stats
> enum-name:
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: [PATCH net-next v2 3/3] netlink: specs: rt-link: add force-forwarding
2026-08-31 9:34 ` [PATCH net-next v2 3/3] netlink: specs: rt-link: add force-forwarding Asbjørn Sloth Tønnesen
2026-08-31 9:53 ` Fernando Fernandez Mancera
@ 2026-08-31 12:54 ` Gabriel Goller
1 sibling, 0 replies; 8+ messages in thread
From: Gabriel Goller @ 2026-08-31 12:54 UTC (permalink / raw)
To: Asbjørn Sloth Tønnesen
Cc: Donald Hunter, Jakub Kicinski, David S . Miller, Eric Dumazet,
Paolo Abeni, Simon Horman, Felix Maurer, Danielle Ratson,
Fernando Fernandez Mancera, Patrick Rohr, netdev, linux-kernel
On 31.08.2026 09:34, Asbjørn Sloth Tønnesen wrote:
> Add missing enum member force-forwarding to ipv6-devconf.
>
> In commit f24987ef6959 ("ipv6: add `force_forwarding` sysctl to
> enable per-interface forwarding"), the DEVCONF_* enum was extended
> with DEVCONF_FORCE_FORWARDING, however Gabriel forgot to add it
> to the spec.
>
> This pre-existing issue was detected by Sashiko, when reviewing the
> first patch in this series.
>
> Link: https://netdev-ai.bots.linux.dev/sashiko/#/patchset/20260824103816.40040-1-ast%40fiberby.net
> Signed-off-by: Asbjørn Sloth Tønnesen <ast@fiberby.net>
> ---
Ahh, missed this. Thanks for fixing this!
Consider:
Reviewed-by: Gabriel Goller <g.goller@proxmox.com>
> Documentation/netlink/specs/rt-link.yaml | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/Documentation/netlink/specs/rt-link.yaml b/Documentation/netlink/specs/rt-link.yaml
> index ab677801cde8..61ebb9a2bad5 100644
> --- a/Documentation/netlink/specs/rt-link.yaml
> +++ b/Documentation/netlink/specs/rt-link.yaml
> @@ -496,6 +496,8 @@ definitions:
> name: accept-untracked-na
> -
> name: accept-ra-min-lft
> + -
> + name: force-forwarding
> -
> name: ifla-icmp6-stats
> enum-name:
> --
> 2.55.0
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH net-next v2 0/3] netlink: specs: rt-link: ipv6 devconf updates
2026-08-31 9:34 [PATCH net-next v2 0/3] netlink: specs: rt-link: ipv6 devconf updates Asbjørn Sloth Tønnesen
` (2 preceding siblings ...)
2026-08-31 9:34 ` [PATCH net-next v2 3/3] netlink: specs: rt-link: add force-forwarding Asbjørn Sloth Tønnesen
@ 2026-09-01 13:30 ` patchwork-bot+netdevbpf
3 siblings, 0 replies; 8+ messages in thread
From: patchwork-bot+netdevbpf @ 2026-09-01 13:30 UTC (permalink / raw)
To: =?utf-8?b?QXNiasO4cm4gU2xvdGggVMO4bm5lc2VuIDxhc3RAZmliZXJieS5uZXQ+?=
Cc: donald.hunter, kuba, davem, edumazet, pabeni, horms, fmaurer,
danieller, fmancera, g.goller, prohr, netdev, linux-kernel
Hello:
This series was applied to netdev/net-next.git (main)
by Paolo Abeni <pabeni@redhat.com>:
On Mon, 31 Aug 2026 09:34:52 +0000 you wrote:
> This series updates the doc-string for ifla-inet6-conf, and adds
> two missing ipv6-devconf enum values as identified by Sashiko
> during review of v1.
>
> Changes:
> v2:
> - Update commit message for net-next, and renamed from
> "netlink: specs: rt-link: fix ipv6 devconf doc"
> - Add Reviewed-by from Fernando (Thanks).
> - Sashiko comments:
> - Added missing enum members accept-ra-min-lft and force-forwarding
> as patch #2 and #3.
> - Re: data types: as Jakub wrote in the original commit 720447bd0b24
> ("netlink: specs: rt-link: remove implicit structs from devconf"):
> "u32 is probably best we can do right now", as the reality is that
> the sub-type varies per value.
> v1: https://lore.kernel.org/20260824103816.40040-1-ast@fiberby.net
>
> [...]
Here is the summary with links:
- [net-next,v2,1/3] netlink: specs: rt-link: update ipv6 devconf doc
https://git.kernel.org/netdev/net-next/c/5e63ade19044
- [net-next,v2,2/3] netlink: specs: rt-link: add accept-ra-min-lft
https://git.kernel.org/netdev/net-next/c/2b0aecb7b2b1
- [net-next,v2,3/3] netlink: specs: rt-link: add force-forwarding
https://git.kernel.org/netdev/net-next/c/f952040d7016
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 8+ messages in thread