Netdev List
 help / color / mirror / Atom feed
* [PATCH net] octeontx2-af: Fix BPID leak in nix_bp_enable()
@ 2026-09-01 10:25 nshettyj
  0 siblings, 0 replies; only message in thread
From: nshettyj @ 2026-09-01 10:25 UTC (permalink / raw)
  To: netdev, linux-kernel
  Cc: Rakesh Kudurumalla, Nitin Shetty J, Sunil Goutham,
	Ratheesh Kannoth, Geetha sowjanya, Subbaraya Sundeep, Andrew Lunn,
	David S. Miller, Eric Dumazet, Jakub Kicinski, Paolo Abeni

From: Rakesh Kudurumalla <rkudurumalla@marvell.com>

Avoid calling rvu_nix_get_bpid() after the last channel is programmed.
For LBK interfaces, each call allocates a BPID, so the extra final call
can leak one BPID.

Fixes: 27150bc4286c ("octeontx2-af: Interface backpressure configuration")
Signed-off-by: Nitin Shetty J <nshettyj@marvell.com>
Signed-off-by: Rakesh Kudurumalla <rkudurumalla@marvell.com>
---
 drivers/net/ethernet/marvell/octeontx2/af/rvu_nix.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/net/ethernet/marvell/octeontx2/af/rvu_nix.c b/drivers/net/ethernet/marvell/octeontx2/af/rvu_nix.c
index b81c47ea023b..c6164da4caa6 100644
--- a/drivers/net/ethernet/marvell/octeontx2/af/rvu_nix.c
+++ b/drivers/net/ethernet/marvell/octeontx2/af/rvu_nix.c
@@ -784,7 +784,8 @@ static int nix_bp_enable(struct rvu *rvu,
 		rvu_write64(rvu, blkaddr, NIX_AF_RX_CHANX_CFG(chan_v),
 			    cfg | (bpid & GENMASK_ULL(8, 0)) | BIT_ULL(16));
 		chan_id++;
-		bpid = rvu_nix_get_bpid(rvu, req, type, chan_id);
+		if (chan_id < req->chan_cnt)
+			bpid = rvu_nix_get_bpid(rvu, req, type, chan_id);
 	}
 
 	for (chan = 0; chan < req->chan_cnt; chan++) {
-- 
2.48.1


^ permalink raw reply related	[flat|nested] only message in thread

only message in thread, other threads:[~2026-09-01 10:25 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-09-01 10:25 [PATCH net] octeontx2-af: Fix BPID leak in nix_bp_enable() nshettyj

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox