* [PATCH net] octeontx2-af: Handle pool context address update in aura WRITE operation
@ 2026-09-01 10:50 nshettyj
0 siblings, 0 replies; only message in thread
From: nshettyj @ 2026-09-01 10:50 UTC (permalink / raw)
To: netdev, linux-kernel
Cc: Ashwin Sekhar T K, Nitin Shetty J, Sunil Goutham,
Ratheesh Kannoth, Geetha sowjanya, Subbaraya Sundeep, Andrew Lunn,
David S. Miller, Eric Dumazet, Jakub Kicinski, Paolo Abeni
From: Ashwin Sekhar T K <asekhar@marvell.com>
The NPA AQ WRITE operation for aura context was not translating the
pool_id in aura.pool_addr to the actual pool context IOVA, unlike the
INIT path which already did this correctly.
Add a helper npa_aura_translate_pool_addr() that validates pool_ctx,
checks bounds, and performs the pool_id to IOVA translation. Use it
in both the WRITE and INIT paths to fix the missing translation and
avoid code duplication.
Fixes: 4a3581cd5995 ("octeontx2-af: NPA AQ instruction enqueue support")
Signed-off-by: Nitin Shetty J <nshettyj@marvell.com>
Signed-off-by: Ashwin Sekhar T K <asekhar@marvell.com>
---
.../ethernet/marvell/octeontx2/af/rvu_npa.c | 28 +++++++++++++++----
1 file changed, 22 insertions(+), 6 deletions(-)
diff --git a/drivers/net/ethernet/marvell/octeontx2/af/rvu_npa.c b/drivers/net/ethernet/marvell/octeontx2/af/rvu_npa.c
index e2a33e46b48a..c8255271f84e 100644
--- a/drivers/net/ethernet/marvell/octeontx2/af/rvu_npa.c
+++ b/drivers/net/ethernet/marvell/octeontx2/af/rvu_npa.c
@@ -58,6 +58,19 @@ static int npa_aq_enqueue_wait(struct rvu *rvu, struct rvu_block *block,
return 0;
}
+static int npa_aura_translate_pool_addr(struct rvu_pfvf *pfvf, u64 *pool_addr)
+{
+ if (!pfvf->pool_ctx)
+ return NPA_AF_ERR_AQ_ENQUEUE;
+
+ if (*pool_addr >= pfvf->pool_ctx->qsize)
+ return NPA_AF_ERR_PARAM;
+
+ *pool_addr = pfvf->pool_ctx->iova +
+ (*pool_addr * pfvf->pool_ctx->entry_sz);
+ return 0;
+}
+
int rvu_npa_aq_enq_inst(struct rvu *rvu, struct npa_aq_enq_req *req,
struct npa_aq_enq_rsp *rsp)
{
@@ -116,6 +129,12 @@ int rvu_npa_aq_enq_inst(struct rvu *rvu, struct npa_aq_enq_req *req,
case NPA_AQ_INSTOP_WRITE:
/* Copy context and write mask */
if (req->ctype == NPA_AQ_CTYPE_AURA) {
+ if (req->aura_mask.pool_addr) {
+ rc = npa_aura_translate_pool_addr(pfvf,
+ &req->aura.pool_addr);
+ if (rc)
+ break;
+ }
memcpy(mask, &req->aura_mask,
sizeof(struct npa_aura_s));
memcpy(ctx, &req->aura, sizeof(struct npa_aura_s));
@@ -127,13 +146,10 @@ int rvu_npa_aq_enq_inst(struct rvu *rvu, struct npa_aq_enq_req *req,
break;
case NPA_AQ_INSTOP_INIT:
if (req->ctype == NPA_AQ_CTYPE_AURA) {
- if (req->aura.pool_addr >= pfvf->pool_ctx->qsize) {
- rc = NPA_AF_ERR_AQ_FULL;
+ rc = npa_aura_translate_pool_addr(pfvf,
+ &req->aura.pool_addr);
+ if (rc)
break;
- }
- /* Set pool's context address */
- req->aura.pool_addr = pfvf->pool_ctx->iova +
- (req->aura.pool_addr * pfvf->pool_ctx->entry_sz);
memcpy(ctx, &req->aura, sizeof(struct npa_aura_s));
} else { /* POOL's context */
memcpy(ctx, &req->pool, sizeof(struct npa_pool_s));
--
2.48.1
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2026-09-01 10:51 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-09-01 10:50 [PATCH net] octeontx2-af: Handle pool context address update in aura WRITE operation nshettyj
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox