From: Jiri Benc <jbenc@redhat.com>
To: Fourie Zhang <littleddfu@gmail.com>
Cc: netdev@vger.kernel.org, "David S . Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Eric Dumazet <edumazet@google.com>,
Simon Horman <horms@kernel.org>,
Jamal Hadi Salim <jhs@mojatatu.com>,
Cong Wang <xiyou.wangcong@gmail.com>,
Jiri Pirko <jiri@resnulli.us>, Aaron Conole <aconole@redhat.com>,
Ilya Maximets <i.maximets@ovn.org>,
dev@openvswitch.org, stable@vger.kernel.org,
Fourie Zhang <fouriezhang@tencent.com>
Subject: Re: [PATCH net] net: mpls: clear inner_protocol when the last label is popped
Date: Wed, 2 Sep 2026 11:03:47 +0200 [thread overview]
Message-ID: <20260902110319.279de291@griffin> (raw)
In-Reply-To: <20260902082924.2812968-1-fouriezhang@tencent.com>
On Wed, 2 Sep 2026 16:28:08 +0800, Fourie Zhang wrote:
> Fixes: c66549ffd666 ("openvswitch: correctly fragment packet with mpls headers")
The problem was actually introduced by 48d2ab609b6bb ("net: mpls:
Fixups for GSO"), which introduced the skb_set_inner_network_header and
skb_set_inner_protocol in push_mpls but forgot to reset them in
pop_mpls.
Apart of that, the fix looks reasonable to me. This is fortunately a
rather niche bug in practice (and to trigger intentionally, it requires
CAP_NET_ADMIN).
Please resend with the correct Fixes header.
Thanks!
Jiri
prev parent reply other threads:[~2026-09-02 9:04 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-02 8:28 [PATCH net] net: mpls: clear inner_protocol when the last label is popped Fourie Zhang
2026-09-02 9:03 ` Jiri Benc [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260902110319.279de291@griffin \
--to=jbenc@redhat.com \
--cc=aconole@redhat.com \
--cc=davem@davemloft.net \
--cc=dev@openvswitch.org \
--cc=edumazet@google.com \
--cc=fouriezhang@tencent.com \
--cc=horms@kernel.org \
--cc=i.maximets@ovn.org \
--cc=jhs@mojatatu.com \
--cc=jiri@resnulli.us \
--cc=kuba@kernel.org \
--cc=littleddfu@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=stable@vger.kernel.org \
--cc=xiyou.wangcong@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox